syzbot


possible deadlock in xfs_can_free_eofblocks (2)

Status: upstream: reported C repro on 2024/08/15 12:35
Subsystems: xfs
[Documentation on labels]
Reported-by: syzbot+53d541c7b07d55a392ca@syzkaller.appspotmail.com
First crash: 29d, last: 4h17m
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [xfs?] possible deadlock in xfs_can_free_eofblocks (2) 0 (1) 2024/08/15 12:35
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in xfs_can_free_eofblocks xfs 4 99d 124d 26/27 fixed on 2024/07/03 15:06

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.11.0-rc3-syzkaller-00013-g6b0f8db921ab #0 Not tainted
------------------------------------------------------
kswapd0/79 is trying to acquire lock:
ffff88801da74118 (&xfs_nondir_ilock_class#3){++++}-{3:3}, at: xfs_can_free_eofblocks+0x5f1/0x8d0 fs/xfs/xfs_bmap_util.c:550

but task is already holding lock:
ffffffff8ea2fce0 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat mm/vmscan.c:6841 [inline]
ffffffff8ea2fce0 (fs_reclaim){+.+.}-{0:0}, at: kswapd+0xbb4/0x35a0 mm/vmscan.c:7223

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (fs_reclaim){+.+.}-{0:0}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
       __fs_reclaim_acquire mm/page_alloc.c:3823 [inline]
       fs_reclaim_acquire+0x88/0x140 mm/page_alloc.c:3837
       might_alloc include/linux/sched/mm.h:334 [inline]
       slab_pre_alloc_hook mm/slub.c:3939 [inline]
       slab_alloc_node mm/slub.c:4017 [inline]
       __do_kmalloc_node mm/slub.c:4157 [inline]
       __kmalloc_noprof+0xa9/0x400 mm/slub.c:4170
       kmalloc_noprof include/linux/slab.h:685 [inline]
       xfs_attr_shortform_list+0x753/0x1900 fs/xfs/xfs_attr_list.c:117
       xfs_attr_list+0x1d0/0x270 fs/xfs/xfs_attr_list.c:595
       xfs_vn_listxattr+0x1d2/0x2c0 fs/xfs/xfs_xattr.c:341
       vfs_listxattr fs/xattr.c:493 [inline]
       listxattr+0x107/0x290 fs/xattr.c:841
       path_listxattr fs/xattr.c:865 [inline]
       __do_sys_llistxattr fs/xattr.c:883 [inline]
       __se_sys_llistxattr fs/xattr.c:880 [inline]
       __x64_sys_llistxattr+0x170/0x230 fs/xattr.c:880
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&xfs_nondir_ilock_class#3){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3133 [inline]
       check_prevs_add kernel/locking/lockdep.c:3252 [inline]
       validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
       __lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
       down_read_nested+0xb5/0xa50 kernel/locking/rwsem.c:1651
       xfs_can_free_eofblocks+0x5f1/0x8d0 fs/xfs/xfs_bmap_util.c:550
       xfs_inode_mark_reclaimable+0x1bb/0xf60 fs/xfs/xfs_icache.c:2148
       destroy_inode fs/inode.c:313 [inline]
       evict+0x549/0x630 fs/inode.c:694
       dispose_list fs/inode.c:712 [inline]
       prune_icache_sb+0x239/0x2f0 fs/inode.c:897
       super_cache_scan+0x38c/0x4b0 fs/super.c:223
       do_shrink_slab+0x701/0x1160 mm/shrinker.c:435
       shrink_slab+0x1090/0x14c0 mm/shrinker.c:662
       shrink_one+0x43b/0x850 mm/vmscan.c:4815
       shrink_many mm/vmscan.c:4876 [inline]
       lru_gen_shrink_node mm/vmscan.c:4954 [inline]
       shrink_node+0x3799/0x3de0 mm/vmscan.c:5934
       kswapd_shrink_node mm/vmscan.c:6762 [inline]
       balance_pgdat mm/vmscan.c:6954 [inline]
       kswapd+0x1bcd/0x35a0 mm/vmscan.c:7223
       kthread+0x2f0/0x390 kernel/kthread.c:389
       ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(fs_reclaim);
                               lock(&xfs_nondir_ilock_class#3);
                               lock(fs_reclaim);
  rlock(&xfs_nondir_ilock_class#3);

 *** DEADLOCK ***

2 locks held by kswapd0/79:
 #0: ffffffff8ea2fce0 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat mm/vmscan.c:6841 [inline]
 #0: ffffffff8ea2fce0 (fs_reclaim){+.+.}-{0:0}, at: kswapd+0xbb4/0x35a0 mm/vmscan.c:7223
 #1: ffff88803a2860e0 (&type->s_umount_key#44){.+.+}-{3:3}, at: super_trylock_shared fs/super.c:562 [inline]
 #1: ffff88803a2860e0 (&type->s_umount_key#44){.+.+}-{3:3}, at: super_cache_scan+0x94/0x4b0 fs/super.c:196

stack backtrace:
CPU: 0 UID: 0 PID: 79 Comm: kswapd0 Not tainted 6.11.0-rc3-syzkaller-00013-g6b0f8db921ab #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:93 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2186
 check_prev_add kernel/locking/lockdep.c:3133 [inline]
 check_prevs_add kernel/locking/lockdep.c:3252 [inline]
 validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
 __lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
 down_read_nested+0xb5/0xa50 kernel/locking/rwsem.c:1651
 xfs_can_free_eofblocks+0x5f1/0x8d0 fs/xfs/xfs_bmap_util.c:550
 xfs_inode_mark_reclaimable+0x1bb/0xf60 fs/xfs/xfs_icache.c:2148
 destroy_inode fs/inode.c:313 [inline]
 evict+0x549/0x630 fs/inode.c:694
 dispose_list fs/inode.c:712 [inline]
 prune_icache_sb+0x239/0x2f0 fs/inode.c:897
 super_cache_scan+0x38c/0x4b0 fs/super.c:223
 do_shrink_slab+0x701/0x1160 mm/shrinker.c:435
 shrink_slab+0x1090/0x14c0 mm/shrinker.c:662
 shrink_one+0x43b/0x850 mm/vmscan.c:4815
 shrink_many mm/vmscan.c:4876 [inline]
 lru_gen_shrink_node mm/vmscan.c:4954 [inline]
 shrink_node+0x3799/0x3de0 mm/vmscan.c:5934
 kswapd_shrink_node mm/vmscan.c:6762 [inline]
 balance_pgdat mm/vmscan.c:6954 [inline]
 kswapd+0x1bcd/0x35a0 mm/vmscan.c:7223
 kthread+0x2f0/0x390 kernel/kthread.c:389
 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
 </TASK>

Crashes (76):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/08/14 16:19 upstream 6b0f8db921ab 890d2dda .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/14 13:43 upstream 6b0f8db921ab 890d2dda .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/20 17:12 upstream 6e4436539ae1 9f0ab3fb .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/20 16:18 upstream 6e4436539ae1 9f0ab3fb .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/18 11:26 upstream c3f2d783a459 e1c76ab2 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 10:01 upstream e5fa841af679 e1c76ab2 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 09:32 upstream e5fa841af679 e1c76ab2 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/16 03:33 upstream d7a5aa4b3c00 e4bacdaf .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/14 19:12 upstream 6b0f8db921ab 890d2dda .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/18 00:27 upstream e5fa841af679 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in xfs_can_free_eofblocks
2024/08/14 17:10 upstream 6b0f8db921ab 890d2dda .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/12 09:31 upstream 7c6a3a65ace7 d94c83d8 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/11 09:59 upstream 8d8d276ba2fb 8ab55d0e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/11 07:16 upstream 8d8d276ba2fb 8ab55d0e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/11 04:28 upstream 8d8d276ba2fb 8ab55d0e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/10 07:57 upstream bc83b4d1f086 784df80e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/10 04:35 upstream bc83b4d1f086 784df80e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/08 22:48 upstream 89f5e14d05b4 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/08 07:00 upstream d1f2d51b711a 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/08 05:38 upstream d1f2d51b711a 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/08 03:25 upstream d1f2d51b711a 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/08 01:08 upstream d1f2d51b711a 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/07 22:28 upstream d1f2d51b711a 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/07 18:52 upstream b31c44928842 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/07 18:05 upstream b31c44928842 9750182a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/06 21:11 upstream b831f83e40a2 ce70880a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/06 20:02 upstream b831f83e40a2 ce70880a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/06 18:05 upstream b831f83e40a2 ce70880a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/06 00:39 upstream ad618736883b 464ac2ed .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/05 17:02 upstream c763c4339688 36ae3a26 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/05 11:56 upstream c763c4339688 36ae3a26 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/03 18:07 upstream 67784a74e258 8045124c .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/03 02:50 upstream 67784a74e258 0dd55198 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/03 00:33 upstream 67784a74e258 0dd55198 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/02 21:34 upstream 67784a74e258 0dd55198 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/02 12:41 upstream 67784a74e258 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/01 14:14 upstream 6cd90e5ea72f 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/01 11:26 upstream 6cd90e5ea72f 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/09/01 10:01 upstream 6cd90e5ea72f 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/31 20:47 upstream 1934261d8974 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/31 20:46 upstream 1934261d8974 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/31 16:49 upstream 1934261d8974 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/31 16:49 upstream 1934261d8974 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/31 12:32 upstream fb24560f31f9 1eda0d14 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/30 21:52 upstream 20371ba12063 db150e23 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/30 21:06 upstream 20371ba12063 db150e23 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/29 21:00 upstream d5d547aa7b51 9bd464fc .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/29 20:48 upstream d5d547aa7b51 9bd464fc .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/29 14:11 upstream d5d547aa7b51 9bd464fc .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/21 02:06 upstream 521b1e7f4cf0 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/20 17:19 upstream 6e4436539ae1 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/20 15:29 upstream 6e4436539ae1 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/20 14:39 upstream 6e4436539ae1 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/19 19:50 upstream b0da640826ba 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/19 14:46 upstream 47ac09b91bef 9f0ab3fb .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/19 06:13 upstream 47ac09b91bef e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/18 02:10 upstream df6cbc62cc9b e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 23:55 upstream df6cbc62cc9b e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 15:35 upstream e5fa841af679 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 09:07 upstream e5fa841af679 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/17 06:10 upstream 670c12ce09a8 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/16 22:11 upstream 670c12ce09a8 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/16 13:10 upstream d7a5aa4b3c00 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/16 10:30 upstream d7a5aa4b3c00 e1c76ab2 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/15 17:14 upstream 1fb918967b56 e4bacdaf .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/15 17:14 upstream 1fb918967b56 e4bacdaf .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/15 13:20 upstream 1fb918967b56 e4bacdaf .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
2024/08/15 06:01 upstream d07b43284ab3 e4bacdaf .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in xfs_can_free_eofblocks
* Struck through repros no longer work on HEAD.