syzbot


KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key

Status: upstream: reported C repro on 2024/02/03 08:40
Subsystems: hfs
[Documentation on labels]
Reported-by: syzbot+57028366b9825d8e8ad0@syzkaller.appspotmail.com
First crash: 315d, last: 11d
Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: KASAN: slab-out-of-bounds Write in hfsplus_bnode_read (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH next] hfsplus: fix oob in hfsplus_bnode_read_key 3 (3) 2024/02/07 06:23
[syzbot] [hfs?] KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key 1 (3) 2024/02/04 11:42
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key origin:upstream C error 11 25d 318d 0/3 upstream: reported C repro on 2024/01/30 17:02
Last patch testing requests (7)
Created Duration User Patch Repo Result
2024/11/24 18:25 23m retest repro upstream report log
2024/10/07 05:42 15m retest repro upstream report log
2024/09/18 19:45 20m retest repro linux-next report log
2024/07/10 13:58 20m retest repro linux-next report log
2024/04/27 18:03 18m retest repro linux-next report log
2024/02/17 02:50 22m retest repro linux-next error
2024/02/04 11:04 24m eadavis@qq.com patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master OK log

Sample crash report:
loop0: detected capacity change from 0 to 1024
==================================================================
BUG: KASAN: slab-out-of-bounds in memcpy_from_page include/linux/highmem.h:423 [inline]
BUG: KASAN: slab-out-of-bounds in hfsplus_bnode_read fs/hfsplus/bnode.c:32 [inline]
BUG: KASAN: slab-out-of-bounds in hfsplus_bnode_read_key+0x394/0x610 fs/hfsplus/bnode.c:70
Write of size 3970 at addr ffff888025e91800 by task syz-executor158/5837

CPU: 1 UID: 0 PID: 5837 Comm: syz-executor158 Not tainted 6.12.0-rc6-syzkaller-00279-gde2f378f2b77 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_address_description mm/kasan/report.c:377 [inline]
 print_report+0x169/0x550 mm/kasan/report.c:488
 kasan_report+0x143/0x180 mm/kasan/report.c:601
 kasan_check_range+0x282/0x290 mm/kasan/generic.c:189
 __asan_memcpy+0x40/0x70 mm/kasan/shadow.c:106
 memcpy_from_page include/linux/highmem.h:423 [inline]
 hfsplus_bnode_read fs/hfsplus/bnode.c:32 [inline]
 hfsplus_bnode_read_key+0x394/0x610 fs/hfsplus/bnode.c:70
 hfsplus_brec_insert+0x6ea/0xde0 fs/hfsplus/brec.c:141
 hfsplus_create_attr+0x4a2/0x640 fs/hfsplus/attributes.c:252
 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354
 hfsplus_setxattr+0xb0/0xe0 fs/hfsplus/xattr.c:432
 hfsplus_security_setxattr+0x40/0x60 fs/hfsplus/xattr_security.c:31
 __vfs_setxattr+0x46a/0x4a0 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
 vfs_setxattr+0x221/0x430 fs/xattr.c:321
 do_setxattr fs/xattr.c:629 [inline]
 path_setxattr+0x37e/0x4d0 fs/xattr.c:658
 __do_sys_setxattr fs/xattr.c:676 [inline]
 __se_sys_setxattr fs/xattr.c:672 [inline]
 __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:672
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9d9e77ba99
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff2426e2e8 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f9d9e77ba99
RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000020000240
RBP: 00007f9d9e7ef5f0 R08: 0000000000000000 R09: 000055557b2db4c0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff2426e310
R13: 00007fff2426e538 R14: 431bde82d7b634db R15: 00007f9d9e7c403b
 </TASK>

Allocated by task 5837:
 kasan_save_stack mm/kasan/common.c:47 [inline]
 kasan_save_track+0x3f/0x80 mm/kasan/common.c:68
 poison_kmalloc_redzone mm/kasan/common.c:377 [inline]
 __kasan_kmalloc+0x98/0xb0 mm/kasan/common.c:394
 kasan_kmalloc include/linux/kasan.h:257 [inline]
 __do_kmalloc_node mm/slub.c:4264 [inline]
 __kmalloc_noprof+0x1fc/0x400 mm/slub.c:4276
 kmalloc_noprof include/linux/slab.h:882 [inline]
 hfsplus_find_init+0x85/0x1c0 fs/hfsplus/bfind.c:21
 hfsplus_create_attr+0x161/0x640 fs/hfsplus/attributes.c:216
 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354
 hfsplus_setxattr+0xb0/0xe0 fs/hfsplus/xattr.c:432
 hfsplus_security_setxattr+0x40/0x60 fs/hfsplus/xattr_security.c:31
 __vfs_setxattr+0x46a/0x4a0 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
 vfs_setxattr+0x221/0x430 fs/xattr.c:321
 do_setxattr fs/xattr.c:629 [inline]
 path_setxattr+0x37e/0x4d0 fs/xattr.c:658
 __do_sys_setxattr fs/xattr.c:676 [inline]
 __se_sys_setxattr fs/xattr.c:672 [inline]
 __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:672
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

The buggy address belongs to the object at ffff888025e91800
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 0 bytes inside of
 allocated 536-byte region [ffff888025e91800, ffff888025e91a18)

The buggy address belongs to the physical page:
page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x25e90
head: order:3 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0
anon flags: 0xfff00000000040(head|node=0|zone=1|lastcpupid=0x7ff)
page_type: f5(slab)
raw: 00fff00000000040 ffff88801ac41dc0 0000000000000000 dead000000000001
raw: 0000000000000000 0000000080100010 00000001f5000000 0000000000000000
head: 00fff00000000040 ffff88801ac41dc0 0000000000000000 dead000000000001
head: 0000000000000000 0000000080100010 00000001f5000000 0000000000000000
head: 00fff00000000003 ffffea000097a401 ffffffffffffffff 0000000000000000
head: 0000000000000008 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0x252800(GFP_NOWAIT|__GFP_NORETRY|__GFP_COMP|__GFP_THISNODE), pid 1, tgid 1 (swapper/0), ts 9029677218, free_ts 0
 set_page_owner include/linux/page_owner.h:32 [inline]
 post_alloc_hook+0x1f3/0x230 mm/page_alloc.c:1537
 prep_new_page mm/page_alloc.c:1545 [inline]
 get_page_from_freelist+0x303f/0x3190 mm/page_alloc.c:3457
 __alloc_pages_noprof+0x292/0x710 mm/page_alloc.c:4733
 __alloc_pages_node_noprof include/linux/gfp.h:269 [inline]
 alloc_slab_page+0x59/0x140 mm/slub.c:2414
 allocate_slab+0x5a/0x2f0 mm/slub.c:2578
 new_slab mm/slub.c:2631 [inline]
 ___slab_alloc+0xcd1/0x14b0 mm/slub.c:3818
 __slab_alloc+0x58/0xa0 mm/slub.c:3908
 __slab_alloc_node mm/slub.c:3961 [inline]
 slab_alloc_node mm/slub.c:4122 [inline]
 __do_kmalloc_node mm/slub.c:4263 [inline]
 __kmalloc_node_noprof+0x286/0x440 mm/slub.c:4270
 kmalloc_array_node_noprof include/linux/slab.h:995 [inline]
 blk_mq_alloc_rq_map block/blk-mq.c:3374 [inline]
 blk_mq_alloc_map_and_rqs+0x137/0x970 block/blk-mq.c:3847
 __blk_mq_alloc_map_and_rqs block/blk-mq.c:3869 [inline]
 __blk_mq_alloc_rq_maps block/blk-mq.c:4383 [inline]
 blk_mq_alloc_set_map_and_rqs+0x19c/0x830 block/blk-mq.c:4414
 blk_mq_alloc_tag_set+0x7b4/0xf40 block/blk-mq.c:4586
 nbd_dev_add+0x37e/0xc70 drivers/block/nbd.c:1850
 nbd_init+0x210/0x2c0 drivers/block/nbd.c:2607
 do_one_initcall+0x24a/0x880 init/main.c:1269
 do_initcall_level+0x157/0x210 init/main.c:1331
 do_initcalls+0x3f/0x80 init/main.c:1347
page_owner free stack trace missing

Memory state around the buggy address:
 ffff888025e91900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 ffff888025e91980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff888025e91a00: 00 00 00 fc fc fc fc fc fc fc fc fc fc fc fc fc
                            ^
 ffff888025e91a80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff888025e91b00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/11/10 18:23 upstream de2f378f2b77 6b856513 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/09/23 05:40 upstream af9c191ac2a0 6f888b75 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/02/03 00:56 linux-next 076d56d74f17 60bf9982 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-linux-next-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/06/24 16:38 upstream f2661062f16b edc5149a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/04/09 23:17 upstream fe46a7dd189e 171ec371 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/03/24 18:24 upstream fe46a7dd189e 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/10/21 16:54 upstream 42f7652d3eb5 14517542 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/04/11 03:33 linux-next 6ebf211bb11d 56086b24 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/02/03 00:35 linux-next 076d56d74f17 60bf9982 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
2024/12/02 14:28 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 7b1d1d4cfac0 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 KASAN: slab-out-of-bounds Write in hfsplus_bnode_read_key
* Struck through repros no longer work on HEAD.