======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.299/4955 is trying to acquire lock:
ffff888074263120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
but task is already holding lock:
ffff888074263488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888074263488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
__dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:308
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_openat fs/open.c:1285 [inline]
__se_sys_openat fs/open.c:1280 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1280
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x57/0x510 fs/quota/dquot.c:507
ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
__dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1750
dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
dquot_alloc_space include/linux/quotaops.h:310 [inline]
dquot_alloc_block include/linux/quotaops.h:334 [inline]
ext4_mb_new_blocks+0x12d8/0x4d60 fs/ext4/mballoc.c:5742
ext4_ext_map_blocks+0x1b01/0x7630 fs/ext4/extents.c:4318
ext4_map_blocks+0xa66/0x1c70 fs/ext4/inode.c:672
ext4_getblk+0x19f/0x710 fs/ext4/inode.c:869
ext4_bread+0x2a/0x170 fs/ext4/inode.c:922
ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83
ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:3028
ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3074
vfs_mkdir+0x3b6/0x590 fs/namei.c:4065
do_mkdirat+0x260/0x520 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #4 (&ei->i_data_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ext4_truncate+0x974/0x1130 fs/ext4/inode.c:4244
ext4_setattr+0xf96/0x1990 fs/ext4/inode.c:5550
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
do_sys_ftruncate+0x2eb/0x390 fs/open.c:193
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #3 (jbd2_handle){++++}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
ocfs2_symlink+0x147f/0x2e20 fs/ocfs2/namei.c:1913
vfs_symlink+0x247/0x3d0 fs/namei.c:4429
do_symlinkat+0x1fd/0x600 fs/namei.c:4458
__do_sys_symlink fs/namei.c:4480 [inline]
__se_sys_symlink fs/namei.c:4478 [inline]
__x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
ocfs2_symlink+0x147f/0x2e20 fs/ocfs2/namei.c:1913
vfs_symlink+0x247/0x3d0 fs/namei.c:4429
do_symlinkat+0x1fd/0x600 fs/namei.c:4458
__do_sys_symlink fs/namei.c:4480 [inline]
__se_sys_symlink fs/namei.c:4478 [inline]
__x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #1 (sb_internal#4){.+.+}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977
dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2902
quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:173
__do_sys_quotactl fs/quota/quota.c:959 [inline]
__se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:915
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
__dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:308
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_openat fs/open.c:1285 [inline]
__se_sys_openat fs/open.c:1280 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1280
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Chain exists of:
&ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);
lock(&dquot->dq_lock);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);
lock(&ocfs2_quota_ip_alloc_sem_key);
*** DEADLOCK ***
5 locks held by syz.2.299/4955:
#0: ffff888079940460 (sb_writers#24){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
#1: ffff88805e8fa648 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff88805e8fa648 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline]
#1: ffff88805e8fa648 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: path_openat+0x824/0x2f20 fs/namei.c:3739
#2: ffff88805e886d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#2: ffff88805e886d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782
#3: ffff888061d5a0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806
#4: ffff888074263488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#4: ffff888074263488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
stack backtrace:
CPU: 1 PID: 4955 Comm: syz.2.299 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
__dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:308
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_openat fs/open.c:1285 [inline]
__se_sys_openat fs/open.c:1280 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1280
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fe87e404ff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe87c87d038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007fe87e5bcf80 RCX: 00007fe87e404ff9
RDX: 0000000000000042 RSI: 0000000020000040 RDI: ffffffffffffff9c
RBP: 00007fe87e477296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000084 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fe87e5bcf80 R15: 00007ffe80d77ea8
</TASK>