syzbot

ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.178-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor309/4731 is trying to acquire lock:
ffff88806c8d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff88806c8d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313

but task is already holding lock:
ffff88806c9740a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6173
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6156 [inline]
       ext4_free_blocks+0x1f5c/0x2e90 fs/ext4/mballoc.c:6286
       ext4_remove_blocks fs/ext4/extents.c:2523 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2689 [inline]
       ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2937
       ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4471
       ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4249
       ext4_evict_inode+0xba1/0x1100 fs/ext4/inode.c:289
       evict+0x529/0x930 fs/inode.c:622
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x33c/0x460 fs/namei.c:4162
       do_rmdir+0x368/0x670 fs/namei.c:4210
       __do_sys_rmdir fs/namei.c:4229 [inline]
       __se_sys_rmdir fs/namei.c:4227 [inline]
       __x64_sys_rmdir+0x45/0x50 fs/namei.c:4227
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665
       mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
       ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828
       do_writepages+0x481/0x730 mm/page-writeback.c:2386
       __writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647
       writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930
       __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001
       wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106
       wb_check_background_flush fs/fs-writeback.c:2172 [inline]
       wb_do_writeback fs/fs-writeback.c:2260 [inline]
       wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #4 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x4423/0x5890 fs/ocfs2/super.c:1140
       mount_bdev+0x2c9/0x3f0 fs/super.c:1400
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3012
       do_mount fs/namespace.c:3355 [inline]
       __do_sys_mount fs/namespace.c:3563 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x4423/0x5890 fs/ocfs2/super.c:1140
       mount_bdev+0x2c9/0x3f0 fs/super.c:1400
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3012
       do_mount fs/namespace.c:3355 [inline]
       __do_sys_mount fs/namespace.c:3563 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1813 [inline]
       sb_start_intwrite include/linux/fs.h:1930 [inline]
       ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977
       dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2904
       quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:173
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_write_info+0xd2/0x3a0 fs/ocfs2/quota_global.c:974
       dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2904
       quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:173
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:988
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:310
       ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1280
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ei->i_data_sem --> &dquot->dq_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dquot->dq_lock);
                               lock(&ei->i_data_sem);
                               lock(&dquot->dq_lock);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

4 locks held by syz-executor309/4731:
 #0: ffff888074ada460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff88806ca189c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff88806ca189c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline]
 #1: ffff88806ca189c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: path_openat+0x824/0x2f20 fs/namei.c:3739
 #2: ffff88806c9689c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #2: ffff88806c9689c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782
 #3: ffff88806c9740a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806

stack backtrace:
CPU: 0 PID: 4731 Comm: syz-executor309 Not tainted 5.15.178-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:789 [inline]
 ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
 ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
 dqget+0x762/0xe90 fs/quota/dquot.c:988
 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
 ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:310
 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674
 lookup_open fs/namei.c:3462 [inline]
 open_last_lookups fs/namei.c:3532 [inline]
 path_openat+0x130a/0x2f20 fs/namei.c:3739
 do_filp_open+0x21c/0x460 fs/namei.c:3769
 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
 do_sys_open fs/open.c:1269 [inline]
 __do_sys_openat fs/open.c:1285 [inline]
 __se_sys_openat fs/open.c:1280 [inline]
 __x64_sys_openat+0x243/0x290 fs/open.c:1280
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f66505cf4d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffeb71c3e28 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00004000000000c0 RCX: 00007f66505cf4d9
RDX: 000000000000275a RSI: 00004000000000c0 RDI: 00000000ffffff9c
RBP: 0000400000004780 R08: 0000400000008f40 R09: 0000400000008f40
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffeb71c3e5c
R13: 0000000000000026 R14: 431bde82d7b634db R15: 00007ffeb71c3e90
 </TASK>
(syz-executor309,4731,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x2c7b5077, computed 0x28030c75. Applying ECC.
(syz-executor309,4731,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x2c7b5077, computed 0x28d1d8ae
(syz-executor309,4731,0):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz-executor309,4731,0):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop1): find_tree_dqentry: Can't read quota tree block 5
Quota error (device loop1): qtree_read_dquot: Can't read quota structure for id 0
(syz-executor309,4731,0):ocfs2_acquire_dquot:873 ERROR: status = -5
(syz-executor309,4731,0):ocfs2_mknod:314 ERROR: status = -5
(syz-executor309,4731,0):ocfs2_mknod:502 ERROR: status = -5
(syz-executor309,4731,0):ocfs2_create:676 ERROR: status = -5