syzbot

======================================================
WARNING: possible circular locking dependency detected
6.17.0-rc1-syzkaller-00111-g24ea63ea3877 #0 Tainted: G        W          
------------------------------------------------------
syz.5.325/7748 is trying to acquire lock:
ffff88805d9187d0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff88805d918b80 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff88805d918b80 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:869 [inline]
       ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828
       dqget+0x7c1/0xf20 fs/quota/dquot.c:977
       ocfs2_setattr+0xd72/0x1b40 fs/ocfs2/file.c:1233
       notify_change+0xb31/0xe60 fs/attr.c:552
       chown_common+0x40c/0x5c0 fs/open.c:791
       vfs_fchown fs/open.c:859 [inline]
       ksys_fchown+0xea/0x160 fs/open.c:871
       __do_sys_fchown fs/open.c:876 [inline]
       __se_sys_fchown fs/open.c:874 [inline]
       __x64_sys_fchown+0x7a/0x90 fs/open.c:874
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&dquot->dq_lock){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/rtmutex_api.c:535 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:547
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x73a/0xf20 fs/quota/dquot.c:972
       dquot_transfer+0x2f8/0x6d0 fs/quota/dquot.c:2140
       ext4_setattr+0x865/0x1bc0 fs/ext4/inode.c:5902
       notify_change+0xb31/0xe60 fs/attr.c:552
       chown_common+0x40c/0x5c0 fs/open.c:791
       vfs_fchown fs/open.c:859 [inline]
       ksys_fchown+0xea/0x160 fs/open.c:871
       __do_sys_fchown fs/open.c:876 [inline]
       __se_sys_fchown fs/open.c:874 [inline]
       __x64_sys_fchown+0x7a/0x90 fs/open.c:874
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (&ei->xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline]
       ext4_xattr_set_handle+0x165/0x1590 fs/ext4/xattr.c:2362
       ext4_initxattrs+0x9f/0x110 fs/ext4/xattr_security.c:44
       security_inode_init_security+0x29d/0x3f0 security/security.c:1852
       __ext4_new_inode+0x3314/0x3cb0 fs/ext4/ialloc.c:1325
       ext4_create+0x22d/0x460 fs/ext4/namei.c:2822
       lookup_open fs/namei.c:3708 [inline]
       open_last_lookups fs/namei.c:3807 [inline]
       path_openat+0x14fd/0x3840 fs/namei.c:4043
       do_filp_open+0x1fa/0x410 fs/namei.c:4073
       do_sys_openat2+0x121/0x1c0 fs/open.c:1435
       do_sys_open fs/open.c:1450 [inline]
       __do_sys_openat fs/open.c:1466 [inline]
       __se_sys_openat fs/open.c:1461 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1461
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x377/0x6d0 fs/ocfs2/journal.c:374
       ocfs2_shutdown_local_alloc+0x200/0xa10 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x201/0x8d0 fs/ocfs2/super.c:1825
       generic_shutdown_super+0x132/0x2c0 fs/super.c:643
       kill_block_super+0x44/0x90 fs/super.c:1766
       deactivate_locked_super+0xbc/0x130 fs/super.c:474
       cleanup_mnt+0x425/0x4c0 fs/namespace.c:1378
       task_work_run+0x1d1/0x260 kernel/task_work.c:227
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       exit_to_user_mode_loop+0xec/0x110 kernel/entry/common.c:43
       exit_to_user_mode_prepare include/linux/irq-entry-common.h:225 [inline]
       syscall_exit_to_user_mode_work include/linux/entry-common.h:175 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:210 [inline]
       do_syscall_64+0x2bd/0x3b0 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x36b/0x6d0 fs/ocfs2/journal.c:372
       ocfs2_shutdown_local_alloc+0x200/0xa10 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x201/0x8d0 fs/ocfs2/super.c:1825
       generic_shutdown_super+0x132/0x2c0 fs/super.c:643
       kill_block_super+0x44/0x90 fs/super.c:1766
       deactivate_locked_super+0xbc/0x130 fs/super.c:474
       cleanup_mnt+0x425/0x4c0 fs/namespace.c:1378
       task_work_run+0x1d1/0x260 kernel/task_work.c:227
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       exit_to_user_mode_loop+0xec/0x110 kernel/entry/common.c:43
       exit_to_user_mode_prepare include/linux/irq-entry-common.h:225 [inline]
       syscall_exit_to_user_mode_work include/linux/entry-common.h:175 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:210 [inline]
       do_syscall_64+0x2bd/0x3b0 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#3){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1798 [inline]
       sb_start_intwrite include/linux/fs.h:1981 [inline]
       ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370
       ocfs2_extend_dir+0x10a8/0x4870 fs/ocfs2/dir.c:3294
       ocfs2_prepare_dx_dir_for_insert fs/ocfs2/dir.c:4232 [inline]
       ocfs2_prepare_dir_for_insert+0x3d7b/0x5450 fs/ocfs2/dir.c:4288
       ocfs2_mknod+0x819/0x2050 fs/ocfs2/namei.c:297
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:659
       vfs_mkdir+0x306/0x510 fs/namei.c:4366
       do_mkdirat+0x247/0x590 fs/namei.c:4399
       __do_sys_mkdirat fs/namei.c:4416 [inline]
       __se_sys_mkdirat fs/namei.c:4414 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4414
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828
       dqget+0x7c1/0xf20 fs/quota/dquot.c:977
       ocfs2_setattr+0xd72/0x1b40 fs/ocfs2/file.c:1233
       notify_change+0xb31/0xe60 fs/attr.c:552
       chown_common+0x40c/0x5c0 fs/open.c:791
       vfs_fchown fs/open.c:859 [inline]
       ksys_fchown+0xea/0x160 fs/open.c:871
       __do_sys_fchown fs/open.c:876 [inline]
       __se_sys_fchown fs/open.c:874 [inline]
       __x64_sys_fchown+0x7a/0x90 fs/open.c:874
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

4 locks held by syz.5.325/7748:
 #0: ffff88802f1fa488 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write_file+0x63/0x210 fs/namespace.c:601
 #1: ffff88806007be80 (&type->i_mutex_dir_key#12){++++}-{4:4}, at: inode_lock_killable include/linux/fs.h:874 [inline]
 #1: ffff88806007be80 (&type->i_mutex_dir_key#12){++++}-{4:4}, at: chown_common+0x313/0x5c0 fs/open.c:779
 #2: ffff88805d94c098 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb30 fs/ocfs2/quota_global.c:823
 #3: ffff88805d918b80 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #3: ffff88805d918b80 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 UID: 0 PID: 7748 Comm: syz.5.325 Tainted: G        W           6.17.0-rc1-syzkaller-00111-g24ea63ea3877 #0 PREEMPT_{RT,(full)} 
Tainted: [W]=WARN
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
 ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828
 dqget+0x7c1/0xf20 fs/quota/dquot.c:977
 ocfs2_setattr+0xd72/0x1b40 fs/ocfs2/file.c:1233
 notify_change+0xb31/0xe60 fs/attr.c:552
 chown_common+0x40c/0x5c0 fs/open.c:791
 vfs_fchown fs/open.c:859 [inline]
 ksys_fchown+0xea/0x160 fs/open.c:871
 __do_sys_fchown fs/open.c:876 [inline]
 __se_sys_fchown fs/open.c:874 [inline]
 __x64_sys_fchown+0x7a/0x90 fs/open.c:874
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fd6d439ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd6d25fe038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d
RAX: ffffffffffffffda RBX: 00007fd6d45c5fa0 RCX: 00007fd6d439ebe9
RDX: 000000002c78570a RSI: 000000003a736e6f RDI: 0000000000000006
RBP: 00007fd6d4421e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fd6d45c6038 R14: 00007fd6d45c5fa0 R15: 00007ffcf6b606e8
 </TASK>