syzbot


possible deadlock in ocfs2_lock_global_qf

Status: upstream: reported on 2024/10/01 11:31
Reported-by: syzbot+b90c04eefce88898e5b7@syzkaller.appspotmail.com
First crash: 4d12h, last: 2d09h
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ocfs2_lock_global_qf ocfs2 68 1h49m 2d06h 0/28 upstream: reported on 2024/10/03 18:26
linux-5.15 possible deadlock in ocfs2_lock_global_qf 4 12h53m 6d02h 0/3 upstream: reported on 2024/09/29 22:07

Sample crash report:
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.112-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.4860/14850 is trying to acquire lock:
ffff888057f15be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff888057f15f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888057f15f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831
       quota_setquota+0x6d3/0x840 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6776
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1940
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6145 [inline]
       ext4_free_blocks+0x1fb8/0x3020 fs/ext4/mballoc.c:6275
       ext4_remove_blocks fs/ext4/extents.c:2521 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2687 [inline]
       ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2935
       ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4448
       ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288
       ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286
       evict+0x529/0x930 fs/inode.c:701
       do_unlinkat+0x509/0x820 fs/namei.c:4399
       __do_sys_unlink fs/namei.c:4440 [inline]
       __se_sys_unlink fs/namei.c:4438 [inline]
       __x64_sys_unlink+0x45/0x50 fs/namei.c:4438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4283
       ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5598
       notify_change+0xce3/0xfc0 fs/attr.c:499
       do_truncate+0x21c/0x300 fs/open.c:65
       do_sys_ftruncate+0x2e2/0x380 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879
       generic_shutdown_super+0x130/0x340 fs/super.c:501
       kill_block_super+0x7a/0xe0 fs/super.c:1470
       deactivate_locked_super+0xa0/0x110 fs/super.c:332
       cleanup_mnt+0x490/0x520 fs/namespace.c:1186
       task_work_run+0x246/0x300 kernel/task_work.c:203
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline]
       syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879
       generic_shutdown_super+0x130/0x340 fs/super.c:501
       kill_block_super+0x7a/0xe0 fs/super.c:1470
       deactivate_locked_super+0xa0/0x110 fs/super.c:332
       cleanup_mnt+0x490/0x520 fs/namespace.c:1186
       task_work_run+0x246/0x300 kernel/task_work.c:203
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline]
       syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#5){.+.+}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977
       dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2909
       quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:174
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831
       quota_setquota+0x6d3/0x840 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

3 locks held by syz.2.4860/14850:
 #0: ffff88805b9ae0e0 (&type->s_umount_key#85){++++}-{3:3}, at: user_get_super+0x11a/0x250 fs/super.c:889
 #1: ffff888066a580a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806
 #2: ffff888057f15f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888057f15f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 PID: 14850 Comm: syz.2.4860 Not tainted 6.1.112-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
 dqget+0x762/0xe90 fs/quota/dquot.c:986
 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831
 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310
 __do_sys_quotactl fs/quota/quota.c:960 [inline]
 __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f4d45f7dff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4d46dd8038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007f4d46135f80 RCX: 00007f4d45f7dff9
RDX: 0000000000000000 RSI: 0000000020000000 RDI: ffffffff80000801
RBP: 00007f4d45ff0296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020000f00 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f4d46135f80 R15: 00007ffecf4c6178
 </TASK>

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/10/03 15:15 linux-6.1.y aa4cd140bba5 d7906eff .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_global_qf
2024/10/03 15:15 linux-6.1.y aa4cd140bba5 d7906eff .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_global_qf
2024/10/02 11:34 linux-6.1.y aa4cd140bba5 02f9582a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_global_qf
2024/10/02 11:34 linux-6.1.y aa4cd140bba5 02f9582a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_global_qf
2024/10/01 11:31 linux-6.1.y aa4cd140bba5 ea2b66a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_global_qf
2024/10/03 02:48 linux-6.1.y aa4cd140bba5 a4c7fd36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_global_qf
2024/10/03 02:47 linux-6.1.y aa4cd140bba5 a4c7fd36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_global_qf
2024/10/03 02:47 linux-6.1.y aa4cd140bba5 a4c7fd36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_global_qf
* Struck through repros no longer work on HEAD.