memory leak in edge_startup

Status: fixed on 2021/04/09 19:46
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+59f777bdcbdd7eea5305@syzkaller.appspotmail.com
Fix commit: cfdc67acc785 USB: serial: io_edgeport: fix memory leak in edge_startup
First crash: 1977d, last: 1977d
▶ ▼ Discussions (10)
Title Replies (including bot) Last reply
[PATCH 4.9 00/78] 4.9.262-rc1 review 85 (85) 2021/03/28 20:37
[PATCH 5.10 000/290] 5.10.24-rc1 review 317 (317) 2021/03/22 08:15
[PATCH 5.11 000/306] 5.11.7-rc1 review 313 (313) 2021/03/19 09:50
[PATCH 4.19 000/120] 4.19.181-rc1 review 137 (137) 2021/03/19 09:41
[PATCH 4.14 00/95] 4.14.226-rc1 review 105 (105) 2021/03/18 12:00
[PATCH 5.4 000/168] 5.4.106-rc1 review 175 (175) 2021/03/17 03:00
[PATCH 4.4 00/75] 4.4.262-rc1 review 80 (80) 2021/03/16 12:07
[PATCH] usb: serial: io_edgeport: fix memory leak in edge_startup 2 (2) 2021/03/05 09:53
Re: memory leak in edge_startup 1 (1) 2021/03/02 08:50
memory leak in edge_startup 0 (1) 2021/03/01 19:29
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2021/03/01 22:34 18m paskripkin@gmail.com https://linux.googlesource.com/linux/kernel/git/torvalds/linux refs/changes/56/8756/1 OK

Sample crash report:
BUG: memory leak
unreferenced object 0xffff88810dc5a800 (size 2048):
  comm "kworker/1:3", pid 4818, jiffies 4294960503 (age 15.050s)
  hex dump (first 32 bytes):
    20 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ...............
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000153c6b11>] kmalloc include/linux/slab.h:554 [inline]
    [<00000000153c6b11>] kzalloc include/linux/slab.h:684 [inline]
    [<00000000153c6b11>] edge_startup+0x3f/0x11f0 drivers/usb/serial/io_edgeport.c:2833
    [<000000007c25fa28>] usb_serial_probe.cold+0x6ab/0xb84 drivers/usb/serial/usb-serial.c:1027
    [<0000000050250e6f>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<00000000a08d4f3b>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
    [<000000009356c1ed>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000aa8a21fd>] __device_attach+0x122/0x250 drivers/base/dd.c:914
    [<00000000ee865ab7>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000005ea173b6>] device_add+0x5d5/0xc40 drivers/base/core.c:3242
    [<000000003faa2805>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<0000000099ff1454>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000a57fa7c3>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<00000000a08d4f3b>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846

BUG: memory leak
unreferenced object 0xffff888110c17540 (size 192):
  comm "kworker/1:3", pid 4818, jiffies 4294960524 (age 14.840s)
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 58 75 c1 10 81 88 ff ff  ........Xu......
  backtrace:
    [<000000003178be4d>] kmalloc include/linux/slab.h:559 [inline]
    [<000000003178be4d>] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74
    [<0000000006a81376>] edge_startup+0xd20/0x11f0 drivers/usb/serial/io_edgeport.c:2926
    [<000000007c25fa28>] usb_serial_probe.cold+0x6ab/0xb84 drivers/usb/serial/usb-serial.c:1027
    [<0000000050250e6f>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<00000000a08d4f3b>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
    [<000000009356c1ed>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000aa8a21fd>] __device_attach+0x122/0x250 drivers/base/dd.c:914
    [<00000000ee865ab7>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000005ea173b6>] device_add+0x5d5/0xc40 drivers/base/core.c:3242
    [<000000003faa2805>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<0000000099ff1454>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000a57fa7c3>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740

BUG: memory leak
unreferenced object 0xffff888110c17240 (size 192):
  comm "kworker/1:3", pid 4818, jiffies 4294960524 (age 14.840s)
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 58 72 c1 10 81 88 ff ff  ........Xr......
  backtrace:
    [<000000003178be4d>] kmalloc include/linux/slab.h:559 [inline]
    [<000000003178be4d>] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74
    [<000000004f167a1a>] edge_startup+0xebf/0x11f0 drivers/usb/serial/io_edgeport.c:2963
    [<000000007c25fa28>] usb_serial_probe.cold+0x6ab/0xb84 drivers/usb/serial/usb-serial.c:1027
    [<0000000050250e6f>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
    [<00000000a08d4f3b>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
    [<000000009356c1ed>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000aa8a21fd>] __device_attach+0x122/0x250 drivers/base/dd.c:914
    [<00000000ee865ab7>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<000000005ea173b6>] device_add+0x5d5/0xc40 drivers/base/core.c:3242
    [<000000003faa2805>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<0000000099ff1454>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000a57fa7c3>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000f10f144c>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
    [<0000000036a9ab90>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/02/25 19:27 upstream 29c395c77a9a 76f7fc95 .config console log report syz C ci-upstream-gce-leak memory leak in edge_startup
* Struck through repros no longer work on HEAD.