syzbot


WARNING in mptcp_check_listen_stop

Status: fixed on 2024/01/30 15:47
Subsystems: mptcp
[Documentation on labels]
Reported-by: syzbot+5a01c3a666e726bc8752@syzkaller.appspotmail.com
Fix commit: 4c0288299fd0 mptcp: prevent tcp diag from closing listener subflows
First crash: 162d, last: 114d
Cause bisection: introduced by (bisect log) :
commit 57fc0f1ceaa4016354cf6f88533e20b56190e41a
Author: Paolo Abeni <pabeni@redhat.com>
Date: Tue Jun 20 16:24:23 2023 +0000

  mptcp: ensure listener is unhashed before updating the sk status

Crash: WARNING in mptcp_check_listen_stop (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH net 0/2] mptcp: new reviewer and prevent a warning 3 (3) 2024/01/03 00:20
[syzbot] [mptcp?] WARNING in mptcp_check_listen_stop 1 (4) 2023/12/15 03:20

Sample crash report:
------------[ cut here ]------------
WARNING: CPU: 0 PID: 5072 at net/mptcp/protocol.c:2999 mptcp_check_listen_stop.part.0+0x17b/0x240 net/mptcp/protocol.c:2999
Modules linked in:
CPU: 0 PID: 5072 Comm: syz-executor408 Not tainted 6.7.0-rc5-syzkaller-00230-g3b8a9b2e6809 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
RIP: 0010:mptcp_check_listen_stop.part.0+0x17b/0x240 net/mptcp/protocol.c:2999
Code: 00 00 00 0f b6 45 12 88 44 24 20 44 0f b6 6c 24 20 bf 0a 00 00 00 44 89 ee e8 d1 59 24 f7 41 80 fd 0a 74 2b e8 96 5e 24 f7 90 <0f> 0b 90 e8 8d 5e 24 f7 48 b8 00 00 00 00 00 fc ff df 49 c7 04 04
RSP: 0018:ffffc9000401fb50 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff8880252a0000 RCX: ffffffff8a63102f
RDX: ffff888016b28000 RSI: ffffffff8a63103a RDI: 0000000000000001
RBP: ffff888025290d00 R08: 0000000000000001 R09: 000000000000000a
R10: 0000000000000007 R11: 0000000000000002 R12: 1ffff92000803f6a
R13: 0000000000000007 R14: ffff8880252a0012 R15: 000000000000000a
FS:  0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fe966dc7110 CR3: 000000000cd77000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 mptcp_check_listen_stop net/mptcp/protocol.c:3032 [inline]
 __mptcp_close+0x888/0xa10 net/mptcp/protocol.c:3020
 mptcp_close+0x28/0xf0 net/mptcp/protocol.c:3087
 inet_release+0x132/0x270 net/ipv4/af_inet.c:433
 inet6_release+0x4f/0x70 net/ipv6/af_inet6.c:485
 __sock_release+0xae/0x260 net/socket.c:659
 sock_close+0x1c/0x20 net/socket.c:1419
 __fput+0x270/0xb70 fs/file_table.c:394
 task_work_run+0x14d/0x240 kernel/task_work.c:180
 exit_task_work include/linux/task_work.h:38 [inline]
 do_exit+0xa8a/0x2ad0 kernel/exit.c:869
 do_group_exit+0xd4/0x2a0 kernel/exit.c:1018
 __do_sys_exit_group kernel/exit.c:1029 [inline]
 __se_sys_exit_group kernel/exit.c:1027 [inline]
 __x64_sys_exit_group+0x3e/0x50 kernel/exit.c:1027
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x63/0x6b
RIP: 0033:0x7fe966d4bc09
Code: Unable to access opcode bytes at 0x7fe966d4bbdf.
RSP: 002b:00007ffd9abaaef8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fe966d4bc09
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000
RBP: 00007fe966dc62b0 R08: ffffffffffffffb8 R09: 0000000000000006
R10: 0000000000000006 R11: 0000000000000246 R12: 00007fe966dc62b0
R13: 0000000000000000 R14: 00007fe966dc6d00 R15: 00007fe966d1ce70
 </TASK>

Crashes (47):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/12/17 18:00 upstream 3b8a9b2e6809 3222d10c .config strace log report syz C [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce WARNING in mptcp_check_listen_stop
2023/12/13 18:53 net 2513974cc3e1 ebcad15c .config strace log report syz C [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_check_listen_stop
2023/12/19 11:01 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0bcda4cd6851 3ad490ea .config console log report syz C [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2023/12/14 16:28 upstream 5bd7ef53ffe5 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root WARNING in mptcp_check_listen_stop
2023/12/14 16:23 upstream 5bd7ef53ffe5 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce WARNING in mptcp_check_listen_stop
2023/12/23 09:15 upstream 8afe6f0e0e25 fb427a07 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 WARNING in mptcp_check_listen_stop
2023/12/14 16:31 upstream 5bd7ef53ffe5 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 WARNING in mptcp_check_listen_stop
2023/12/14 16:29 net 89e0c6467eef 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_check_listen_stop
2023/12/13 18:03 net 2513974cc3e1 ebcad15c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_check_listen_stop
2023/12/14 16:08 net-next 00b1b2296b58 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce WARNING in mptcp_check_listen_stop
2024/01/30 13:43 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 7f400fcb .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/29 23:22 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 991a98f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/29 15:00 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 991a98f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/29 14:00 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 991a98f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/28 12:10 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/27 17:22 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/27 15:00 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/25 20:47 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/25 19:13 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/25 18:25 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/25 18:03 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca cc4a4020 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/25 09:36 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1e153dc8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/24 19:22 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1e153dc8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/24 04:30 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1e153dc8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/23 17:24 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1e153dc8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/23 17:04 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1e153dc8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/23 05:15 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1c0ecc51 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/23 02:02 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1c0ecc51 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/23 00:01 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 1c0ecc51 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/22 18:52 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 9bd8dcda .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/22 04:58 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 9bd8dcda .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/21 14:18 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 9bd8dcda .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/20 04:53 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 9bd8dcda .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/20 04:29 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 9bd8dcda .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/19 11:36 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 21772ce4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/19 02:30 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/18 16:23 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/18 15:58 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/18 13:09 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/18 11:49 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/18 06:53 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 915053c7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/17 20:46 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 915053c7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/17 16:30 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 915053c7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/17 15:26 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 915053c7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2024/01/17 02:10 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 0802e17d9aca 2a7bcc7f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
2023/12/14 16:24 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci d5b235ec8eab 3222d10c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 WARNING in mptcp_check_listen_stop
* Struck through repros no longer work on HEAD.