syzbot


WARNING: locking bug in take_dentry_name_snapshot

Status: upstream: reported C repro on 2023/02/12 07:11
Labels: reiserfs overlayfs (incorrect?)
Reported-by: syzbot+5a195884ee3ad761db4e@syzkaller.appspotmail.com
First crash: 114d, last: 50d

Cause bisection: failed (error log, bisect log)

Fix bisection: fixed by (bisect log) :
commit 52ca4b6435a493e47aaa98e7345e19e1e8710b13
Author: Roberto Sassu <roberto.sassu@huawei.com>
Date: Tue Mar 14 08:17:15 2023 +0000

  reiserfs: Switch to security_inode_init_security()

Discussions (2)
Title Replies (including bot) Last reply
[syzbot] WARNING: locking bug in take_dentry_name_snapshot 0 (4) 2023/05/19 20:56
[syzbot] Monthly overlayfs report 0 (1) 2023/04/05 08:55

Sample crash report:
REISERFS (device loop0): Using r5 hash to sort names
REISERFS warning (device loop0): jdm-13090 reiserfs_new_inode: ACLs aren't enabled in the fs, but vfs thinks they are!
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
overlayfs: upper fs needs to support d_type.
overlayfs: upper fs does not support tmpfile.
------------[ cut here ]------------
DEBUG_LOCKS_WARN_ON(1)
WARNING: CPU: 1 PID: 6434 at kernel/locking/lockdep.c:232 hlock_class kernel/locking/lockdep.c:232 [inline]
WARNING: CPU: 1 PID: 6434 at kernel/locking/lockdep.c:232 hlock_class kernel/locking/lockdep.c:221 [inline]
WARNING: CPU: 1 PID: 6434 at kernel/locking/lockdep.c:232 check_wait_context kernel/locking/lockdep.c:4730 [inline]
WARNING: CPU: 1 PID: 6434 at kernel/locking/lockdep.c:232 __lock_acquire+0x1615/0x5d40 kernel/locking/lockdep.c:5006
Modules linked in:
CPU: 1 PID: 6434 Comm: syz-executor246 Not tainted 6.3.0-rc3-syzkaller-00021-ga1effab7a3a3 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
RIP: 0010:hlock_class kernel/locking/lockdep.c:232 [inline]
RIP: 0010:hlock_class kernel/locking/lockdep.c:221 [inline]
RIP: 0010:check_wait_context kernel/locking/lockdep.c:4730 [inline]
RIP: 0010:__lock_acquire+0x1615/0x5d40 kernel/locking/lockdep.c:5006
Code: 08 84 d2 0f 85 b4 3d 00 00 8b 15 32 8f 13 0d 85 d2 0f 85 31 fb ff ff 48 c7 c6 60 64 4c 8a 48 c7 c7 a0 58 4c 8a e8 db fe e6 ff <0f> 0b 31 ed e9 e9 ed ff ff e8 4d 47 a8 02 85 c0 0f 84 c1 fa ff ff
RSP: 0018:ffffc9000b05f7f0 EFLAGS: 00010086
RAX: 0000000000000000 RBX: ffffffff9200174f RCX: 0000000000000000
RDX: ffff888024a88000 RSI: ffffffff814b6037 RDI: 0000000000000001
RBP: 0000000000000d57 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 000000002d2d2d2d R12: ffff888024a88ab0
R13: ffff888024a88000 R14: 0000000000040000 R15: 0000000000040d57
FS:  0000555555f693c0(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000555555f726e8 CR3: 000000001e1e2000 CR4: 0000000000350ee0
Call Trace:
 <TASK>
 lock_acquire kernel/locking/lockdep.c:5669 [inline]
 lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634
 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
 _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
 spin_lock include/linux/spinlock.h:350 [inline]
 take_dentry_name_snapshot+0x2b/0x170 fs/dcache.c:315
 ovl_check_rename_whiteout fs/overlayfs/super.c:1207 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1329 [inline]
 ovl_get_workdir fs/overlayfs/super.c:1444 [inline]
 ovl_fill_super+0x2090/0x7270 fs/overlayfs/super.c:2000
 mount_nodev+0x64/0x120 fs/super.c:1426
 legacy_get_tree+0x109/0x220 fs/fs_context.c:610
 vfs_get_tree+0x8d/0x350 fs/super.c:1510
 do_new_mount fs/namespace.c:3042 [inline]
 path_mount+0x1342/0x1e40 fs/namespace.c:3372
 do_mount fs/namespace.c:3385 [inline]
 __do_sys_mount fs/namespace.c:3594 [inline]
 __se_sys_mount fs/namespace.c:3571 [inline]
 __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fce7122c7f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 81 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc9a700158 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fce7122c7f9
RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000020000480 R09: 0000000000000003
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc9a70018c
R13: 00007ffc9a7001e0 R14: 00007ffc9a7001a0 R15: 0000000000000295
 </TASK>

Crashes (14):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/03/22 19:56 upstream a1effab7a3a3 d846e076 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/03/15 22:27 upstream 6015b1aca1a2 18b58603 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/02/26 15:28 linux-next 8232539f864c ee50e71c .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-linux-next-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/02/25 15:20 linux-next 8232539f864c ee50e71c .config console log report syz [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-linux-next-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/03/26 08:23 upstream 4bdec23f971b fbf0499a .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/04/13 02:11 upstream 0bcc40255504 82d5e53e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/04/12 12:03 upstream e62252bc55b6 1a1596b6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/03/17 21:59 upstream 8d3c682a5e3d 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/03/01 15:28 upstream c0927a7a5391 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/04/13 21:29 upstream de4664485abb 3cfcaa1b .config console log report info ci-qemu-upstream-386 WARNING: locking bug in take_dentry_name_snapshot
2023/02/22 18:01 upstream 5b7c4cabbb65 9f1e2cb3 .config console log report info ci-qemu-upstream-386 WARNING: locking bug in take_dentry_name_snapshot
2023/03/04 01:16 linux-next 1acf39ef8f14 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/02/25 14:21 linux-next 8232539f864c ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
2023/02/08 07:07 linux-next 38d2b86a665b 15c3d445 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: locking bug in take_dentry_name_snapshot
* Struck through repros no longer work on HEAD.