WARNING in sysfs_create_file

WARNING in sysfs_create_file_ns
Status: upstream: reported C repro on 2019/08/01 15:28
Reported-by: syzbot+5b9bba68c833c84a1135@syzkaller.appspotmail.com
First crash: 199d, last: 3h12m

Sample crash report:

usbvision_audio_off: can't write reg
usb 1-1: usbvision_write_reg: failed: error -90
usb 1-1: usbvision_write_reg: failed: error -90
usb 1-1: usbvision_write_reg: failed: error -90
usb 1-1: usbvision_write_reg: failed: error -90
usb 1-1: usbvision_write_reg: failed: error -90
usbvision_i2c_register: can't write reg
videodev: could not get a free minor
usb 1-1: USBVision[128]: video_register_device() failed
------------[ cut here ]------------
WARNING: CPU: 0 PID: 95 at fs/sysfs/file.c:327 sysfs_create_file_ns+0x13c/0x1c0 fs/sysfs/file.c:327
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 95 Comm: kworker/0:2 Not tainted 5.5.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xef/0x16e lib/dump_stack.c:118
 panic+0x2aa/0x6e1 kernel/panic.c:221
 __warn.cold+0x2f/0x30 kernel/panic.c:582
 report_bug+0x27b/0x2f0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 fixup_bug arch/x86/kernel/traps.c:169 [inline]
 do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:267
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:sysfs_create_file_ns+0x13c/0x1c0 fs/sysfs/file.c:327
Code: 85 82 00 00 00 41 55 48 8b 7b 30 31 d2 48 89 ee 44 8b 4c 24 50 44 8b 44 24 40 e8 af f9 ff ff 41 89 c5 58 eb 0d e8 34 ee b0 ff <0f> 0b 41 bd ea ff ff ff e8 27 ee b0 ff 44 89 e8 48 ba 00 00 00 00
RSP: 0018:ffff8881d5427178 EFLAGS: 00010293
RAX: ffff8881d6c5c980 RBX: ffff8881c6e14390 RCX: ffffffff82753994
RDX: 0000000000000000 RSI: ffffffff818e235c RDI: ffff8881c6e14390
RBP: ffffffff879fb7a0 R08: ffff8881d6c5c980 R09: ffffed1038dc2916
R10: ffffed1038dc2915 R11: ffff8881c6e148af R12: 1ffff1103aa84e30
R13: 0000000000000000 R14: dffffc0000000000 R15: ffff8881c6e143c0
 sysfs_create_file include/linux/sysfs.h:530 [inline]
 device_create_file+0xe6/0x1d0 drivers/base/core.c:1853
 usbvision_create_sysfs drivers/media/usb/usbvision/usbvision-video.c:252 [inline]
 usbvision_probe.cold+0x1c0f/0x1f21 drivers/media/usb/usbvision/usbvision-video.c:1535
 usb_probe_interface+0x310/0x800 drivers/usb/core/driver.c:361
 really_probe+0x290/0xad0 drivers/base/dd.c:548
 driver_probe_device+0x223/0x350 drivers/base/dd.c:721
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x390 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1459/0x1bf0 drivers/base/core.c:2487
 usb_set_configuration+0xe47/0x17d0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0xaf/0x140 drivers/usb/core/driver.c:266
 really_probe+0x290/0xad0 drivers/base/dd.c:548
 driver_probe_device+0x223/0x350 drivers/base/dd.c:721
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x390 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1459/0x1bf0 drivers/base/core.c:2487
 usb_new_device.cold+0x540/0xcd0 drivers/usb/core/hub.c:2538
 hub_port_connect drivers/usb/core/hub.c:5185 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5325 [inline]
 port_event drivers/usb/core/hub.c:5471 [inline]
 hub_event+0x21cb/0x4300 drivers/usb/core/hub.c:5553
 process_one_work+0x945/0x15c0 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (16):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci2-upstream-usb	2020/01/25 08:40	https://github.com/google/kasan.git usb-fuzzer	cd234325	2e95ab33	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2020/01/23 10:06	https://github.com/google/kasan.git usb-fuzzer	4cc301ee	3334d684	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/12/19 21:55	https://github.com/google/kasan.git usb-fuzzer	ecdf2214	36650b4b	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/12/06 21:40	https://github.com/google/kasan.git usb-fuzzer	1f22d15c	85f26751	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/09/27 02:48	https://github.com/google/kasan.git usb-fuzzer	2994c077	2f1548bc	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/09/23 21:57	https://github.com/google/kasan.git usb-fuzzer	d9e63adc	c68252d2	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/09/21 17:36	https://github.com/google/kasan.git usb-fuzzer	e0bd8d79	d96e88f3	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/08/12 07:29	https://github.com/google/kasan.git usb-fuzzer	e96407b4	acb51638	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/07/28 09:43	https://github.com/google/kasan.git usb-fuzzer	6a3599ce	c85e1c5b	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/07/22 18:48	https://github.com/google/kasan.git usb-fuzzer	6a3599ce	55e0c077	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/07/10 00:47	https://github.com/google/kasan.git usb-fuzzer	7829a896	f62e1e85	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2020/01/13 17:34	https://github.com/google/kasan.git usb-fuzzer	5a67532c	99565c1a	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2020/01/10 18:36	https://github.com/google/kasan.git usb-fuzzer	ae179410	532ec44e	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2020/01/07 10:44	https://github.com/google/kasan.git usb-fuzzer	ecdf2214	1bcd407e	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/12/01 00:21	https://github.com/google/kasan.git usb-fuzzer	32b5e2b2	a76bf83f	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org
ci2-upstream-usb	2019/10/04 18:06	https://github.com/google/kasan.git usb-fuzzer	58d5f26a	c86336cf	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael@kernel.org