syzbot


possible deadlock in __ntfs_clear_inode

Status: upstream: reported on 2022/11/25 10:07
Labels: ntfs (incorrect?)
Reported-by: syzbot+5ebb8d0e9b8c47867596@syzkaller.appspotmail.com
First crash: 188d, last: 33d
Discussions (3)
Title Replies (including bot) Last reply
[syzbot] Monthly ntfs report (May 2023) 0 (1) 2023/05/02 07:18
[syzbot] Monthly ntfs report 0 (1) 2023/03/31 15:00
[syzbot] possible deadlock in __ntfs_clear_inode 0 (1) 2022/11/25 10:07
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 possible deadlock in __ntfs_clear_inode ntfs 2 153d 172d 0/1 upstream: reported on 2022/12/10 22:52

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.3.0-syzkaller-10197-g91ec4b0d11fe #0 Not tainted
------------------------------------------------------
kswapd0/83 is trying to acquire lock:
ffff888078c92200 (&rl->lock){++++}-{3:3}, at: __ntfs_clear_inode+0x32/0x1f0 fs/ntfs/inode.c:2189

but task is already holding lock:
ffffffff8d000040 (fs_reclaim){+.+.}-{0:0}, at: 0x1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (fs_reclaim){+.+.}-{0:0}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       __fs_reclaim_acquire mm/page_alloc.c:4717 [inline]
       fs_reclaim_acquire+0x87/0x130 mm/page_alloc.c:4731
       might_alloc include/linux/sched/mm.h:271 [inline]
       prepare_alloc_pages+0x147/0x5b0 mm/page_alloc.c:5363
       __alloc_pages+0x165/0x670 mm/page_alloc.c:5581
       folio_alloc+0x1e/0x60 mm/mempolicy.c:2287
       filemap_alloc_folio+0xde/0x500 mm/filemap.c:976
       do_read_cache_folio+0x2a7/0x820 mm/filemap.c:3647
       do_read_cache_page+0x32/0x230 mm/filemap.c:3749
       read_mapping_page include/linux/pagemap.h:771 [inline]
       ntfs_map_page fs/ntfs/aops.h:75 [inline]
       map_mft_record_page fs/ntfs/mft.c:73 [inline]
       map_mft_record+0x1cd/0x630 fs/ntfs/mft.c:156
       ntfs_read_locked_inode+0x199/0x49c0 fs/ntfs/inode.c:550
       ntfs_iget+0x113/0x190 fs/ntfs/inode.c:177
       ntfs_lookup+0x28e/0xe00 fs/ntfs/namei.c:117
       lookup_open fs/namei.c:3394 [inline]
       open_last_lookups fs/namei.c:3484 [inline]
       path_openat+0x11e9/0x3170 fs/namei.c:3712
       do_filp_open+0x234/0x490 fs/namei.c:3742
       do_sys_openat2+0x13f/0x500 fs/open.c:1356
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_openat fs/open.c:1388 [inline]
       __se_sys_openat fs/open.c:1383 [inline]
       __x64_sys_openat+0x247/0x290 fs/open.c:1383
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&ni->mrec_lock){+.+.}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       map_mft_record+0x4c/0x630 fs/ntfs/mft.c:154
       ntfs_attr_extend_allocation+0x539/0x4340 fs/ntfs/attrib.c:2002
       ntfs_prepare_file_for_write fs/ntfs/file.c:391 [inline]
       ntfs_file_write_iter+0x3ad/0x1a00 fs/ntfs/file.c:1915
       call_write_iter include/linux/fs.h:1854 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x7da/0xbf0 fs/read_write.c:584
       ksys_write+0x1a0/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&rl->lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3108 [inline]
       check_prevs_add kernel/locking/lockdep.c:3227 [inline]
       validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
       __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
       __ntfs_clear_inode+0x32/0x1f0 fs/ntfs/inode.c:2189
       ntfs_evict_big_inode+0x2b1/0x480 fs/ntfs/inode.c:2278
       evict+0x2a4/0x620 fs/inode.c:665
       dispose_list fs/inode.c:698 [inline]
       prune_icache_sb+0x239/0x2e0 fs/inode.c:897
       super_cache_scan+0x376/0x480 fs/super.c:106
       do_shrink_slab+0x544/0xdb0 mm/vmscan.c:853
       shrink_slab_memcg mm/vmscan.c:922 [inline]
       shrink_slab+0x578/0x8c0 mm/vmscan.c:1001
       shrink_node_memcgs mm/vmscan.c:6439 [inline]
       shrink_node+0x1143/0x2730 mm/vmscan.c:6473
       kswapd_shrink_node mm/vmscan.c:7262 [inline]
       balance_pgdat+0x12f8/0x21e0 mm/vmscan.c:7452
       kswapd+0x783/0xdc0 mm/vmscan.c:7712
       kthread+0x2b2/0x350 kernel/kthread.c:379
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

other info that might help us debug this:

Chain exists of:
  &rl->lock --> &ni->mrec_lock --> fs_reclaim

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(fs_reclaim);
                               lock(&ni->mrec_lock);
                               lock(fs_reclaim);
  lock(&rl->lock);

 *** DEADLOCK ***

3 locks held by kswapd0/83:
 #0: ffffffff8d000040 (fs_reclaim){+.+.}-{0:0}, at: 0x1
 #1: ffffffff8cfd6390 (shrinker_rwsem){++++}-{3:3}, at: shrink_slab_memcg mm/vmscan.c:895 [inline]
 #1: ffffffff8cfd6390 (shrinker_rwsem){++++}-{3:3}, at: shrink_slab+0x2dc/0x8c0 mm/vmscan.c:1001
 #2: ffff8880244de0e0 (&type->s_umount_key#59){++++}-{3:3}, at: trylock_super fs/super.c:414 [inline]
 #2: ffff8880244de0e0 (&type->s_umount_key#59){++++}-{3:3}, at: super_cache_scan+0x77/0x480 fs/super.c:79

stack backtrace:
CPU: 0 PID: 83 Comm: kswapd0 Not tainted 6.3.0-syzkaller-10197-g91ec4b0d11fe #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3108 [inline]
 check_prevs_add kernel/locking/lockdep.c:3227 [inline]
 validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
 __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
 __ntfs_clear_inode+0x32/0x1f0 fs/ntfs/inode.c:2189
 ntfs_evict_big_inode+0x2b1/0x480 fs/ntfs/inode.c:2278
 evict+0x2a4/0x620 fs/inode.c:665
 dispose_list fs/inode.c:698 [inline]
 prune_icache_sb+0x239/0x2e0 fs/inode.c:897
 super_cache_scan+0x376/0x480 fs/super.c:106
 do_shrink_slab+0x544/0xdb0 mm/vmscan.c:853
 shrink_slab_memcg mm/vmscan.c:922 [inline]
 shrink_slab+0x578/0x8c0 mm/vmscan.c:1001
 shrink_node_memcgs mm/vmscan.c:6439 [inline]
 shrink_node+0x1143/0x2730 mm/vmscan.c:6473
 kswapd_shrink_node mm/vmscan.c:7262 [inline]
 balance_pgdat+0x12f8/0x21e0 mm/vmscan.c:7452
 kswapd+0x783/0xdc0 mm/vmscan.c:7712
 kthread+0x2b2/0x350 kernel/kthread.c:379
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>

Crashes (134):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/04/28 10:08 upstream 91ec4b0d11fe 70a605de .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/26 13:35 upstream 0cfd8703e7da 8d843721 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/26 08:11 upstream 0cfd8703e7da 65320f8e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/18 22:32 upstream af67688dca57 d931e9f0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/15 23:59 upstream a7a55e27ad72 ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/14 22:34 upstream 95abc817ab3a ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/13 16:57 upstream de4664485abb 3cfcaa1b .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/13 06:50 upstream 0bcc40255504 82d5e53e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in __ntfs_clear_inode
2023/04/11 01:02 upstream 0d3eb744aed4 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/10 06:16 upstream 09a9639e56c0 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/06 17:11 upstream 99ddf2254feb 08707520 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in __ntfs_clear_inode
2023/04/06 10:18 upstream 99ddf2254feb 08707520 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/06 10:12 upstream 99ddf2254feb 08707520 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/04 21:04 upstream 76f598ba7d8e 831373d3 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/04/02 22:35 upstream 6ab608fe852b f325deb0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/02 05:14 upstream 00c7b5f4ddc5 f325deb0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/01 08:04 upstream 5a57b48fdfcb f325deb0 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/30 22:02 upstream 8bb95a1662f8 f325deb0 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/28 12:53 upstream 3a93e40326c8 47f3aaf1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/03/28 02:04 upstream 3a93e40326c8 47f3aaf1 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/27 23:09 upstream 3a93e40326c8 47f3aaf1 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/27 20:34 upstream 197b6b60ae7b f8f96aa9 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/26 21:53 upstream 0ec57cfa721f fbf0499a .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/26 11:30 upstream da8e7da11e4b fbf0499a .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/25 07:49 upstream e76db6e50c85 fbf0499a .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/24 15:34 upstream 1e760fa3596e ee89d73c .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/24 10:01 upstream 1e760fa3596e f94b4a29 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/24 04:37 upstream 9fd6ba5420ba f94b4a29 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/24 01:29 upstream 9fd6ba5420ba f94b4a29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/03/23 19:46 upstream 9fd6ba5420ba f94b4a29 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/23 09:55 upstream fff5a5e7f528 f94b4a29 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/23 01:03 upstream fff5a5e7f528 f94b4a29 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2023/03/22 09:13 upstream 2faac9a98f01 8b4eb097 .config console log report info ci-qemu-upstream possible deadlock in __ntfs_clear_inode
2022/11/24 19:57 upstream 4312098baf37 ff68ff8f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in __ntfs_clear_inode
2023/04/12 13:01 upstream e62252bc55b6 1a1596b6 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/04/10 22:50 upstream 0d3eb744aed4 71147e29 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/04/01 21:07 upstream 7b50567bdcad f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/04/01 04:07 upstream 2bac7dc169af f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/31 15:48 upstream 62bad54b26db f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/31 14:17 upstream 62bad54b26db f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/31 12:58 upstream 62bad54b26db f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/29 15:58 upstream fcd476ea6a88 f325deb0 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/28 14:49 upstream 3a93e40326c8 48c74771 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/27 11:41 upstream 197b6b60ae7b f8f96aa9 .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/27 01:07 upstream 18940c888c85 fbf0499a .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/26 08:58 upstream da8e7da11e4b fbf0499a .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/26 07:25 upstream da8e7da11e4b fbf0499a .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/25 06:48 upstream e76db6e50c85 fbf0499a .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/25 05:28 upstream e76db6e50c85 fbf0499a .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/03/24 20:12 upstream 1e760fa3596e ee89d73c .config console log report info ci-qemu-upstream-386 possible deadlock in __ntfs_clear_inode
2023/02/24 08:09 linux-next 0222aa9800b2 9e2ebb3c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in __ntfs_clear_inode
* Struck through repros no longer work on HEAD.