divide error in usbnet_update_max_qlen

Status: fixed on 2019/10/15 23:40
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+6102c120be558c885f04@syzkaller.appspotmail.com
Fix commit: 280ceaed79f1 usbnet: sanity checking of packet sizes and device mtu
First crash: 2514d, last: 2493d
▶ ▼ Discussions (15)
Title Replies (including bot) Last reply
[PATCH 5.2 000/313] 5.2.19-stable review 324 (324) 2020/06/23 22:07
[PATCH 4.19 000/211] 4.19.77-stable review 227 (227) 2019/11/12 00:25
[PATCH 5.3 000/344] 5.3.4-stable review 360 (360) 2019/11/11 06:01
[PATCH AUTOSEL 5.3 01/71] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read 74 (74) 2019/10/09 03:45
[PATCH 4.14 000/185] 4.14.147-stable review 191 (191) 2019/10/05 00:10
[PATCH 4.9 000/129] 4.9.195-stable review 135 (135) 2019/10/04 22:56
[PATCH 4.4 00/99] 4.4.195-stable review 105 (105) 2019/10/04 22:55
[PATCH AUTOSEL 4.4 01/15] ima: always return negative code for error 15 (15) 2019/10/01 16:45
[PATCH AUTOSEL 4.9 01/19] ima: always return negative code for error 19 (19) 2019/10/01 16:45
[PATCH AUTOSEL 4.14 01/29] ima: always return negative code for error 29 (29) 2019/10/01 16:44
[PATCH AUTOSEL 4.19 01/43] ima: always return negative code for error 43 (43) 2019/10/01 16:43
[PATCH AUTOSEL 5.2 01/63] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read 63 (63) 2019/10/01 16:41
Reminder: 52 active syzbot reports in usb subsystem 4 (4) 2019/09/19 19:01
[PATCH] usbnet: sanity checking of packet sizes and device mtu 2 (2) 2019/09/19 11:27
divide error in usbnet_update_max_qlen 1 (3) 2019/09/17 11:41
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/09/17 11:22 17m oneukum@suse.com patch https://github.com/google/kasan.git f0df5c1b OK

Sample crash report:
usb 1-1: SerialNumber: syz
cdc_ncm 1-1:1.0: MAC-Address: 42:42:42:42:42:42
cdc_ncm 1-1:1.0: dwNtbInMaxSize=0 is too small. Using 2048
cdc_ncm 1-1:1.0: setting rx_max = 2048
divide error: 0000 [#1] SMP KASAN
CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.3.0+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:usbnet_update_max_qlen drivers/net/usb/usbnet.c:344 [inline]
RIP: 0010:usbnet_update_max_qlen+0x231/0x370 drivers/net/usb/usbnet.c:338
Code: 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 46 01 00 00 48 8d bb f4 00 00 00 31 d2 b8 c8 63 01 00 48 89 f9 <48> f7 b3 a8 01 00 00 48 ba 00 00 00 00 00 fc ff df 48 c1 e9 03 0f
RSP: 0018:ffff8881d93cf000 EFLAGS: 00010246
RAX: 00000000000163c8 RBX: ffff8881d07b9bc0 RCX: ffff8881d07b9cb4
RDX: 0000000000000000 RSI: ffffffff8348796e RDI: ffff8881d07b9cb4
RBP: 0000000000000003 R08: ffff8881d93b9800 R09: ffffed103a0f722a
R10: ffffed103a0f7229 R11: ffff8881d07b914f R12: 0000000000000000
R13: ffff8881d07b9d38 R14: ffff8881d07b9bc0 R15: ffff8881d040ec80
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000004c7728 CR3: 00000001d466a000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 cdc_ncm_update_rxtx_max+0x8e9/0xef0 drivers/net/usb/cdc_ncm.c:440
 cdc_ncm_setup drivers/net/usb/cdc_ncm.c:667 [inline]
 cdc_ncm_bind_common+0x1005/0x2570 drivers/net/usb/cdc_ncm.c:924
 cdc_ncm_bind+0x7c/0x1c0 drivers/net/usb/cdc_ncm.c:1038
 usbnet_probe+0xb43/0x23cf drivers/net/usb/usbnet.c:1722
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0xae6/0x16f0 drivers/base/core.c:2201
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0xae6/0x16f0 drivers/base/core.c:2201
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Crashes (17):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/09/28 02:59 https://github.com/google/kasan.git usb-fuzzer 2994c07743fe d8074e0b .config console log report syz C ci2-upstream-usb
2019/09/19 19:18 https://github.com/google/kasan.git usb-fuzzer e0bd8d794fc9 eb940044 .config console log report syz C ci2-upstream-usb
2019/09/11 07:04 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/11 04:28 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/09 17:45 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/09 06:51 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/09 05:59 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/09 01:07 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/08 10:34 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/07 23:56 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/07 15:24 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report syz C ci2-upstream-usb
2019/09/29 00:31 https://github.com/google/kasan.git usb-fuzzer 2994c07743fe eb6b9855 .config console log report ci2-upstream-usb
2019/09/23 12:47 https://github.com/google/kasan.git usb-fuzzer e0bd8d794fc9 d96e88f3 .config console log report ci2-upstream-usb
2019/09/18 22:19 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 46c0be24 .config console log report ci2-upstream-usb
2019/09/13 21:22 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 32d59357 .config console log report ci2-upstream-usb
2019/09/10 12:32 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report ci2-upstream-usb
2019/09/10 05:11 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.