syzbot


WARNING: bad unlock balance in ext4_rename

Status: auto-obsoleted due to no activity on 2023/06/17 22:52
Subsystems: ext4
[Documentation on labels]
Reported-by: syzbot+636aeec054650b49a379@syzkaller.appspotmail.com
First crash: 410d, last: 394d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ext4?] WARNING: bad unlock balance in ext4_rename 1 (3) 2023/03/16 13:55

Sample crash report:
EXT4-fs error (device loop2): ext4_get_first_dir_block:3524: inode #12: comm syz-executor.2: directory missing '.'
=====================================
WARNING: bad unlock balance detected!
6.3.0-rc2-syzkaller-00405-ga3671bd86a97 #0 Not tainted
-------------------------------------
syz-executor.2/21738 is trying to release lock (&type->i_mutex_dir_key) at:
[<ffffffff822ee449>] inode_unlock include/linux/fs.h:763 [inline]
[<ffffffff822ee449>] ext4_rename+0x569/0x27c0 fs/ext4/namei.c:4029
but there are no more locks to release!

other info that might help us debug this:
2 locks held by syz-executor.2/21738:
 #0: ffff88802a79c460 (sb_writers#5){.+.+}-{0:0}, at: do_renameat2+0x37f/0xc90 fs/namei.c:4859
 #1: ffff88801acf7980 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
 #1: ffff88801acf7980 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x229/0x280 fs/namei.c:2991

stack backtrace:
CPU: 2 PID: 21738 Comm: syz-executor.2 Not tainted 6.3.0-rc2-syzkaller-00405-ga3671bd86a97 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 __lock_release kernel/locking/lockdep.c:5346 [inline]
 lock_release+0x4f1/0x670 kernel/locking/lockdep.c:5689
 up_write+0x2a/0x520 kernel/locking/rwsem.c:1625
 inode_unlock include/linux/fs.h:763 [inline]
 ext4_rename+0x569/0x27c0 fs/ext4/namei.c:4029
 ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4202
 vfs_rename+0xef6/0x17a0 fs/namei.c:4772
 do_renameat2+0xb62/0xc90 fs/namei.c:4923
 __do_sys_renameat2 fs/namei.c:4956 [inline]
 __se_sys_renameat2 fs/namei.c:4953 [inline]
 __x64_sys_renameat2+0xe8/0x120 fs/namei.c:4953
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f2ea508c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2ea5d76168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f2ea51abf80 RCX: 00007f2ea508c0f9
RDX: 0000000000000004 RSI: 0000000020000040 RDI: 0000000000000004
RBP: 00007f2ea50e7b39 R08: 0000000000000004 R09: 0000000000000000
R10: 00000000200000c0 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffec9e9786f R14: 00007f2ea5d76300 R15: 0000000000022000
 </TASK>
------------[ cut here ]------------
DEBUG_RWSEMS_WARN_ON((rwsem_owner(sem) != current) && !rwsem_test_oflags(sem, RWSEM_NONSPINNABLE)): count = 0x0, magic = 0xffff8880269c7690, owner = 0x0, curr 0xffff888050ed60c0, list empty
WARNING: CPU: 2 PID: 21738 at kernel/locking/rwsem.c:1369 __up_write kernel/locking/rwsem.c:1369 [inline]
WARNING: CPU: 2 PID: 21738 at kernel/locking/rwsem.c:1369 up_write+0x425/0x520 kernel/locking/rwsem.c:1626
Modules linked in:
CPU: 2 PID: 21738 Comm: syz-executor.2 Not tainted 6.3.0-rc2-syzkaller-00405-ga3671bd86a97 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
RIP: 0010:__up_write kernel/locking/rwsem.c:1369 [inline]
RIP: 0010:up_write+0x425/0x520 kernel/locking/rwsem.c:1626
Code: 3c 02 00 0f 85 da 00 00 00 48 8b 55 00 4d 89 f1 53 4d 89 f8 4c 89 e9 48 c7 c6 80 43 4c 8a 48 c7 c7 20 42 4c 8a e8 9b 1b e8 ff <0f> 0b 59 e9 dd fc ff ff 48 89 df e8 fb be 6f 00 e9 1a fc ff ff 48
RSP: 0018:ffffc9000facf9a0 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffffff8a4c4160 RCX: ffffc90008001000
RDX: 0000000000040000 RSI: ffffffff814a8087 RDI: 0000000000000001
RBP: ffff8880269c7690 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 57525f4755424544 R12: ffff8880269c7698
R13: ffff8880269c7690 R14: ffff888050ed60c0 R15: 0000000000000000
FS:  00007f2ea5d76700(0000) GS:ffff88802cb00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fa3756e6380 CR3: 0000000051916000 CR4: 0000000000152ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 inode_unlock include/linux/fs.h:763 [inline]
 ext4_rename+0x569/0x27c0 fs/ext4/namei.c:4029
 ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4202
 vfs_rename+0xef6/0x17a0 fs/namei.c:4772
 do_renameat2+0xb62/0xc90 fs/namei.c:4923
 __do_sys_renameat2 fs/namei.c:4956 [inline]
 __se_sys_renameat2 fs/namei.c:4953 [inline]
 __x64_sys_renameat2+0xe8/0x120 fs/namei.c:4953
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f2ea508c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2ea5d76168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f2ea51abf80 RCX: 00007f2ea508c0f9
RDX: 0000000000000004 RSI: 0000000020000040 RDI: 0000000000000004
RBP: 00007f2ea50e7b39 R08: 0000000000000004 R09: 0000000000000000
R10: 00000000200000c0 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffec9e9786f R14: 00007f2ea5d76300 R15: 0000000000022000
 </TASK>

Crashes (19):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/03/19 22:52 upstream a3671bd86a97 7939252e .config console log report info ci-qemu-upstream WARNING: bad unlock balance in ext4_rename
2023/03/19 15:36 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/19 15:18 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/19 15:17 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root WARNING: bad unlock balance in ext4_rename
2023/03/19 06:57 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root WARNING: bad unlock balance in ext4_rename
2023/03/19 06:43 upstream a3671bd86a97 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/19 03:54 upstream 534293368afa 7939252e .config console log report info ci-qemu-upstream WARNING: bad unlock balance in ext4_rename
2023/03/19 03:54 upstream 534293368afa 7939252e .config console log report info ci-qemu-upstream WARNING: bad unlock balance in ext4_rename
2023/03/16 10:51 upstream 9c1bec9c0b08 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/12 21:18 upstream 134231664868 5205ef30 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/04 18:25 upstream 0988a0ea7919 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/19 18:53 upstream a3671bd86a97 7939252e .config console log report info ci-qemu-upstream-386 WARNING: bad unlock balance in ext4_rename
2023/03/19 18:52 upstream a3671bd86a97 7939252e .config console log report info ci-qemu-upstream-386 WARNING: bad unlock balance in ext4_rename
2023/03/19 18:47 upstream a3671bd86a97 7939252e .config console log report info ci-qemu-upstream-386 WARNING: bad unlock balance in ext4_rename
2023/03/19 03:45 upstream 534293368afa 7939252e .config console log report info ci-qemu-upstream-386 WARNING: bad unlock balance in ext4_rename
2023/03/19 15:39 linux-next 6f08c1de13a9 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/19 15:14 linux-next 6f08c1de13a9 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/16 05:35 linux-next 6f72958a49f6 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: bad unlock balance in ext4_rename
2023/03/04 13:49 linux-next 1acf39ef8f14 f8902b57 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root WARNING: bad unlock balance in ext4_rename
* Struck through repros no longer work on HEAD.