syzbot


general protection fault in ip_set_comment_free

Status: fixed on 2020/04/15 17:19
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+6a86565c74ebe30aea18@syzkaller.appspotmail.com
Fix commit: 8af1c6fbd923 netfilter: ipset: Fix forceadd evaluation path
First crash: 1601d, last: 1563d
Cause bisection: introduced by (bisect log) :
commit 23c42a403a9cfdbad6004a556c927be7dd61a8ee
Author: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Date: Sat Oct 27 13:07:40 2018 +0000

  netfilter: ipset: Introduction of new commands and protocol version 7

Crash: general protection fault in ip_set_comment_free (log)
Repro: C syz .config
  
Discussions (7)
Title Replies (including bot) Last reply
[PATCH AUTOSEL 5.4 01/58] ACPI: watchdog: Allow disabling WDAT at boot 43 (43) 2020/08/30 02:23
[PATCH AUTOSEL 5.5 01/67] ACPI: watchdog: Allow disabling WDAT at boot 45 (45) 2020/03/05 17:12
[PATCH 5.5 000/176] 5.5.8-stable review 201 (201) 2020/03/04 22:14
[PATCH 5.4 000/152] 5.4.24-stable review 160 (160) 2020/03/04 16:52
[PATCH 0/6] Netfilter fixes for net 8 (8) 2020/02/27 00:32
[PATCH 0/2] ipset patches for nf 4 (4) 2020/02/26 13:02
general protection fault in ip_set_comment_free 0 (1) 2020/01/26 18:57
Last patch testing requests (4)
Created Duration User Patch Repo Result
2020/02/21 19:38 18m kadlec@netfilter.org git://blackhole.kfki.hu/nf master OK
2020/02/18 22:23 12m kadlec@netfilter.org git://blackhole.kfki.hu/nf master report log
2020/02/18 18:56 12m kadlec@netfilter.org git://blackhole.kfki.hu/nf master report log
2020/01/26 23:15 9m kadlec@blackhole.kfki.hu git://blackhole.kfki.hu/nf master report log

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000062: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000310-0x0000000000000317]
CPU: 1 PID: 11257 Comm: syz-executor518 Not tainted 5.5.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:strlen+0x1f/0xa0 lib/string.c:527
Code: 00 66 2e 0f 1f 84 00 00 00 00 00 48 b8 00 00 00 00 00 fc ff df 55 48 89 fa 48 89 e5 48 c1 ea 03 41 54 49 89 fc 53 48 83 ec 08 <0f> b6 04 02 48 89 fa 83 e2 07 38 d0 7f 04 84 c0 75 4d 41 80 3c 24
RSP: 0018:ffffc90001de6e90 EFLAGS: 00010286
RAX: dffffc0000000000 RBX: ffff888095b8c618 RCX: 1ffffffff150631e
RDX: 0000000000000062 RSI: ffffffff867a3c51 RDI: 0000000000000314
RBP: ffffc90001de6ea8 R08: ffff8880a85f41c0 R09: ffffed1012b718c3
R10: ffffed1012b718c2 R11: ffff888095b8c617 R12: 0000000000000314
R13: 0000000000000304 R14: ffff8880a87d1900 R15: ffff888095b8c600
FS:  0000000001f79880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffff600400 CR3: 00000000a3026000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 strlen include/linux/string.h:302 [inline]
 ip_set_comment_free+0x69/0xe0 net/netfilter/ipset/ip_set_core.c:402
 ip_set_ext_destroy include/linux/netfilter/ipset/ip_set.h:275 [inline]
 ip_set_ext_destroy include/linux/netfilter/ipset/ip_set.h:267 [inline]
 hash_net4_add+0x1b9a/0x2200 net/netfilter/ipset/ip_set_hash_gen.h:766
 hash_net4_uadt+0x596/0x940 net/netfilter/ipset/ip_set_hash_net.c:195
 call_ad+0x1a0/0x5a0 net/netfilter/ipset/ip_set_core.c:1716
 ip_set_ad.isra.0+0x572/0xb20 net/netfilter/ipset/ip_set_core.c:1804
 ip_set_uadd+0x37/0x50 net/netfilter/ipset/ip_set_core.c:1829
 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x59e/0x7e0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:672
 ____sys_sendmsg+0x753/0x880 net/socket.c:2343
 ___sys_sendmsg+0x100/0x170 net/socket.c:2397
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2430
 __do_sys_sendmsg net/socket.c:2439 [inline]
 __se_sys_sendmsg net/socket.c:2437 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2437
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4405c9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff0b87e918 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004405c9
RDX: 0000000000000000 RSI: 0000000020000d00 RDI: 0000000000000004
RBP: 00000000006ca018 R08: 0000000000000008 R09: 00000000004002c8
R10: 000000000000000c R11: 0000000000000246 R12: 0000000000401e50
R13: 0000000000401ee0 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace a3429c59ab3c6dbc ]---
RIP: 0010:strlen+0x1f/0xa0 lib/string.c:527
Code: 00 66 2e 0f 1f 84 00 00 00 00 00 48 b8 00 00 00 00 00 fc ff df 55 48 89 fa 48 89 e5 48 c1 ea 03 41 54 49 89 fc 53 48 83 ec 08 <0f> b6 04 02 48 89 fa 83 e2 07 38 d0 7f 04 84 c0 75 4d 41 80 3c 24
RSP: 0018:ffffc90001de6e90 EFLAGS: 00010286
RAX: dffffc0000000000 RBX: ffff888095b8c618 RCX: 1ffffffff150631e
RDX: 0000000000000062 RSI: ffffffff867a3c51 RDI: 0000000000000314
RBP: ffffc90001de6ea8 R08: ffff8880a85f41c0 R09: ffffed1012b718c3
R10: ffffed1012b718c2 R11: ffff888095b8c617 R12: 0000000000000314
R13: 0000000000000304 R14: ffff8880a87d1900 R15: ffff888095b8c600
FS:  0000000001f79880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffff600400 CR3: 00000000a3026000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (19):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/29 22:34 upstream b3a608222336 5ed23f9a .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/29 03:51 upstream c677124e631d c8e81ce4 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/28 01:35 upstream d5226fa6dbae 56cd6c9b .config console log report syz C ci-upstream-kasan-gce-root
2020/01/28 01:05 upstream a5b871c91d47 56cd6c9b .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/27 01:45 upstream a45ea48e2bcd dd56146d .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/01/26 03:03 upstream 2821e26f3a0a f4e7270e .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/01/25 18:26 upstream d5d359b0ac3f 2e95ab33 .config console log report syz C ci-upstream-kasan-gce
2020/01/25 18:44 upstream d5d359b0ac3f 2e95ab33 .config console log report syz C ci-upstream-kasan-gce-386
2020/01/27 00:10 net-old 2821e26f3a0a dd56146d .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/25 18:50 net-old 61b1f2aff411 2e95ab33 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/26 22:14 net-next-old 14a1d2468ab3 dd56146d .config console log report syz C ci-upstream-net-kasan-gce
2020/01/25 17:36 net-next-old 08a45c59f16e 2e95ab33 .config console log report syz C ci-upstream-net-kasan-gce
2020/02/14 13:40 linux-next 9f01828e9e16 5d7b90f1 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/02/13 01:55 linux-next 129759899765 84f4fc8a .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/01/26 22:37 upstream a45ea48e2bcd dd56146d .config console log report syz ci-upstream-kasan-gce
2020/01/27 02:56 upstream a45ea48e2bcd dd56146d .config console log report syz ci-upstream-kasan-gce-386
2020/03/03 12:00 upstream 63623fd44972 c88c7b75 .config console log report ci-upstream-kasan-gce
2020/03/03 05:57 upstream 63623fd44972 c88c7b75 .config console log report ci-upstream-kasan-gce-selinux-root
2020/03/03 11:57 net-old 3614d05b5e6b c88c7b75 .config console log report ci-upstream-net-this-kasan-gce
* Struck through repros no longer work on HEAD.