syzbot


possible deadlock in reiserfs_ioctl

Status: upstream: reported C repro on 2022/11/11 18:26
Labels: reiserfs (incorrect?)
Reported-by: syzbot+79c303ad05f4041e0dad@syzkaller.appspotmail.com
First crash: 202d, last: 6h08m

Cause bisection: failed (error log, bisect log)
Discussions (4)
Title Replies (including bot) Last reply
[syzbot] Monthly reiserfs report (May 2023) 0 (1) 2023/05/29 08:47
[syzbot] Monthly reiserfs report (Apr 2023) 0 (1) 2023/04/27 10:49
[syzbot] Monthly reiserfs report 0 (1) 2023/03/27 11:03
[syzbot] possible deadlock in reiserfs_ioctl 0 (1) 2022/11/11 18:26

Sample crash report:
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-05251-g5b7c4cabbb65 #0 Not tainted
------------------------------------------------------
syz-executor105/5081 is trying to acquire lock:
ffff88801fcae460 (sb_writers#9){.+.+}-{0:0}, at: reiserfs_ioctl+0x1a2/0x330 fs/reiserfs/ioctl.c:103

but task is already holding lock:
ffff888020672090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&sbi->lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27
       reiserfs_lookup+0x175/0x490 fs/reiserfs/namei.c:364
       __lookup_slow+0x24c/0x460 fs/namei.c:1686
       lookup_one_len+0x16e/0x1a0 fs/namei.c:2712
       reiserfs_lookup_privroot+0x96/0x290 fs/reiserfs/xattr.c:973
       reiserfs_fill_super+0x20e5/0x2ea0 fs/reiserfs/super.c:2174
       mount_bdev+0x351/0x410 fs/super.c:1371
       legacy_get_tree+0x109/0x220 fs/fs_context.c:610
       vfs_get_tree+0x8d/0x350 fs/super.c:1501
       do_new_mount fs/namespace.c:3031 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3361
       do_mount fs/namespace.c:3374 [inline]
       __do_sys_mount fs/namespace.c:3583 [inline]
       __se_sys_mount fs/namespace.c:3560 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3560
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&type->i_mutex_dir_key#6){+.+.}-{3:3}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:756 [inline]
       open_last_lookups fs/namei.c:3481 [inline]
       path_openat+0x90f/0x2750 fs/namei.c:3712
       do_filp_open+0x1ba/0x410 fs/namei.c:3742
       do_sys_openat2+0x16d/0x4c0 fs/open.c:1312
       do_sys_open fs/open.c:1328 [inline]
       __do_sys_creat fs/open.c:1404 [inline]
       __se_sys_creat fs/open.c:1398 [inline]
       __x64_sys_creat+0xcd/0x120 fs/open.c:1398
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (sb_writers#9){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
       lock_acquire kernel/locking/lockdep.c:5669 [inline]
       lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1475 [inline]
       sb_start_write include/linux/fs.h:1550 [inline]
       mnt_want_write_file+0x92/0x5d0 fs/namespace.c:438
       reiserfs_ioctl+0x1a2/0x330 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  sb_writers#9 --> &type->i_mutex_dir_key#6 --> &sbi->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->lock);
                               lock(&type->i_mutex_dir_key#6);
                               lock(&sbi->lock);
  lock(sb_writers#9);

 *** DEADLOCK ***

1 lock held by syz-executor105/5081:
 #0: ffff888020672090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27

stack backtrace:
CPU: 1 PID: 5081 Comm: syz-executor105 Not tainted 6.2.0-syzkaller-05251-g5b7c4cabbb65 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
 lock_acquire kernel/locking/lockdep.c:5669 [inline]
 lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1475 [inline]
 sb_start_write include/linux/fs.h:1550 [inline]
 mnt_want_write_file+0x92/0x5d0 fs/namespace.c:438
 reiserfs_ioctl+0x1a2/0x330 fs/reiserfs/ioctl.c:103
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fbb6c3e41f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe0f703218 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007fbb6c3e41f9
RDX: 0000000000000000 RSI: 0000000040087602 RDI: 0000000000000004
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000001
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffe0f703240
R13: 0000000000000000 R14: 431bde82d7b634db R15: 0000000000000000
 </TASK>

Crashes (244):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/02/22 21:47 upstream 5b7c4cabbb65 409945bc .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2022/12/11 05:53 upstream 296a7b7eb792 67be1ae7 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/03/23 10:09 linux-next 0aa250ce67a2 f94b4a29 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2022/11/10 13:06 linux-next 0cdb3579f1ee b2488a87 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/31 20:19 upstream 48b1320a674e e2a77acd .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/25 07:30 upstream 933174ae28ba 4bce1a3e .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/15 05:08 upstream f1fcbaa18b28 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/14 04:06 upstream d4d58949a6ea 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in reiserfs_ioctl
2023/05/11 00:37 upstream 16a8829130ca 0fbd49f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/06 01:42 upstream 418d5c98319f 90c93c40 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/05 23:59 upstream 418d5c98319f 90c93c40 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/05 14:56 upstream 3c4aa4434377 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/05 03:46 upstream 3c4aa4434377 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/04 16:45 upstream 1a5304fecee5 3a560463 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/04 13:38 upstream 1a5304fecee5 3a560463 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/04 06:46 upstream fa31fc82fb77 5b7ff9dd .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/03 22:23 upstream 89b7fd5d7f3c b5918830 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/03 11:54 upstream 348551ddaf31 48e0a81d .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/05/03 10:26 upstream 348551ddaf31 48e0a81d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/28 15:28 upstream 33afd4b76393 70a605de .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/28 08:57 upstream 33afd4b76393 70a605de .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/28 03:01 upstream 32f7ad0fbe75 cc2b6c8b .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/26 08:09 upstream 4173cf6fb6b7 7560799c .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/25 18:53 upstream 173ea743bf7a 65320f8e .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/22 12:33 upstream 8e41e0a57566 2b32bd34 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/22 09:49 upstream 8e41e0a57566 2b32bd34 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/19 04:06 upstream af67688dca57 d931e9f0 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/18 05:19 upstream 6a8f57ae2eb0 436577a9 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/18 02:32 upstream 6a8f57ae2eb0 436577a9 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/16 00:52 upstream 7a934f4bd7d6 ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in reiserfs_ioctl
2023/04/15 07:01 upstream 95abc817ab3a ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/15 02:24 upstream 95abc817ab3a ec410564 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_ioctl
2023/04/15 00:31 upstream 95abc817ab3a ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/10 13:34 upstream 09a9639e56c0 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in reiserfs_ioctl
2023/04/24 03:26 upstream 457391b03803 2b32bd34 .config console log report info ci-qemu-upstream-386 possible deadlock in reiserfs_ioctl
2023/04/21 16:27 upstream 2af3e53a4dc0 2b32bd34 .config console log report info ci-qemu-upstream-386 possible deadlock in reiserfs_ioctl
2023/04/12 16:31 upstream e62252bc55b6 1a1596b6 .config console log report info ci-qemu-upstream-386 possible deadlock in reiserfs_ioctl
2023/04/11 08:54 upstream 0d3eb744aed4 71147e29 .config console log report info ci-qemu-upstream-386 possible deadlock in reiserfs_ioctl
2023/05/30 07:01 linux-next 715abedee4cd cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/29 05:34 linux-next 715abedee4cd cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/26 00:02 linux-next 715abedee4cd 0513b3e6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/24 00:55 linux-next 715abedee4cd 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/18 12:31 linux-next 715abedee4cd 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/17 21:01 linux-next 715abedee4cd eaac4681 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/14 10:41 linux-next e922ba281a8d 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/08 00:06 linux-next 83e5775d7afd 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/05 01:54 linux-next 145e5cddfe8b 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/03 16:41 linux-next 92e815cf07ed b5918830 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/03 08:55 linux-next 92e815cf07ed 48e0a81d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/05/01 20:02 linux-next 92e815cf07ed 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/22 07:36 linux-next d3e1ee0e67e7 2b32bd34 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
2023/04/11 02:22 linux-next e134c93f788f 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_ioctl
* Struck through repros no longer work on HEAD.