syzbot


possible deadlock in open_rio

Status: fixed on 2019/09/07 04:24
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+7bbcbe9c9ff0cd49592a@syzkaller.appspotmail.com
Fix commit: 2ca359f4f8b9 Revert "USB: rio500: simplify locking"
First crash: 1720d, last: 1683d
Duplicate bugs (1)
duplicates (1):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
possible deadlock in open_rio (2) usb C 759 1673d 1673d 0/26 closed as dup on 2019/09/16 16:40
Discussions (6)
Title Replies (including bot) Last reply
[PATCH] USB: rio500: Fix lockdep violation 7 (7) 2019/09/03 18:18
[PATCH 5.2 000/144] 5.2.9-stable review 153 (153) 2019/08/16 07:15
Re: possible deadlock in iowarrior 1 (1) 2019/08/08 17:43
Re: possible deadlock in open_rio 2 (4) 2019/08/08 14:44
[PATCH] Revert "USB: rio500: simplify locking" 1 (1) 2019/08/08 09:28
possible deadlock in open_rio 11 (12) 2019/08/07 15:08
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in open_rio (3) usb C 169 1670d 1672d 13/26 fixed on 2019/10/15 23:40
upstream possible deadlock in open_rio (2) usb C 759 1673d 1673d 0/26 closed as dup on 2019/09/16 16:40

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.3.0-rc7+ #0 Not tainted
------------------------------------------------------
syz-executor.3/7363 is trying to acquire lock:
00000000e70acc31 (rio500_mutex){+.+.}, at: open_rio+0x16/0xe0 drivers/usb/misc/rio500.c:65

but task is already holding lock:
00000000d2be898f (minor_rwsem){++++}, at: usb_open+0x23/0x270 drivers/usb/core/file.c:39

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (minor_rwsem){++++}:
       down_write+0x92/0x150 kernel/locking/rwsem.c:1500
       usb_register_dev drivers/usb/core/file.c:187 [inline]
       usb_register_dev+0x131/0x670 drivers/usb/core/file.c:156
       probe_rio.cold+0x53/0x237 drivers/usb/misc/rio500.c:474
       usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
       really_probe+0x281/0x6d0 drivers/base/dd.c:548
       driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
       __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
       bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
       __device_attach+0x217/0x360 drivers/base/dd.c:894
       bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
       device_add+0xae6/0x16f0 drivers/base/core.c:2165
       usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
       generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
       usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
       really_probe+0x281/0x6d0 drivers/base/dd.c:548
       driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
       __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
       bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
       __device_attach+0x217/0x360 drivers/base/dd.c:894
       bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
       device_add+0xae6/0x16f0 drivers/base/core.c:2165
       usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
       hub_port_connect drivers/usb/core/hub.c:5098 [inline]
       hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
       port_event drivers/usb/core/hub.c:5359 [inline]
       hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
       process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
       worker_thread+0x96/0xe20 kernel/workqueue.c:2415
       kthread+0x318/0x420 kernel/kthread.c:255
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

-> #0 (rio500_mutex){+.+.}:
       check_prev_add kernel/locking/lockdep.c:2405 [inline]
       check_prevs_add kernel/locking/lockdep.c:2507 [inline]
       validate_chain kernel/locking/lockdep.c:2897 [inline]
       __lock_acquire+0x1f7c/0x3b50 kernel/locking/lockdep.c:3880
       lock_acquire+0x127/0x320 kernel/locking/lockdep.c:4412
       __mutex_lock_common kernel/locking/mutex.c:930 [inline]
       __mutex_lock+0x158/0x1360 kernel/locking/mutex.c:1077
       open_rio+0x16/0xe0 drivers/usb/misc/rio500.c:65
       usb_open+0x1df/0x270 drivers/usb/core/file.c:48
       chrdev_open+0x219/0x5c0 fs/char_dev.c:414
       do_dentry_open+0x494/0x1120 fs/open.c:797
       do_last fs/namei.c:3416 [inline]
       path_openat+0x1430/0x3f50 fs/namei.c:3533
       do_filp_open+0x1a1/0x280 fs/namei.c:3563
       do_sys_open+0x3c0/0x580 fs/open.c:1089
       do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(minor_rwsem);
                               lock(rio500_mutex);
                               lock(minor_rwsem);
  lock(rio500_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor.3/7363:
 #0: 00000000d2be898f (minor_rwsem){++++}, at: usb_open+0x23/0x270 drivers/usb/core/file.c:39

stack backtrace:
CPU: 1 PID: 7363 Comm: syz-executor.3 Not tainted 5.3.0-rc7+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 check_noncircular+0x345/0x3e0 kernel/locking/lockdep.c:1741
 check_prev_add kernel/locking/lockdep.c:2405 [inline]
 check_prevs_add kernel/locking/lockdep.c:2507 [inline]
 validate_chain kernel/locking/lockdep.c:2897 [inline]
 __lock_acquire+0x1f7c/0x3b50 kernel/locking/lockdep.c:3880
 lock_acquire+0x127/0x320 kernel/locking/lockdep.c:4412
 __mutex_lock_common kernel/locking/mutex.c:930 [inline]
 __mutex_lock+0x158/0x1360 kernel/locking/mutex.c:1077
 open_rio+0x16/0xe0 drivers/usb/misc/rio500.c:65
 usb_open+0x1df/0x270 drivers/usb/core/file.c:48
 chrdev_open+0x219/0x5c0 fs/char_dev.c:414
 do_dentry_open+0x494/0x1120 fs/open.c:797
 do_last fs/namei.c:3416 [inline]
 path_openat+0x1430/0x3f50 fs/namei.c:3533
 do_filp_open+0x1a1/0x280 fs/namei.c:3563
 do_sys_open+0x3c0/0x580 fs/open.c:1089
 do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4137d1
Code: 75 14 b8 02 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 19 00 00 c3 48 83 ec 08 e8 0a fa ff ff 48 89 04 24 b8 02 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fa ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007f36d6c517a0 EFLAGS: 00000293 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004137d1
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 00007f36d6c517d0
RBP: 000000000075bf20 R08: 0000000000000000 R09: 000000000000000f
R10: 0000000000000064 R11: 0000000000000293 R12: 00007f36d6c526d4
R13: 00000000004c8c08 R14: 00000000004dfbb8 R15: 00000000ffffffff
usb 2-1: Rio opened.

Crashes (1107):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/09/07 04:00 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 a60cb4cd .config console log report ci2-upstream-usb
2019/09/07 02:19 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/07 00:49 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 19:52 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 18:54 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 17:49 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 16:35 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 15:01 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 acb5b744 .config console log report ci2-upstream-usb
2019/09/06 13:21 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 12:18 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 12:02 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 11:01 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 09:43 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 08:22 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 06:31 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 05:18 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 05:04 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 03:30 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 c16be727 .config console log report ci2-upstream-usb
2019/09/06 02:12 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 bf6bcce4 .config console log report ci2-upstream-usb
2019/09/06 00:51 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 bf6bcce4 .config console log report ci2-upstream-usb
2019/09/05 23:26 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 bf6bcce4 .config console log report ci2-upstream-usb
2019/09/05 22:17 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 bf6bcce4 .config console log report ci2-upstream-usb
2019/09/05 21:44 https://github.com/google/kasan.git usb-fuzzer f0df5c1be1e9 bf6bcce4 .config console log report ci2-upstream-usb
2019/09/03 11:19 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 10:09 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 08:58 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 06:34 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 05:27 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 04:26 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 03:35 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 02:32 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 01:31 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/03 00:28 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 22:59 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 21:31 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 20:59 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 19:50 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 18:40 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 17:11 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 14544a56 .config console log report ci2-upstream-usb
2019/09/02 15:52 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report ci2-upstream-usb
2019/09/02 14:23 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report ci2-upstream-usb
2019/09/02 13:07 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report ci2-upstream-usb
2019/09/02 11:35 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report ci2-upstream-usb
2019/09/02 11:06 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report ci2-upstream-usb
2019/07/31 15:30 https://github.com/google/kasan.git usb-fuzzer 7f7867ff95bf 995b2a26 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.