general protection fault in sctp_assoc_rwnd_increase

Status: fixed on 2019/04/10 16:37
Subsystems: sctp
[Documentation on labels]
Reported-by: syzbot+85e0b422ff140b03672a@syzkaller.appspotmail.com
Fix commit: 636d25d557d1 sctp: not copy sctp_sock pd_lobby in sctp_copy_descendant
First crash: 2692d, last: 2676d
Cause bisection: introduced by (bisect log) :
commit 89664c623617b1d34447a927ac7871ddf3db29d3
Author: Xin Long <lucien.xin@gmail.com>
Date: Sun Mar 3 09:54:53 2019 +0000

  sctp: sctp_sock_migrate() returns error if sctp_bind_addr_dup() fails

Crash: general protection fault in corrupted (log)
Repro: C syz .config
  
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH net] sctp: not copy sctp_sock pd_lobby in sctp_copy_descendant 3 (3) 2019/03/19 11:13
general protection fault in sctp_assoc_rwnd_increase 4 (6) 2019/03/18 06:25

Sample crash report:
Code: e8 6c b4 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b 09 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f8d38cc8d88 EFLAGS: 00000246 ORIG_RAX: 0000000000000037
RAX: ffffffffffffffda RBX: 00000000006dbc38 RCX: 00000000004466f9
RDX: 000000000000007a RSI: 0000000000000084 RDI: 0000000000000003
RBP: 00000000006dbc30 R08: 00000000200001c0 R09: 0000000000000039
R10: 0000000020000080 R11: 0000000000000246 R12: 00000000006dbc3c
R13: 00007f8d38cc8d90 R14: 0000000000000004 R15: 20c49ba5e353f7cf
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 7594 Comm: syz-executor093 Not tainted 5.0.0+ #18
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:sctp_assoc_rwnd_increase+0x34/0x520 net/sctp/associola.c:1498
Code: 41 54 49 89 fc 53 89 f3 48 83 ec 10 e8 95 90 f1 fa 49 8d bc 24 60 06 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 2f 04 00 00 45 8b ac 24 60 06
RSP: 0018:ffff8880862776f8 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000001
RDX: 00000000000000cb RSI: ffffffff867ecd5b RDI: 000000000000065f
RBP: ffff888086277730 R08: ffff8880a5b5a0c0 R09: ffff8880a5b5a988
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffffffffff
R13: 0000000000000000 R14: ffff8880a5590f40 R15: 0000000000000000
FS:  00007f8d38cc9700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000002095dff8 CR3: 00000000a6789000 CR4: 00000000001406f0
Call Trace:
 sctp_ulpevent_release_data net/sctp/ulpevent.c:1092 [inline]
 sctp_ulpevent_free+0x21f/0x4e0 net/sctp/ulpevent.c:1129
 sctp_queue_purge_ulpevents+0xc4/0x110 net/sctp/ulpevent.c:1146
 sctp_close+0x148/0x860 net/sctp/socket.c:1515
 inet_release+0x105/0x1f0 net/ipv4/af_inet.c:428
 inet6_release+0x53/0x80 net/ipv6/af_inet6.c:473
 __sock_release+0x1fe/0x2b0 net/socket.c:579
 sock_release+0x18/0x20 net/socket.c:599
 sctp_do_peeloff+0x38a/0x470 net/sctp/socket.c:5649
 sctp_getsockopt_peeloff_common.isra.0+0x8e/0x270 net/sctp/socket.c:5665
 sctp_getsockopt_peeloff_flags net/sctp/socket.c:5741 [inline]
 sctp_getsockopt net/sctp/socket.c:7805 [inline]
 sctp_getsockopt+0x3903/0x6741 net/sctp/socket.c:7758
 sock_common_getsockopt+0x9a/0xe0 net/core/sock.c:3079
 __sys_getsockopt+0x168/0x250 net/socket.c:1960
 __do_sys_getsockopt net/socket.c:1971 [inline]
 __se_sys_getsockopt net/socket.c:1968 [inline]
 __x64_sys_getsockopt+0xbe/0x150 net/socket.c:1968
 do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4466f9
Code: e8 6c b4 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b 09 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f8d38cc8d88 EFLAGS: 00000246 ORIG_RAX: 0000000000000037
RAX: ffffffffffffffda RBX: 00000000006dbc38 RCX: 00000000004466f9
RDX: 000000000000007a RSI: 0000000000000084 RDI: 0000000000000003
RBP: 00000000006dbc30 R08: 00000000200001c0 R09: 0000000000000039
R10: 0000000020000080 R11: 0000000000000246 R12: 00000000006dbc3c
R13: 00007f8d38cc8d90 R14: 0000000000000004 R15: 20c49ba5e353f7cf
Modules linked in:
---[ end trace 6fc4709b615a9056 ]---
RIP: 0010:sctp_assoc_rwnd_increase+0x34/0x520 net/sctp/associola.c:1498
Code: 41 54 49 89 fc 53 89 f3 48 83 ec 10 e8 95 90 f1 fa 49 8d bc 24 60 06 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 2f 04 00 00 45 8b ac 24 60 06
RSP: 0018:ffff8880862776f8 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000001
RDX: 00000000000000cb RSI: ffffffff867ecd5b RDI: 000000000000065f
RBP: ffff888086277730 R08: ffff8880a5b5a0c0 R09: ffff8880a5b5a988
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffffffffff
R13: 0000000000000000 R14: ffff8880a5590f40 R15: 0000000000000000
FS:  00007f8d38cc9700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000002095dff8 CR3: 00000000a6789000 CR4: 00000000001406f0

Crashes (28):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/03/12 07:37 upstream a089e4fed5c5 12365b99 .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/03/12 07:19 upstream a089e4fed5c5 12365b99 .config console log report syz C ci-upstream-kasan-gce
2019/03/27 18:59 upstream 14c741de9386 4e668495 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/27 17:34 upstream 14c741de9386 4e668495 .config console log report ci-upstream-kasan-gce
2019/03/26 10:15 upstream a3ac7917b730 55684ce1 .config console log report ci-upstream-kasan-gce
2019/03/25 14:09 upstream 8c2ffd917477 2c86e0a5 .config console log report ci-upstream-kasan-gce
2019/03/25 09:22 upstream 8c2ffd917477 2c86e0a5 .config console log report ci-upstream-kasan-gce
2019/03/25 08:49 upstream 8c2ffd917477 2c86e0a5 .config console log report ci-upstream-kasan-gce
2019/03/24 21:02 upstream 1bdd3dbfff7a acbc5b7d .config console log report ci-upstream-kasan-gce-smack-root
2019/03/23 21:48 upstream a5ed1e96cafd a2cef203 .config console log report ci-upstream-kasan-gce-root
2019/03/22 03:12 upstream 0939221e6468 dce6e62f .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/19 10:15 upstream 9e98c678c2d6 46264c32 .config console log report ci-upstream-kasan-gce
2019/03/18 18:17 upstream 9e98c678c2d6 4656beca .config console log report ci-upstream-kasan-gce
2019/03/17 08:09 upstream a9dce6679d73 bab43553 .config console log report ci-upstream-kasan-gce-root
2019/03/17 07:07 upstream a9dce6679d73 bab43553 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/16 13:48 upstream 9c7dc824d9a4 bab43553 .config console log report ci-upstream-kasan-gce
2019/03/14 00:15 upstream ebc551f2b8f9 2881fc25 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/14 00:13 upstream ebc551f2b8f9 2881fc25 .config console log report ci-upstream-kasan-gce
2019/03/12 21:31 upstream ea295481b6e3 a71bfb62 .config console log report ci-upstream-kasan-gce
2019/03/12 07:01 upstream a089e4fed5c5 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/12 06:58 upstream a089e4fed5c5 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/12 06:26 upstream a089e4fed5c5 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/26 13:29 upstream a3ac7917b730 55684ce1 .config console log report ci-upstream-kasan-gce-386
2019/03/19 11:23 upstream 9e98c678c2d6 46264c32 .config console log report ci-upstream-kasan-gce-386
2019/03/17 07:50 upstream a9dce6679d73 bab43553 .config console log report ci-upstream-kasan-gce-386
2019/03/15 05:10 upstream 3b319ee220a8 d72db19b .config console log report ci-upstream-kasan-gce-386
2019/03/15 02:14 upstream 3b319ee220a8 d72db19b .config console log report ci-upstream-kasan-gce-386
2019/03/19 10:12 linux-next 75e6a83b189c 46264c32 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.