syzbot


possible deadlock in btrfs_join_transaction (2)

Status: upstream: reported on 2025/06/26 10:05
Subsystems: btrfs
[Documentation on labels]
Reported-by: syzbot+872fc61967352fcc3535@syzkaller.appspotmail.com
First crash: 53d, last: 37d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [btrfs?] possible deadlock in btrfs_join_transaction (2) 0 (1) 2025/06/26 10:05
Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in btrfs_join_transaction 4 2 78d 99d 0/3 upstream: reported on 2025/05/06 20:52
upstream possible deadlock in btrfs_join_transaction btrfs 4 C 2 989d 994d 0/29 auto-obsoleted due to no activity on 2023/03/29 11:54
linux-5.15 possible deadlock in btrfs_join_transaction origin:upstream 4 C error 62 9d03h 571d 0/3 upstream: reported C repro on 2024/01/20 21:24

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc4-syzkaller-g7482bb149b9f #0 Not tainted
------------------------------------------------------
syz.1.323/8141 is trying to acquire lock:
ffff0000d63fc618 (sb_internal#2){.+.+}-{0:0}, at: btrfs_join_transaction+0x30/0x40 fs/btrfs/transaction.c:830

but task is already holding lock:
ffff0000d7eedbd0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
ffff0000d7eedbd0 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x180/0x43c mm/util.c:577

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&mm->mmap_lock){++++}-{4:4}:
       down_read_killable+0x60/0x32c kernel/locking/rwsem.c:1547
       mmap_read_lock_killable+0x28/0x8c include/linux/mmap_lock.h:421
       get_mmap_lock_carefully mm/mmap_lock.c:197 [inline]
       lock_mm_and_find_vma+0x2a4/0x2d8 mm/mmap_lock.c:248
       do_page_fault+0x51c/0x1554 arch/arm64/mm/fault.c:662
       do_translation_fault+0xc4/0x114 arch/arm64/mm/fault.c:777
       do_mem_abort+0x70/0x194 arch/arm64/mm/fault.c:916
       el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:481
       el1h_64_sync_handler+0x50/0xfc arch/arm64/kernel/entry-common.c:597
       el1h_64_sync+0x6c/0x70 arch/arm64/kernel/entry.S:595
       __uaccess_mask_ptr arch/arm64/include/asm/uaccess.h:169 [inline]
       filldir64+0x2ec/0x6bc fs/readdir.c:379
       dir_emit include/linux/fs.h:3919 [inline]
       kernfs_fop_readdir+0x498/0x79c fs/kernfs/dir.c:1910
       iterate_dir+0x458/0x5e0 fs/readdir.c:108
       __do_sys_getdents64 fs/readdir.c:410 [inline]
       __se_sys_getdents64 fs/readdir.c:396 [inline]
       __arm64_sys_getdents64+0x110/0x2fc fs/readdir.c:396
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #4 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       kernfs_add_one+0x48/0x60c fs/kernfs/dir.c:791
       kernfs_create_dir_ns+0xd4/0x12c fs/kernfs/dir.c:1093
       sysfs_create_dir_ns+0x114/0x24c fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x5a8/0xb20 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x118/0x17c lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x110/0x268 fs/btrfs/sysfs.c:2635
       btrfs_quota_enable+0x224/0x1c70 fs/btrfs/qgroup.c:1030
       btrfs_ioctl_quota_ctl+0x178/0x1bc fs/btrfs/ioctl.c:3673
       btrfs_ioctl+0x86c/0xc3c fs/btrfs/ioctl.c:5323
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:907 [inline]
       __se_sys_ioctl fs/ioctl.c:893 [inline]
       __arm64_sys_ioctl+0x14c/0x1c4 fs/ioctl.c:893
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #3 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       __mutex_lock_common+0x1d0/0x2190 kernel/locking/mutex.c:602
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799
       btrfs_quota_enable+0x270/0x1c70 fs/btrfs/qgroup.c:1059
       btrfs_ioctl_quota_ctl+0x178/0x1bc fs/btrfs/ioctl.c:3673
       btrfs_ioctl+0x86c/0xc3c fs/btrfs/ioctl.c:5323
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:907 [inline]
       __se_sys_ioctl fs/ioctl.c:893 [inline]
       __arm64_sys_ioctl+0x14c/0x1c4 fs/ioctl.c:893
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #2 (btrfs_trans_num_extwriters){++++}-{0:0}:
       join_transaction+0x190/0xb5c fs/btrfs/transaction.c:321
       start_transaction+0x778/0x155c fs/btrfs/transaction.c:705
       btrfs_start_transaction+0x34/0x44 fs/btrfs/transaction.c:816
       btrfs_rebuild_free_space_tree+0xac/0x54c fs/btrfs/free-space-tree.c:1341
       btrfs_start_pre_rw_mount+0xa78/0xe10 fs/btrfs/disk-io.c:3078
       open_ctree+0x1b8c/0x22ac fs/btrfs/disk-io.c:3618
       btrfs_fill_super+0x184/0x2c0 fs/btrfs/super.c:968
       btrfs_get_tree_super fs/btrfs/super.c:1893 [inline]
       btrfs_get_tree+0xc50/0x1040 fs/btrfs/super.c:2088
       vfs_get_tree+0x90/0x28c fs/super.c:1804
       fc_mount+0x24/0xac fs/namespace.c:1290
       btrfs_get_tree_subvol fs/btrfs/super.c:2046 [inline]
       btrfs_get_tree+0x4d8/0x1040 fs/btrfs/super.c:2089
       vfs_get_tree+0x90/0x28c fs/super.c:1804
       do_new_mount+0x228/0x814 fs/namespace.c:3902
       path_mount+0x5b4/0xde0 fs/namespace.c:4226
       do_mount fs/namespace.c:4239 [inline]
       __do_sys_mount fs/namespace.c:4450 [inline]
       __se_sys_mount fs/namespace.c:4427 [inline]
       __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4427
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #1 (btrfs_trans_num_writers){++++}-{0:0}:
       join_transaction+0x164/0xb5c fs/btrfs/transaction.c:320
       start_transaction+0x778/0x155c fs/btrfs/transaction.c:705
       btrfs_start_transaction+0x34/0x44 fs/btrfs/transaction.c:816
       btrfs_rebuild_free_space_tree+0xac/0x54c fs/btrfs/free-space-tree.c:1341
       btrfs_start_pre_rw_mount+0xa78/0xe10 fs/btrfs/disk-io.c:3078
       open_ctree+0x1b8c/0x22ac fs/btrfs/disk-io.c:3618
       btrfs_fill_super+0x184/0x2c0 fs/btrfs/super.c:968
       btrfs_get_tree_super fs/btrfs/super.c:1893 [inline]
       btrfs_get_tree+0xc50/0x1040 fs/btrfs/super.c:2088
       vfs_get_tree+0x90/0x28c fs/super.c:1804
       fc_mount+0x24/0xac fs/namespace.c:1290
       btrfs_get_tree_subvol fs/btrfs/super.c:2046 [inline]
       btrfs_get_tree+0x4d8/0x1040 fs/btrfs/super.c:2089
       vfs_get_tree+0x90/0x28c fs/super.c:1804
       do_new_mount+0x228/0x814 fs/namespace.c:3902
       path_mount+0x5b4/0xde0 fs/namespace.c:4226
       do_mount fs/namespace.c:4239 [inline]
       __do_sys_mount fs/namespace.c:4450 [inline]
       __se_sys_mount fs/namespace.c:4427 [inline]
       __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4427
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain kernel/locking/lockdep.c:3911 [inline]
       __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240
       lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1795 [inline]
       sb_start_intwrite include/linux/fs.h:1978 [inline]
       start_transaction+0x5bc/0x155c fs/btrfs/transaction.c:699
       btrfs_join_transaction+0x30/0x40 fs/btrfs/transaction.c:830
       btrfs_dirty_inode+0x90/0x190 fs/btrfs/inode.c:6225
       btrfs_update_time+0xa0/0xd0 fs/btrfs/inode.c:6259
       inode_update_time fs/inode.c:2076 [inline]
       touch_atime+0x2e4/0x818 fs/inode.c:2149
       file_accessed include/linux/fs.h:2652 [inline]
       btrfs_file_mmap+0xac/0x118 fs/btrfs/file.c:1988
       call_mmap include/linux/fs.h:2286 [inline]
       mmap_file mm/internal.h:167 [inline]
       __mmap_new_file_vma mm/vma.c:2405 [inline]
       __mmap_new_vma mm/vma.c:2467 [inline]
       __mmap_region mm/vma.c:2622 [inline]
       mmap_region+0xe9c/0x1c0c mm/vma.c:2692
       do_mmap+0x968/0xfac mm/mmap.c:561
       vm_mmap_pgoff+0x2b8/0x43c mm/util.c:579
       ksys_mmap_pgoff+0x394/0x5b8 mm/mmap.c:607
       __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
       __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
       __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &root->kernfs_rwsem --> &mm->mmap_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&root->kernfs_rwsem);
                               lock(&mm->mmap_lock);
  rlock(sb_internal#2);

 *** DEADLOCK ***

2 locks held by syz.1.323/8141:
 #0: ffff0000d7eedbd0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
 #0: ffff0000d7eedbd0 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x180/0x43c mm/util.c:577
 #1: ffff0000d63fc428 (sb_writers#12){.+.+}-{0:0}, at: file_accessed include/linux/fs.h:2652 [inline]
 #1: ffff0000d63fc428 (sb_writers#12){.+.+}-{0:0}, at: btrfs_file_mmap+0xac/0x118 fs/btrfs/file.c:1988

stack backtrace:
CPU: 0 UID: 0 PID: 8141 Comm: syz.1.323 Not tainted 6.16.0-rc4-syzkaller-g7482bb149b9f #0 PREEMPT 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:501 (C)
 __dump_stack+0x30/0x40 lib/dump_stack.c:94
 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2046
 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain kernel/locking/lockdep.c:3911 [inline]
 __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240
 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs.h:1795 [inline]
 sb_start_intwrite include/linux/fs.h:1978 [inline]
 start_transaction+0x5bc/0x155c fs/btrfs/transaction.c:699
 btrfs_join_transaction+0x30/0x40 fs/btrfs/transaction.c:830
 btrfs_dirty_inode+0x90/0x190 fs/btrfs/inode.c:6225
 btrfs_update_time+0xa0/0xd0 fs/btrfs/inode.c:6259
 inode_update_time fs/inode.c:2076 [inline]
 touch_atime+0x2e4/0x818 fs/inode.c:2149
 file_accessed include/linux/fs.h:2652 [inline]
 btrfs_file_mmap+0xac/0x118 fs/btrfs/file.c:1988
 call_mmap include/linux/fs.h:2286 [inline]
 mmap_file mm/internal.h:167 [inline]
 __mmap_new_file_vma mm/vma.c:2405 [inline]
 __mmap_new_vma mm/vma.c:2467 [inline]
 __mmap_region mm/vma.c:2622 [inline]
 mmap_region+0xe9c/0x1c0c mm/vma.c:2692
 do_mmap+0x968/0xfac mm/mmap.c:561
 vm_mmap_pgoff+0x2b8/0x43c mm/util.c:579
 ksys_mmap_pgoff+0x394/0x5b8 mm/mmap.c:607
 __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
 __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
 __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:879
 el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:898
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/07/08 05:16 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 7482bb149b9f 4f67c4ae .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in btrfs_join_transaction
2025/06/22 09:54 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9aa9b43d689e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in btrfs_join_transaction
* Struck through repros no longer work on HEAD.