syzbot


general protection fault in xt_rateest_put

Status: fixed on 2020/02/18 14:31
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+91bdd8eece0f6629ec8b@syzkaller.appspotmail.com
Fix commit: 212e7f56605e netfilter: arp_tables: init netns pointer in xt_tgdtor_param struct
First crash: 1538d, last: 1530d
Cause bisection: introduced by (bisect log) :
commit 3427b2ab63faccafe774ea997fc2da7faf690c5a
Author: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri Mar 2 02:58:38 2018 +0000

  netfilter: make xt_rateest hash table per net

Crash: general protection fault in xt_rateest_tg_checkentry (log)
Repro: C syz .config
  
Discussions (12)
Title Replies (including bot) Last reply
[PATCH 3.16 000/245] 3.16.83-rc1 review 260 (260) 2020/04/24 17:54
[PATCH 4.14 00/65] 4.14.167-stable review 73 (73) 2020/04/20 14:15
[PATCH 5.4 000/222] 5.4.14-stable review 238 (238) 2020/01/26 16:57
[PATCH AUTOSEL 5.4 001/107] batman-adv: Fix DAT candidate selection on little endian systems 97 (97) 2020/01/24 21:08
[PATCH AUTOSEL 4.9 01/18] batman-adv: Fix DAT candidate selection on little endian systems 18 (18) 2020/01/24 14:21
[PATCH AUTOSEL 4.14 01/32] batman-adv: Fix DAT candidate selection on little endian systems 32 (32) 2020/01/24 14:21
[PATCH AUTOSEL 4.19 01/56] batman-adv: Fix DAT candidate selection on little endian systems 56 (56) 2020/01/24 14:20
[PATCH 4.19 000/103] 4.19.98-stable review 108 (108) 2020/01/22 20:53
[PATCH 4.9 00/97] 4.9.211-stable review 102 (102) 2020/01/22 20:52
[PATCH 0/9] Netfilter updates for net 11 (11) 2020/01/17 09:37
[PATCH nf] netfilter: arp_tables: init netns pointer in xt_tgdtor_param struct 2 (2) 2020/01/13 17:51
general protection fault in xt_rateest_put 3 (5) 2020/01/12 20:13
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 general protection fault in xt_rateest_put C done 10 1530d 1533d 1/1 fixed on 2020/02/18 00:37

Sample crash report:
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 10708 Comm: syz-executor566 Not tainted 5.5.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__read_once_size include/linux/compiler.h:199 [inline]
RIP: 0010:net_generic include/net/netns/generic.h:45 [inline]
RIP: 0010:xt_rateest_put+0xa1/0x440 net/netfilter/xt_RATEEST.c:77
Code: 15 76 04 fb 45 84 f6 0f 84 68 02 00 00 e8 c7 74 04 fb 49 8d bd 68 13 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 6c 03 00 00 4d 8b b5 68 13 00 00 e8 b9 ad f0 fa
RSP: 0018:ffffc900020b7940 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff8880a313ff00 RCX: ffffffff86708332
RDX: 000000000000026d RSI: ffffffff867080b9 RDI: 0000000000001368
RBP: ffffc900020b7970 R08: ffff88809414a440 R09: ffffed1015d2703d
R10: ffffed1015d2703c R11: ffff8880ae9381e3 R12: 000000000000002d
R13: 0000000000000000 R14: 0000000000000001 R15: ffffffff86708470
FS:  0000000002055880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000560653bcd140 CR3: 0000000098b2a000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 xt_rateest_tg_destroy+0x72/0xa0 net/netfilter/xt_RATEEST.c:175
 cleanup_entry net/ipv4/netfilter/arp_tables.c:509 [inline]
 translate_table+0x11f4/0x1d80 net/ipv4/netfilter/arp_tables.c:587
 do_replace net/ipv4/netfilter/arp_tables.c:981 [inline]
 do_arpt_set_ctl+0x317/0x650 net/ipv4/netfilter/arp_tables.c:1461
 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
 nf_setsockopt+0x77/0xd0 net/netfilter/nf_sockopt.c:115
 ip_setsockopt net/ipv4/ip_sockglue.c:1260 [inline]
 ip_setsockopt+0xdf/0x100 net/ipv4/ip_sockglue.c:1240
 udp_setsockopt+0x68/0xb0 net/ipv4/udp.c:2639
 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:3149
 __sys_setsockopt+0x261/0x4c0 net/socket.c:2117
 __do_sys_setsockopt net/socket.c:2133 [inline]
 __se_sys_setsockopt net/socket.c:2130 [inline]
 __x64_sys_setsockopt+0xbe/0x150 net/socket.c:2130
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4419a9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc0cf3fe48 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004419a9
RDX: 0000000000000060 RSI: 0a02000000000000 RDI: 0000000000000003
RBP: 00000000006cc018 R08: 0000000000000430 R09: 00000000004002c8
R10: 00000000200008c0 R11: 0000000000000246 R12: 0000000000403230
R13: 00000000004032c0 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 8fe720582864881d ]---
RIP: 0010:__read_once_size include/linux/compiler.h:199 [inline]
RIP: 0010:net_generic include/net/netns/generic.h:45 [inline]
RIP: 0010:xt_rateest_put+0xa1/0x440 net/netfilter/xt_RATEEST.c:77
Code: 15 76 04 fb 45 84 f6 0f 84 68 02 00 00 e8 c7 74 04 fb 49 8d bd 68 13 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 6c 03 00 00 4d 8b b5 68 13 00 00 e8 b9 ad f0 fa
RSP: 0018:ffffc900020b7940 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff8880a313ff00 RCX: ffffffff86708332
RDX: 000000000000026d RSI: ffffffff867080b9 RDI: 0000000000001368
RBP: ffffc900020b7970 R08: ffff88809414a440 R09: ffffed1015d2703d
R10: ffffed1015d2703c R11: ffff8880ae9381e3 R12: 000000000000002d
R13: 0000000000000000 R14: 0000000000000001 R15: ffffffff86708470
FS:  0000000002055880(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000561548d6b008 CR3: 0000000098b2a000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (97):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/16 08:17 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/16 07:46 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce
2020/01/16 07:44 upstream 51d69817519f f9b69507 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 10:05 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/11 09:44 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/11 09:24 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/11 09:04 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/11 02:51 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 02:21 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 01:59 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 01:55 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 01:39 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 01:30 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 01:19 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 01:10 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 00:58 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 00:39 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 00:18 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce
2020/01/11 00:15 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/11 00:11 upstream e69ec487b2c7 4de4e9f0 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/16 07:41 net-old 8b792f84c637 f9b69507 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 02:47 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 02:26 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 02:07 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 01:46 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 01:27 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/11 00:29 net-old e267371dd376 4de4e9f0 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/16 07:39 net-next-old 4e2fa6b90275 f9b69507 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 02:02 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 01:40 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 01:21 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 01:02 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 00:42 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 00:18 net-next-old 9f120e7659b0 4de4e9f0 .config console log report syz C ci-upstream-net-kasan-gce
2020/01/11 00:09 linux-next 6c09d7dbb7d3 4de4e9f0 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/01/17 15:59 upstream f4353c3e2aaf 3de7aabb .config console log report ci-upstream-kasan-gce-root
2020/01/16 20:12 upstream f5ae2ea6347a 3de7aabb .config console log report ci-upstream-kasan-gce
2020/01/16 06:58 upstream 51d69817519f f9b69507 .config console log report ci-upstream-kasan-gce-root
2020/01/12 00:56 upstream bef1d88263ff 4c04afaa .config console log report ci-upstream-kasan-gce
2020/01/11 00:26 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce-root
2020/01/11 00:26 upstream bef1d88263ff 532ec44e .config console log report ci-qemu-upstream
2020/01/11 00:25 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce-selinux-root
2020/01/11 00:22 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce
2020/01/10 23:58 upstream bef1d88263ff 532ec44e .config console log report ci-qemu-upstream
2020/01/10 23:54 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce-root
2020/01/10 23:53 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce-selinux-root
2020/01/10 23:52 upstream e69ec487b2c7 4de4e9f0 .config console log report ci-upstream-kasan-gce
2020/01/16 06:55 net-old 8b792f84c637 f9b69507 .config console log report ci-upstream-net-this-kasan-gce
2020/01/10 23:51 net-old e267371dd376 4de4e9f0 .config console log report ci-upstream-net-this-kasan-gce
2020/01/18 19:38 net-next-old 9aaa29494030 3de7aabb .config console log report ci-upstream-net-kasan-gce
2020/01/12 20:05 net-next-old 5c9166f03825 31290a45 .config console log report ci-upstream-net-kasan-gce
2020/01/11 00:26 net-next-old 9f120e7659b0 4de4e9f0 .config console log report ci-upstream-net-kasan-gce
2020/01/10 23:56 net-next-old 9f120e7659b0 4de4e9f0 .config console log report ci-upstream-net-kasan-gce
2020/01/11 00:22 linux-next 6c09d7dbb7d3 4de4e9f0 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/01/10 23:50 linux-next 6c09d7dbb7d3 4de4e9f0 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.