syzbot


WARNING in ovl_instantiate

Status: fixed on 2019/06/23 12:03
Subsystems: overlayfs
[Documentation on labels]
Reported-by: syzbot+9c69c282adc4edd2b540@syzkaller.appspotmail.com
Fix commit: 146d62e5a586 ovl: detect overlapping layers acf3062a7e1c ovl: relax WARN_ON() for overlapping layers use case
First crash: 1991d, last: 1823d
Cause bisection: introduced by (bisect log) :
commit 01b39dcc95680b04c7af5de7f39f577e9c4865e3
Author: Amir Goldstein <amir73il@gmail.com>
Date: Fri May 11 08:15:15 2018 +0000

  ovl: use inode_insert5() to hash a newly created inode

Crash: WARNING in ovl_instantiate (log)
Repro: syz .config
  
Discussions (7)
Title Replies (including bot) Last reply
[PATCH 4.19 00/90] 4.19.56-stable review 99 (99) 2019/06/26 10:22
[PATCH 5.1 000/121] 5.1.15-stable review 133 (133) 2019/06/26 00:51
[PATCH] ovl: fix bogus -Wmaybe-unitialized warning 1 (1) 2019/06/17 12:39
[PATCH 4.19 000/276] 4.19.47-stable review 304 (304) 2019/06/06 19:22
[PATCH 5.0 000/346] 5.0.20-stable review 355 (355) 2019/05/31 14:18
[PATCH 5.1 000/405] 5.1.6-stable review 414 (414) 2019/05/31 14:16
WARNING in ovl_instantiate 8 (13) 2019/04/22 11:58
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 WARNING in ovl_instantiate syz done 5 1830d 1835d 1/1 fixed on 2019/12/16 09:09
Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/04/19 08:21 17m amir73il@gmail.com https://github.com/amir73il/linux.git ovl-check-overlap OK

Sample crash report:
WARNING: CPU: 1 PID: 9644 at fs/overlayfs/dir.c:263 ovl_instantiate+0x293/0x2f0 fs/overlayfs/dir.c:263
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 9644 Comm: syz-executor.3 Not tainted 5.1.0-rc5+ #77
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x2cb/0x65c kernel/panic.c:214
 __warn.cold+0x20/0x45 kernel/panic.c:571
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:179 [inline]
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:272
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:291
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:973
RIP: 0010:ovl_instantiate+0x293/0x2f0 fs/overlayfs/dir.c:263
Code: 04 31 ff 89 c3 89 c6 e8 3b 20 1a ff 85 db 75 63 e8 b2 1e 1a ff 4c 89 e7 45 31 e4 e8 37 0d 61 ff e9 20 ff ff ff e8 9d 1e 1a ff <0f> 0b 41 89 dc e9 11 ff ff ff e8 8e 1e 1a ff 0f 0b eb 86 48 89 85
RSP: 0018:ffff8880803f7a98 EFLAGS: 00010293
RAX: ffff88809fd2e180 RBX: ffffffffffffff8c RCX: ffffffff82566d1d
RDX: 0000000000000000 RSI: ffffffff82566e53 RDI: 0000000000000007
RBP: ffff8880803f7b70 R08: ffff88809fd2e180 R09: ffffed101007ef2c
R10: ffffed101007ef2b R11: 0000000000000003 R12: ffff888078bb9e40
R13: ffff8880945fdca0 R14: 0000000000000000 R15: ffff8880803f7b48
 ovl_create_over_whiteout fs/overlayfs/dir.c:518 [inline]
 ovl_create_or_link+0xabb/0x1250 fs/overlayfs/dir.c:582
 ovl_create_object+0x231/0x2c0 fs/overlayfs/dir.c:616
 ovl_symlink+0x25/0x30 fs/overlayfs/dir.c:651
 vfs_symlink fs/namei.c:4125 [inline]
 vfs_symlink+0x378/0x5d0 fs/namei.c:4111
 do_symlinkat+0x22b/0x290 fs/namei.c:4152
 __do_sys_symlink fs/namei.c:4171 [inline]
 __se_sys_symlink fs/namei.c:4169 [inline]
 __x64_sys_symlink+0x59/0x80 fs/namei.c:4169
 do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x458c29
Code: ad b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f97f4e3ec78 EFLAGS: 00000246 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 0000000000458c29
RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000020000040
RBP: 000000000073bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f97f4e3f6d4
R13: 00000000004c74d3 R14: 00000000004dd3a0 R15: 00000000ffffffff
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (75):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/04/21 10:44 upstream 9e5de623a0cb b0e8efcb .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/04/16 05:18 upstream 5512320c9f6f 505ab413 .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/01/12 01:51 upstream de6629eb262e c3f3344c .config console log report syz ci-upstream-kasan-gce-root
2019/01/09 03:12 upstream 7b5585136713 010ed08b .config console log report syz ci-upstream-kasan-gce-smack-root
2019/04/21 09:31 linux-next 3f018f4a019a b0e8efcb .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/01/16 13:30 linux-next cbeb3db684f7 b47fa78d .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/01/11 16:42 linux-next b808822a75a3 c3f3344c .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/01/08 22:06 linux-next 139287cc2cc0 010ed08b .config console log report syz ci-upstream-linux-next-kasan-gce-root
2018/12/15 19:33 linux-next d14b746c6c1c c9128939 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/04/27 21:18 upstream baf76f0c58ae b617407b .config console log report ci-upstream-kasan-gce-selinux-root
2019/04/27 07:37 upstream baf76f0c58ae b617407b .config console log report ci-upstream-kasan-gce-smack-root
2019/04/23 14:53 upstream 085b7755808a 53199d6e .config console log report ci-upstream-kasan-gce-smack-root
2019/04/18 22:40 upstream e53f31bffe1d b0e8efcb .config console log report ci-upstream-kasan-gce-root
2019/03/08 11:25 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/03 05:02 upstream c93d9218ea56 1c0e457a .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/24 20:02 upstream c3619a482e15 7a06e792 .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/22 19:17 upstream 6ee2846cb4e7 6a5fcca4 .config console log report ci-upstream-kasan-gce-root
2019/02/17 18:05 upstream 8d33316d5205 3e98cc30 .config console log report ci-upstream-kasan-gce-root
2019/02/14 13:50 upstream 1f947a7a011f 6a46f448 .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/08 00:21 upstream d47e3da17592 aa4feb03 .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/06 09:03 upstream 8834f5600cf3 d672172c .config console log report ci-upstream-kasan-gce-smack-root
2019/02/05 13:15 upstream 8834f5600cf3 d672172c .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/01 20:26 upstream 5b4746a03199 0c07abcf .config console log report ci-upstream-kasan-gce-root
2019/02/01 10:21 upstream 5b4746a03199 0c07abcf .config console log report ci-upstream-kasan-gce-selinux-root
2019/01/31 15:50 upstream af0c9af1b3f6 0e8ea0a3 .config console log report ci-upstream-kasan-gce-root
2019/01/30 07:11 upstream 62967898789d aa432daf .config console log report ci-upstream-kasan-gce-root
2019/01/26 20:58 upstream ba6069759381 c73f090a .config console log report ci-upstream-kasan-gce-root
2019/01/22 21:34 upstream 787a3b432276 b1ff06b2 .config console log report ci-upstream-kasan-gce-selinux-root
2019/01/11 15:26 upstream 1bdbe2274920 c3f3344c .config console log report ci-upstream-kasan-gce-smack-root
2019/01/09 21:43 upstream 4064e47c8281 45c0c1b1 .config console log report ci-upstream-kasan-gce-root
2019/01/08 21:49 upstream 7b5585136713 010ed08b .config console log report ci-upstream-kasan-gce-selinux-root
2019/01/03 21:40 upstream 645ff1e8e704 66fcd29b .config console log report ci-upstream-kasan-gce-selinux-root
2018/12/31 10:02 upstream 195303136f19 2b42fdc8 .config console log report ci-upstream-kasan-gce-smack-root
2018/12/30 13:08 upstream 195303136f19 9942de5f .config console log report ci-upstream-kasan-gce-smack-root
2018/12/26 14:59 upstream 5694cecdb092 8a41a0ad .config console log report ci-upstream-kasan-gce-root
2018/12/24 20:01 upstream 8fe28cb58bcb 8a41a0ad .config console log report ci-upstream-kasan-gce-selinux-root
2018/12/23 04:35 upstream 9105b8aa50c1 e3bd7ab8 .config console log report ci-upstream-kasan-gce-selinux-root
2018/12/22 10:24 upstream 5092adb2272e 603b5124 .config console log report ci-upstream-kasan-gce-smack-root
2018/12/12 09:52 upstream f5d582777bcb c3b10a5d .config console log report ci-upstream-kasan-gce-selinux-root
2018/12/11 23:19 upstream f5d582777bcb 7795ae03 .config console log report ci-upstream-kasan-gce-root
2018/12/03 23:28 upstream 0072a0c14d5b 03f94a45 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/30 01:37 upstream f92a2ebb3d55 66071e27 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/26 09:51 upstream 2e6e902d1850 ac912200 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/25 03:32 upstream e195ca6cb6f2 ecc7c870 .config console log report ci-upstream-kasan-gce-smack-root
2018/11/24 09:39 upstream 7c98a4261827 ecc7c870 .config console log report ci-upstream-kasan-gce-smack-root
2018/11/23 21:08 upstream e6005d3c4233 eb9ed731 .config console log report ci-upstream-kasan-gce-root
2018/11/22 17:23 upstream 92b419289cee 2ee77802 .config console log report ci-upstream-kasan-gce-root
2018/11/20 14:50 upstream f2ce1065e767 9bc2a903 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/20 06:02 upstream f2ce1065e767 9bc2a903 .config console log report ci-upstream-kasan-gce-root
2018/11/20 00:44 upstream f2ce1065e767 adf636a8 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/19 17:20 upstream 9ff01193a20d adf636a8 .config console log report ci-upstream-kasan-gce-root
2018/11/18 08:27 upstream 1ce80e0fe98e adf636a8 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/17 18:57 upstream 1ce80e0fe98e b08ee62a .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/16 07:57 upstream da5322e65940 f5e275d1 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/14 19:52 upstream ccda4af0f4b9 5f5f6d14 .config console log report ci-upstream-kasan-gce-root
2018/11/14 10:25 upstream ccda4af0f4b9 5f5f6d14 .config console log report ci-upstream-kasan-gce-selinux-root
2019/04/21 20:11 linux-next 3f018f4a019a b0e8efcb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/04/21 17:03 linux-next 3f018f4a019a b0e8efcb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/04/21 13:32 linux-next 3f018f4a019a b0e8efcb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/04/21 05:14 linux-next 3f018f4a019a b0e8efcb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/04/16 04:52 linux-next f9221a7a1014 505ab413 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/03/22 14:36 linux-next 32a217bae32c dce6e62f .config console log report ci-upstream-linux-next-kasan-gce-root
2019/03/09 13:17 linux-next cf08baa29613 12365b99 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/03/04 01:08 linux-next c63e9e91a254 1c0e457a .config console log report ci-upstream-linux-next-kasan-gce-root
2019/03/03 23:36 linux-next c63e9e91a254 1c0e457a .config console log report ci-upstream-linux-next-kasan-gce-root
2019/03/03 20:37 linux-next c63e9e91a254 1c0e457a .config console log report ci-upstream-linux-next-kasan-gce-root
2019/02/09 16:31 linux-next a46228f6598a d75f7686 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/01/05 22:52 linux-next a4983672f9ca 53be0a37 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/12/15 15:14 linux-next d14b746c6c1c c9128939 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/12/08 00:06 linux-next 74c4a24df7ca 65ed2472 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/23 21:23 linux-next 442b8cea2477 eb9ed731 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/20 16:26 linux-next 442b8cea2477 9bc2a903 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/20 05:10 linux-next 442b8cea2477 9bc2a903 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/10 20:33 linux-next 442b8cea2477 f3c4e618 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.