KASAN: use-after-free Read in service_outstanding

KASAN: use-after-free Read in service_outstanding_interrupt
Status: upstream: reported C repro on 2020/08/07 12:19
Reported-by: syzbot+9e04e2df4a32fb661daf@syzkaller.appspotmail.com
Fix commit: 5e5ff0b4 USB: cdc-wdm: Fix use after free in service_outstanding_interrupt().
Patched on: [ci-qemu-upstream ci-qemu-upstream-386 ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb], missing on: [ci-qemu2-arm32 ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386]
First crash: 173d, last: 17d

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/01/04 16:28	14m	syzkaller-bugs@googlegroups.com	patch	https://github.com/google/kasan.git 5e60366d	report log

Sample crash report:

==================================================================
BUG: KASAN: use-after-free in usb_submit_urb+0x1210/0x1560 drivers/usb/core/urb.c:383
Read of size 4 at addr ffff888101d21018 by task syz-executor166/4405

CPU: 0 PID: 4405 Comm: syz-executor166 Not tainted 5.10.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x107/0x163 lib/dump_stack.c:120
 print_address_description.constprop.0.cold+0xae/0x4c8 mm/kasan/report.c:385
 __kasan_report mm/kasan/report.c:545 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:562
 usb_submit_urb+0x1210/0x1560 drivers/usb/core/urb.c:383
 service_outstanding_interrupt.part.0+0x5f/0xa0 drivers/usb/class/cdc-wdm.c:470
 service_outstanding_interrupt drivers/usb/class/cdc-wdm.c:465 [inline]
 wdm_read+0x9a0/0xbd0 drivers/usb/class/cdc-wdm.c:583
 vfs_read+0x1b5/0x570 fs/read_write.c:494
 ksys_read+0x12d/0x250 fs/read_write.c:634
 do_syscall_64+0x2d/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x44b529
Code: e8 bc b4 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 8b cb fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f2dfcb6ed98 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 00000000006dcc38 RCX: 000000000044b529
RDX: 0000000000001000 RSI: 0000000020001000 RDI: 0000000000000004
RBP: 00000000006dcc30 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006dcc3c
R13: 0142006002090100 R14: 04010040a4157d25 R15: 4000000200000112

Allocated by task 2632:
 kasan_save_stack+0x1b/0x40 mm/kasan/common.c:48
 kasan_set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc.constprop.0+0xc2/0xd0 mm/kasan/common.c:461
 kmalloc include/linux/slab.h:552 [inline]
 kzalloc include/linux/slab.h:682 [inline]
 usb_alloc_dev+0x51/0xef0 drivers/usb/core/usb.c:582
 hub_port_connect drivers/usb/core/hub.c:5129 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5363 [inline]
 port_event drivers/usb/core/hub.c:5509 [inline]
 hub_event+0x1def/0x42d0 drivers/usb/core/hub.c:5591
 process_one_work+0x98d/0x15c0 kernel/workqueue.c:2275
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
 kthread+0x38c/0x460 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296

Freed by task 2181:
 kasan_save_stack+0x1b/0x40 mm/kasan/common.c:48
 kasan_set_track+0x1c/0x30 mm/kasan/common.c:56
 kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:352
 __kasan_slab_free+0x102/0x140 mm/kasan/common.c:422
 slab_free_hook mm/slub.c:1544 [inline]
 slab_free_freelist_hook+0x5d/0x150 mm/slub.c:1577
 slab_free mm/slub.c:3140 [inline]
 kfree+0xdb/0x3a0 mm/slub.c:4122
 device_release+0x9f/0x240 drivers/base/core.c:1962
 kobject_cleanup lib/kobject.c:705 [inline]
 kobject_release lib/kobject.c:736 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x1c8/0x540 lib/kobject.c:753
 put_device+0x1b/0x30 drivers/base/core.c:3190
 hub_port_connect drivers/usb/core/hub.c:5074 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5363 [inline]
 port_event drivers/usb/core/hub.c:5509 [inline]
 hub_event+0x1c8a/0x42d0 drivers/usb/core/hub.c:5591
 process_one_work+0x98d/0x15c0 kernel/workqueue.c:2275
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
 kthread+0x38c/0x460 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296

The buggy address belongs to the object at ffff888101d21000
 which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 24 bytes inside of
 2048-byte region [ffff888101d21000, ffff888101d21800)
The buggy address belongs to the page:
page:0000000019761127 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x101d20
head:0000000019761127 order:3 compound_mapcount:0 compound_pincount:0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 dead000000000100 dead000000000122 ffff888100042000
raw: 0000000000000000 0000000080080008 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff888101d20f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff888101d20f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff888101d21000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                            ^
 ffff888101d21080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888101d21100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (28):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Maintainers
ci2-upstream-usb	2020/12/18 03:20	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	5e60366d	04201c06	.config	log	report	syz	C		gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci-upstream-kasan-gce	2020/12/14 07:13	upstream	6bff9bb8	b22a7ec3	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2021/01/09 16:50	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	841081d8	a6c52263	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2021/01/05 18:54	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	ed054e4e	a0234d98	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2021/01/05 17:42	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	ed054e4e	a0234d98	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2021/01/03 01:39	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	cb4d9b52	79264ae3	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2021/01/01 07:40	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	cb4d9b52	79264ae3	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/30 13:53	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	cb4d9b52	ecb8c012	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/29 11:05	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	cb4d9b52	8259d56c	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/29 05:31	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	32510cf5	8259d56c	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/28 16:36	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	5c8fe583	8259d56c	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/28 12:42	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	f838f8d2	2242f77f	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/26 12:35	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3644e2d2	821e0b09	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/21 15:11	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3644e2d2	04201c06	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/12/18 02:20	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	5e60366d	04201c06	.config	log	report			info	gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, penguin-kernel@I-love.SAKURA.ne.jp
ci2-upstream-usb	2020/08/30 23:41	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	d5a3ae1f	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/30 09:39	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	d5a3ae1f	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/30 01:44	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	d5a3ae1f	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/29 20:44	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	d5a3ae1f	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/29 05:39	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	d5a3ae1f	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/28 15:25	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	3ed8e1c2	816e0689	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com
ci2-upstream-usb	2020/08/25 19:27	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	cb06b385	344da168	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com
ci2-upstream-usb	2020/08/25 02:51	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	28157b8c	344da168	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/23 21:51	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	28157b8c	a6d5f3ad	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/22 00:08	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	28157b8c	6436ce4b	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com, stern@rowland.harvard.edu
ci2-upstream-usb	2020/08/21 08:08	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	28157b8c	1d75fe45	.config	log	report				eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, oneukum@suse.com
ci2-upstream-usb	2020/08/07 11:29	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	7b4ea945	28ac5c9e	.config	log	report				gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-upstream-usb	2020/08/07 10:03	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing	7b4ea945	cb436c69	.config	log	report				gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org