syzbot


possible deadlock in usb_deregister_dev

Status: fixed on 2019/09/06 20:45
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+a64a382964bf6c71a9c0@syzkaller.appspotmail.com
Fix commit: c468a8aa790e usb: iowarrior: fix deadlock on disconnect
First crash: 1721d, last: 1711d
Duplicate bugs (1)
duplicates (1):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
possible deadlock in iowarrior_open usb 200 1711d 1722d 0/26 closed as dup on 2019/08/12 12:10
Discussions (9)
Title Replies (including bot) Last reply
[PATCH 3.16 00/72] 3.16.79-rc1 review 87 (87) 2019/12/14 18:44
[PATCH 4.4 00/78] 4.4.190-stable review 91 (91) 2019/08/24 18:14
[PATCH 4.9 000/103] 4.9.190-stable review 109 (109) 2019/08/24 17:59
[PATCH 5.2 000/144] 5.2.9-stable review 153 (153) 2019/08/16 07:15
[PATCH 4.14 00/69] 4.14.139-stable review 76 (76) 2019/08/16 07:15
[PATCH 4.19 00/91] 4.19.67-stable review 106 (106) 2019/08/16 06:53
possible deadlock in usb_deregister_dev 3 (7) 2019/08/12 12:31
Re: possible deadlock in iowarrior 1 (1) 2019/08/08 17:43
[PATCH] usb: iowarrior: fix deadlock on disconnect 1 (1) 2019/08/08 09:27
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in usb_deregister_dev (2) usb C 956 1648d 1676d 13/26 fixed on 2019/10/27 22:28
Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/08/12 12:12 18m andreyknvl@google.com patch https://github.com/google/kasan.git e96407b4 OK

Sample crash report:
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
iowarrior 1-1:0.135: IOWarrior product=0x1501, serial= interface=135 now attached to iowarrior0
usb 1-1: USB disconnect, device number 2
======================================================
WARNING: possible circular locking dependency detected
5.3.0-rc2+ #25 Not tainted
------------------------------------------------------
kworker/0:1/12 is trying to acquire lock:
0000000041073ed4 (minor_rwsem){++++}, at: usb_deregister_dev drivers/usb/core/file.c:238 [inline]
0000000041073ed4 (minor_rwsem){++++}, at: usb_deregister_dev+0x61/0x270 drivers/usb/core/file.c:230

but task is already holding lock:
000000003de63af8 (iowarrior_open_disc_lock){+.+.}, at: iowarrior_disconnect+0x45/0x2c0 drivers/usb/misc/iowarrior.c:867

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (iowarrior_open_disc_lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:930 [inline]
       __mutex_lock+0x158/0x1360 kernel/locking/mutex.c:1077
       iowarrior_open+0x8a/0x2a0 drivers/usb/misc/iowarrior.c:600
       usb_open+0x1df/0x270 drivers/usb/core/file.c:48
       chrdev_open+0x219/0x5c0 fs/char_dev.c:414
       do_dentry_open+0x494/0x1120 fs/open.c:797
       do_last fs/namei.c:3416 [inline]
       path_openat+0x1430/0x3f50 fs/namei.c:3533
       do_filp_open+0x1a1/0x280 fs/namei.c:3563
       do_sys_open+0x3c0/0x580 fs/open.c:1089
       do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #1 (iowarrior_mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:930 [inline]
       __mutex_lock+0x158/0x1360 kernel/locking/mutex.c:1077
       iowarrior_open+0x23/0x2a0 drivers/usb/misc/iowarrior.c:589
       usb_open+0x1df/0x270 drivers/usb/core/file.c:48
       chrdev_open+0x219/0x5c0 fs/char_dev.c:414
       do_dentry_open+0x494/0x1120 fs/open.c:797
       do_last fs/namei.c:3416 [inline]
       path_openat+0x1430/0x3f50 fs/namei.c:3533
       do_filp_open+0x1a1/0x280 fs/namei.c:3563
       do_sys_open+0x3c0/0x580 fs/open.c:1089
       do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (minor_rwsem){++++}:
       check_prev_add kernel/locking/lockdep.c:2405 [inline]
       check_prevs_add kernel/locking/lockdep.c:2507 [inline]
       validate_chain kernel/locking/lockdep.c:2897 [inline]
       __lock_acquire+0x1f7c/0x3b50 kernel/locking/lockdep.c:3880
       lock_acquire+0x127/0x320 kernel/locking/lockdep.c:4412
       down_write+0x92/0x150 kernel/locking/rwsem.c:1500
       usb_deregister_dev drivers/usb/core/file.c:238 [inline]
       usb_deregister_dev+0x61/0x270 drivers/usb/core/file.c:230
       iowarrior_disconnect+0xa8/0x2c0 drivers/usb/misc/iowarrior.c:873
       usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
       __device_release_driver drivers/base/dd.c:1120 [inline]
       device_release_driver_internal+0x404/0x4c0 drivers/base/dd.c:1151
       bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556
       device_del+0x420/0xb10 drivers/base/core.c:2288
       usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
       usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
       hub_port_connect drivers/usb/core/hub.c:4949 [inline]
       hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
       port_event drivers/usb/core/hub.c:5359 [inline]
       hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
       process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
       worker_thread+0x96/0xe20 kernel/workqueue.c:2415
       kthread+0x318/0x420 kernel/kthread.c:255
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

other info that might help us debug this:

Chain exists of:
  minor_rwsem --> iowarrior_mutex --> iowarrior_open_disc_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(iowarrior_open_disc_lock);
                               lock(iowarrior_mutex);
                               lock(iowarrior_open_disc_lock);
  lock(minor_rwsem);

 *** DEADLOCK ***

6 locks held by kworker/0:1/12:
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: __write_once_size include/linux/compiler.h:226 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: atomic64_set include/asm-generic/atomic-instrumented.h:855 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: atomic_long_set include/asm-generic/atomic-long.h:40 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: set_work_data kernel/workqueue.c:620 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: set_work_pool_and_clear_pending kernel/workqueue.c:647 [inline]
 #0: 00000000199c7bd5 ((wq_completion)usb_hub_wq){+.+.}, at: process_one_work+0x827/0x1530 kernel/workqueue.c:2240
 #1: 000000006e079ed1 ((work_completion)(&hub->events)){+.+.}, at: process_one_work+0x85b/0x1530 kernel/workqueue.c:2244
 #2: 000000002179688b (&dev->mutex){....}, at: device_lock include/linux/device.h:1220 [inline]
 #2: 000000002179688b (&dev->mutex){....}, at: hub_event+0x17c/0x3640 drivers/usb/core/hub.c:5387
 #3: 000000009ab53871 (&dev->mutex){....}, at: device_lock include/linux/device.h:1220 [inline]
 #3: 000000009ab53871 (&dev->mutex){....}, at: usb_disconnect+0x91/0x8d0 drivers/usb/core/hub.c:2190
 #4: 000000006ef0693e (&dev->mutex){....}, at: device_release_driver_internal+0x23/0x4c0 drivers/base/dd.c:1148
 #5: 000000003de63af8 (iowarrior_open_disc_lock){+.+.}, at: iowarrior_disconnect+0x45/0x2c0 drivers/usb/misc/iowarrior.c:867

stack backtrace:
CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc2+ #25
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 check_noncircular+0x345/0x3e0 kernel/locking/lockdep.c:1741
 check_prev_add kernel/locking/lockdep.c:2405 [inline]
 check_prevs_add kernel/locking/lockdep.c:2507 [inline]
 validate_chain kernel/locking/lockdep.c:2897 [inline]
 __lock_acquire+0x1f7c/0x3b50 kernel/locking/lockdep.c:3880
 lock_acquire+0x127/0x320 kernel/locking/lockdep.c:4412
 down_write+0x92/0x150 kernel/locking/rwsem.c:1500
 usb_deregister_dev drivers/usb/core/file.c:238 [inline]
 usb_deregister_dev+0x61/0x270 drivers/usb/core/file.c:230
 iowarrior_disconnect+0xa8/0x2c0 drivers/usb/misc/iowarrior.c:873
 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
 __device_release_driver drivers/base/dd.c:1120 [inline]
 device_release_driver_internal+0x404/0x4c0 drivers/base/dd.c:1151
 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556
 device_del+0x420/0xb10 drivers/base/core.c:2288
 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:4949 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269

Crashes (82):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/09 20:40 https://github.com/google/kasan.git usb-fuzzer e96407b49762 aff9e255 .config console log report syz C ci2-upstream-usb
2019/08/09 18:17 https://github.com/google/kasan.git usb-fuzzer e96407b49762 aff9e255 .config console log report syz C ci2-upstream-usb
2019/08/12 10:34 https://github.com/google/kasan.git usb-fuzzer e96407b49762 8620c2c2 .config console log report ci2-upstream-usb
2019/08/12 07:57 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/12 05:47 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/12 04:44 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/11 23:04 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/11 16:04 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/11 14:06 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/11 08:55 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/11 01:12 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 21:55 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 18:45 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 15:27 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 14:27 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 11:56 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 10:41 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 08:12 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 06:46 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 04:18 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/10 02:37 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report ci2-upstream-usb
2019/08/09 22:33 https://github.com/google/kasan.git usb-fuzzer e96407b49762 aff9e255 .config console log report ci2-upstream-usb
2019/08/09 19:57 https://github.com/google/kasan.git usb-fuzzer e96407b49762 aff9e255 .config console log report ci2-upstream-usb
2019/08/09 17:34 https://github.com/google/kasan.git usb-fuzzer e96407b49762 aff9e255 .config console log report ci2-upstream-usb
2019/08/09 13:27 https://github.com/google/kasan.git usb-fuzzer e96407b49762 ede31a9b .config console log report ci2-upstream-usb
2019/08/09 11:38 https://github.com/google/kasan.git usb-fuzzer e96407b49762 ede31a9b .config console log report ci2-upstream-usb
2019/08/09 10:23 https://github.com/google/kasan.git usb-fuzzer e96407b49762 ede31a9b .config console log report ci2-upstream-usb
2019/08/08 17:53 https://github.com/google/kasan.git usb-fuzzer e96407b49762 bcc419e9 .config console log report ci2-upstream-usb
2019/08/08 09:06 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/08 08:34 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/08 06:57 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/08 02:34 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/08 01:56 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/08 01:24 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/07 20:50 https://github.com/google/kasan.git usb-fuzzer e96407b49762 e6ebef88 .config console log report ci2-upstream-usb
2019/08/07 14:55 https://github.com/google/kasan.git usb-fuzzer e96407b49762 cdde7486 .config console log report ci2-upstream-usb
2019/08/07 13:27 https://github.com/google/kasan.git usb-fuzzer e96407b49762 cdde7486 .config console log report ci2-upstream-usb
2019/08/07 09:29 https://github.com/google/kasan.git usb-fuzzer e96407b49762 cdde7486 .config console log report ci2-upstream-usb
2019/08/07 08:36 https://github.com/google/kasan.git usb-fuzzer e96407b49762 cdde7486 .config console log report ci2-upstream-usb
2019/08/06 23:59 https://github.com/google/kasan.git usb-fuzzer e96407b49762 da562c0b .config console log report ci2-upstream-usb
2019/08/06 14:11 https://github.com/google/kasan.git usb-fuzzer e96407b49762 da562c0b .config console log report ci2-upstream-usb
2019/08/06 13:47 https://github.com/google/kasan.git usb-fuzzer e96407b49762 da562c0b .config console log report ci2-upstream-usb
2019/08/06 13:28 https://github.com/google/kasan.git usb-fuzzer e96407b49762 da562c0b .config console log report ci2-upstream-usb
2019/08/03 11:56 https://github.com/google/kasan.git usb-fuzzer e96407b49762 6affd8e8 .config console log report ci2-upstream-usb
2019/08/03 11:50 https://github.com/google/kasan.git usb-fuzzer e96407b49762 6affd8e8 .config console log report ci2-upstream-usb
2019/08/03 09:14 https://github.com/google/kasan.git usb-fuzzer e96407b49762 6affd8e8 .config console log report ci2-upstream-usb
2019/08/02 14:41 https://github.com/google/kasan.git usb-fuzzer e96407b49762 835dffe7 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.