syzbot


KASAN: slab-out-of-bounds Read in bitmap_ip_test

Status: fixed on 2020/02/18 14:31
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+b08bd19bb37513357fd4@syzkaller.appspotmail.com
Fix commit: 32c72165dbd0 netfilter: ipset: use bitmap infrastructure completely
First crash: 1649d, last: 1638d
Discussions (8)
Title Replies (including bot) Last reply
[PATCH 4.19 00/92] 4.19.100-stable review 98 (98) 2020/01/31 13:57
[PATCH 4.9 000/271] 4.9.212-stable review 283 (283) 2020/01/29 22:35
[PATCH 5.4 000/104] 5.4.16-stable review 113 (113) 2020/01/29 15:36
[PATCH 4.14 00/46] 4.14.169-stable review 51 (51) 2020/01/29 14:42
[PATCH 4.4 000/183] 4.4.212-stable review 190 (190) 2020/01/29 13:12
[PATCH 0/7] Netfilter fixes for net 9 (9) 2020/01/25 20:40
[PATCH 1/1] netfilter: ipset: use bitmap infrastructure completely 2 (2) 2020/01/20 16:42
KASAN: slab-out-of-bounds Read in bitmap_ip_test 0 (1) 2020/01/18 16:37

Sample crash report:
==================================================================
BUG: KASAN: slab-out-of-bounds in test_bit include/asm-generic/bitops/instrumented-non-atomic.h:110 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_do_test net/netfilter/ipset/ip_set_bitmap_ip.c:70 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_test+0xde/0x170 net/netfilter/ipset/ip_set_bitmap_gen.h:122
Read of size 8 at addr ffff88809ec89e80 by task syz-executor.0/10495

CPU: 1 PID: 10495 Comm: syz-executor.0 Not tainted 5.5.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
 __kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506
 kasan_report+0x12/0x20 mm/kasan/common.c:639
 check_memory_region_inline mm/kasan/generic.c:185 [inline]
 check_memory_region+0x134/0x1a0 mm/kasan/generic.c:192
 __kasan_check_read+0x11/0x20 mm/kasan/common.c:95
 test_bit include/asm-generic/bitops/instrumented-non-atomic.h:110 [inline]
 bitmap_ip_do_test net/netfilter/ipset/ip_set_bitmap_ip.c:70 [inline]
 bitmap_ip_test+0xde/0x170 net/netfilter/ipset/ip_set_bitmap_gen.h:122
 bitmap_ip_uadt+0x87a/0xa10 net/netfilter/ipset/ip_set_bitmap_ip.c:159
 ip_set_utest+0x570/0x8d0 net/netfilter/ipset/ip_set_core.c:1868
 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:639 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:659
 ____sys_sendmsg+0x753/0x880 net/socket.c:2330
 ___sys_sendmsg+0x100/0x170 net/socket.c:2384
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2417
 __do_sys_sendmsg net/socket.c:2426 [inline]
 __se_sys_sendmsg net/socket.c:2424 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x45b349
Code: ad b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fad7e3c7c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fad7e3c86d4 RCX: 000000000045b349
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000004
RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff
R13: 00000000000008ea R14: 00000000004ca43c R15: 000000000075bf2c

Allocated by task 10492:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 __kasan_kmalloc mm/kasan/common.c:513 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:486
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:527
 __do_kmalloc mm/slab.c:3656 [inline]
 __kmalloc+0x163/0x770 mm/slab.c:3665
 kmalloc include/linux/slab.h:561 [inline]
 kzalloc include/linux/slab.h:670 [inline]
 ip_set_alloc+0x38/0x5e net/netfilter/ipset/ip_set_core.c:255
 init_map_ip net/netfilter/ipset/ip_set_bitmap_ip.c:223 [inline]
 bitmap_ip_create+0x6ec/0xc20 net/netfilter/ipset/ip_set_bitmap_ip.c:327
 ip_set_create+0x6f1/0x1500 net/netfilter/ipset/ip_set_core.c:1111
 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:639 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:659
 ____sys_sendmsg+0x753/0x880 net/socket.c:2330
 ___sys_sendmsg+0x100/0x170 net/socket.c:2384
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2417
 __do_sys_sendmsg net/socket.c:2426 [inline]
 __se_sys_sendmsg net/socket.c:2424 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 10275:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 kasan_set_free_info mm/kasan/common.c:335 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:474
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:483
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3757
 tomoyo_add_entry security/tomoyo/common.c:2045 [inline]
 tomoyo_supervisor+0xc2c/0xef0 security/tomoyo/common.c:2103
 tomoyo_audit_env_log security/tomoyo/environ.c:36 [inline]
 tomoyo_env_perm+0x18e/0x210 security/tomoyo/environ.c:63
 tomoyo_environ security/tomoyo/domain.c:674 [inline]
 tomoyo_find_next_domain+0x1354/0x1f6c security/tomoyo/domain.c:881
 tomoyo_bprm_check_security security/tomoyo/tomoyo.c:107 [inline]
 tomoyo_bprm_check_security+0x124/0x1a0 security/tomoyo/tomoyo.c:97
 security_bprm_check+0x63/0xb0 security/security.c:784
 search_binary_handler+0x71/0x570 fs/exec.c:1645
 exec_binprm fs/exec.c:1701 [inline]
 __do_execve_file.isra.0+0x1329/0x22b0 fs/exec.c:1821
 do_execveat_common fs/exec.c:1867 [inline]
 do_execve fs/exec.c:1884 [inline]
 __do_sys_execve fs/exec.c:1960 [inline]
 __se_sys_execve fs/exec.c:1955 [inline]
 __x64_sys_execve+0x8f/0xc0 fs/exec.c:1955
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff88809ec89e80
 which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes inside of
 32-byte region [ffff88809ec89e80, ffff88809ec89ea0)
The buggy address belongs to the page:
page:ffffea00027b2240 refcount:1 mapcount:0 mapping:ffff8880aa4001c0 index:0xffff88809ec89fc1
raw: 00fffe0000000200 ffffea00027ae388 ffffea0002a50188 ffff8880aa4001c0
raw: ffff88809ec89fc1 ffff88809ec89000 000000010000003f 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809ec89d80: fb fb fb fb fc fc fc fc 00 00 00 fc fc fc fc fc
 ffff88809ec89e00: 00 00 fc fc fc fc fc fc fb fb fb fb fc fc fc fc
>ffff88809ec89e80: 04 fc fc fc fc fc fc fc 00 00 00 00 fc fc fc fc
                   ^
 ffff88809ec89f00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
 ffff88809ec89f80: fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/19 17:57 upstream 8f8972a3127f 0342f8c7 .config console log report syz ci-upstream-kasan-gce-selinux-root
2020/01/19 07:50 upstream 244dc2689085 bc8bc756 .config console log report syz ci-upstream-kasan-gce
2020/01/19 05:15 upstream 244dc2689085 bc8bc756 .config console log report syz ci-upstream-kasan-gce-root
2020/01/18 19:58 upstream 25e73aadf297 3de7aabb .config console log report syz ci-upstream-kasan-gce-smack-root
2020/01/18 22:01 upstream 25e73aadf297 3de7aabb .config console log report syz ci-upstream-kasan-gce-386
2020/01/19 03:35 net-old e02d9c4c68dc bc8bc756 .config console log report syz ci-upstream-net-this-kasan-gce
2020/01/18 14:01 net-next-old 56f200c78ce4 3de7aabb .config console log report syz ci-upstream-net-kasan-gce
2020/01/29 07:19 linux-next 2747d5fdab78 c8e81ce4 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2020/01/22 18:29 upstream d96d875ef5dd 8eda0b95 .config console log report ci-upstream-kasan-gce-selinux-root
2020/01/22 23:06 upstream dbab40bdb42c 3334d684 .config console log report ci-upstream-kasan-gce-386
* Struck through repros no longer work on HEAD.