syzbot


possible deadlock in filemap_fault (2)

Status: upstream: reported on 2023/12/22 21:26
Reported-by: syzbot+b114e607666a3a11a128@syzkaller.appspotmail.com
First crash: 412d, last: 3d03h
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in filemap_fault 84 517d 692d 0/3 auto-obsoleted due to no activity on 2023/11/17 20:19
upstream possible deadlock in filemap_fault mm C done 2530 1d14h 826d 0/28 upstream: reported C repro on 2022/11/03 22:14
linux-6.1 possible deadlock in filemap_fault 192 519d 694d 0/3 auto-obsoleted due to no activity on 2023/11/15 23:38
linux-5.15 possible deadlock in filemap_fault (2) origin:upstream missing-backport C error 40 32d 307d 0/3 upstream: reported C repro on 2024/04/06 04:54

Sample crash report:
loop5: detected capacity change from 0 to 4096
======================================================
WARNING: possible circular locking dependency detected
6.1.128-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.3889/21561 is trying to acquire lock:
ffff88805087d660 (mapping.invalidate_lock#15){++++}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
ffff88805087d660 (mapping.invalidate_lock#15){++++}-{3:3}, at: filemap_fault+0x640/0x17e0 mm/filemap.c:3219

but task is already holding lock:
ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: get_mmap_lock_carefully mm/memory.c:5320 [inline]
ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: lock_mm_and_find_vma+0x2e/0x2e0 mm/memory.c:5382

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __might_fault+0xbd/0x110 mm/memory.c:5851
       _copy_to_user+0x26/0x130 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       ni_fiemap+0x1672/0x18a0 fs/ntfs3/frecord.c:2140
       ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1254
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ni->ni_lock/5){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline]
       ntfs_fallocate+0x539/0x1020 fs/ntfs3/file.c:598
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (mapping.invalidate_lock#15){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
       filemap_fault+0x640/0x17e0 mm/filemap.c:3219
       __do_fault+0x136/0x4f0 mm/memory.c:4278
       do_read_fault mm/memory.c:4629 [inline]
       do_fault mm/memory.c:4758 [inline]
       handle_pte_fault mm/memory.c:5029 [inline]
       __handle_mm_fault mm/memory.c:5171 [inline]
       handle_mm_fault+0x3410/0x5340 mm/memory.c:5292
       do_user_addr_fault arch/x86/mm/fault.c:1340 [inline]
       handle_page_fault arch/x86/mm/fault.c:1431 [inline]
       exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:608
       fault_in_readable+0x1c8/0x340
       fault_in_iov_iter_readable+0xdb/0x270 lib/iov_iter.c:356
       generic_perform_write+0x207/0x5e0 mm/filemap.c:3835
       __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
       ntfs_file_write_iter+0x5fa/0x6d0 fs/ntfs3/file.c:1165
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x857/0xbc0 fs/read_write.c:584
       ksys_write+0x19c/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  mapping.invalidate_lock#15 --> &ni->ni_lock/5 --> &mm->mmap_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&ni->ni_lock/5);
                               lock(&mm->mmap_lock);
  lock(mapping.invalidate_lock#15);

 *** DEADLOCK ***

4 locks held by syz.5.3889/21561:
 #0: ffff88801ee899e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ba/0x360 fs/file.c:1032
 #1: ffff888054404460 (sb_writers#26){.+.+}-{0:0}, at: vfs_write+0x269/0xbc0 fs/read_write.c:580
 #2: ffff88805087e380 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:778 [inline]
 #2: ffff88805087e380 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: ntfs_file_write_iter+0x1c7/0x6d0 fs/ntfs3/file.c:1144
 #3: ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
 #3: ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: get_mmap_lock_carefully mm/memory.c:5320 [inline]
 #3: ffff88802964e2d8 (&mm->mmap_lock){++++}-{3:3}, at: lock_mm_and_find_vma+0x2e/0x2e0 mm/memory.c:5382

stack backtrace:
CPU: 1 PID: 21561 Comm: syz.5.3889 Not tainted 6.1.128-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
 filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
 filemap_fault+0x640/0x17e0 mm/filemap.c:3219
 __do_fault+0x136/0x4f0 mm/memory.c:4278
 do_read_fault mm/memory.c:4629 [inline]
 do_fault mm/memory.c:4758 [inline]
 handle_pte_fault mm/memory.c:5029 [inline]
 __handle_mm_fault mm/memory.c:5171 [inline]
 handle_mm_fault+0x3410/0x5340 mm/memory.c:5292
 do_user_addr_fault arch/x86/mm/fault.c:1340 [inline]
 handle_page_fault arch/x86/mm/fault.c:1431 [inline]
 exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487
 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:608
RIP: 0010:fault_in_readable+0x1c8/0x340 mm/gup.c:1898
Code: 24 08 4c 8d b0 ff 0f 00 00 48 89 c3 4d 01 e6 49 81 e6 00 f0 ff ff 49 39 c6 72 70 e8 e2 a8 bf ff 4c 39 f3 74 73 4c 89 64 24 10 <44> 8a 23 43 0f b6 04 2f 84 c0 75 18 44 88 64 24 40 48 81 c3 00 10
RSP: 0018:ffffc900034479a0 EFLAGS: 00050287
RAX: ffffffff81caf3be RBX: 0000000020008000 RCX: 0000000000080000
RDX: ffffc9000cd6a000 RSI: 000000000000d448 RDI: 000000000000d449
RBP: ffffc90003447a58 R08: ffffffff81caf356 R09: ffffffff84422ce5
R10: 0000000000000002 R11: ffff88807a979dc0 R12: 0000000000001000
R13: dffffc0000000000 R14: 0000000020009000 R15: 1ffff92000688f3c
 fault_in_iov_iter_readable+0xdb/0x270 lib/iov_iter.c:356
 generic_perform_write+0x207/0x5e0 mm/filemap.c:3835
 __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
 ntfs_file_write_iter+0x5fa/0x6d0 fs/ntfs3/file.c:1165
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x857/0xbc0 fs/read_write.c:584
 ksys_write+0x19c/0x2c0 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f8e5038cda9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8e51175038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f8e505a5fa0 RCX: 00007f8e5038cda9
RDX: 000000000000fecc RSI: 0000000020000100 RDI: 0000000000000005
RBP: 00007f8e5040e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f8e505a5fa0 R15: 00007ffd8e96f0d8
 </TASK>
----------------
Code disassembly (best guess):
   0:	24 08                	and    $0x8,%al
   2:	4c 8d b0 ff 0f 00 00 	lea    0xfff(%rax),%r14
   9:	48 89 c3             	mov    %rax,%rbx
   c:	4d 01 e6             	add    %r12,%r14
   f:	49 81 e6 00 f0 ff ff 	and    $0xfffffffffffff000,%r14
  16:	49 39 c6             	cmp    %rax,%r14
  19:	72 70                	jb     0x8b
  1b:	e8 e2 a8 bf ff       	call   0xffbfa902
  20:	4c 39 f3             	cmp    %r14,%rbx
  23:	74 73                	je     0x98
  25:	4c 89 64 24 10       	mov    %r12,0x10(%rsp)
* 2a:	44 8a 23             	mov    (%rbx),%r12b <-- trapping instruction
  2d:	43 0f b6 04 2f       	movzbl (%r15,%r13,1),%eax
  32:	84 c0                	test   %al,%al
  34:	75 18                	jne    0x4e
  36:	44 88 64 24 40       	mov    %r12b,0x40(%rsp)
  3b:	48                   	rex.W
  3c:	81                   	.byte 0x81
  3d:	c3                   	ret
  3e:	00 10                	add    %dl,(%rax)

Crashes (98):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/02/04 06:11 linux-6.1.y 0cbb5f65e52f 8f267cef .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/30 17:18 linux-6.1.y 75cefdf153f5 4c6ac32f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/27 23:54 linux-6.1.y 75cefdf153f5 18070896 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/27 12:03 linux-6.1.y 75cefdf153f5 d99a33ad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/22 16:57 linux-6.1.y f4f677285b38 a44b0418 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/14 20:54 linux-6.1.y c63962be84ef f310a27d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/11 23:28 linux-6.1.y c63962be84ef 6dbc6a9b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/02 19:14 linux-6.1.y 7dc732d24ff7 d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/01/01 03:27 linux-6.1.y 563edd786f0a d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/12/31 10:09 linux-6.1.y 563edd786f0a d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/12/30 20:50 linux-6.1.y 563edd786f0a d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/11/07 15:25 linux-6.1.y 7c15117f9468 867e44df .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/10/23 01:10 linux-6.1.y 7ec6f9fa3d97 15fa2979 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/10/03 17:05 linux-6.1.y aa4cd140bba5 d7906eff .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/09/27 20:00 linux-6.1.y e526b12bf916 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/07/06 13:17 linux-6.1.y 7753af06eebf 2a40360c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/07/02 11:29 linux-6.1.y 99e6a620de00 07f0a0a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/17 06:36 linux-6.1.y eb44d83053d6 f429ab00 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/17 00:03 linux-6.1.y eb44d83053d6 f429ab00 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/15 02:10 linux-6.1.y ae9f2a70d69e f429ab00 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/14 10:47 linux-6.1.y ae9f2a70d69e 8d849073 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/13 02:41 linux-6.1.y ae9f2a70d69e 2aa5052f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/07 23:10 linux-6.1.y 88690811da69 82c05ab8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2024/06/07 23:10 linux-6.1.y 88690811da69 82c05ab8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2023/12/22 21:26 linux-6.1.y 4aa6747d9352 fb427a07 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2025/02/03 05:27 linux-6.1.y 0cbb5f65e52f 568559e4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2025/01/11 16:45 linux-6.1.y c63962be84ef 6dbc6a9b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2025/01/08 17:44 linux-6.1.y 7dc732d24ff7 f3558dbf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2025/01/08 05:35 linux-6.1.y 7dc732d24ff7 f3558dbf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2025/01/07 04:45 linux-6.1.y 7dc732d24ff7 f3558dbf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/12/04 21:44 linux-6.1.y e4d90d63d385 b50eb251 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/12/01 03:42 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/11/11 08:39 linux-6.1.y d7039b844a1c 6b856513 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/11/08 20:23 linux-6.1.y d7039b844a1c 6b856513 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/10/27 03:56 linux-6.1.y 7ec6f9fa3d97 65e8686b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/10/25 17:18 linux-6.1.y 7ec6f9fa3d97 045e728d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/10/24 15:05 linux-6.1.y 7ec6f9fa3d97 0d144d1a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/10/10 20:48 linux-6.1.y aa4cd140bba5 8fbfc0c8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/09/11 01:29 linux-6.1.y 5ca5b389fddf 86aa7bd7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/09/10 06:58 linux-6.1.y 5ca5b389fddf 784df80e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/08/26 16:37 linux-6.1.y ee5e09825b81 9aee4e0b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/08/19 20:03 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/08/14 23:35 linux-6.1.y 117ac406ba90 e6b88e20 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/08/07 00:36 linux-6.1.y 48d525b0e463 1ef9fe42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/07/05 17:22 linux-6.1.y 7753af06eebf 2a40360c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/07/04 10:35 linux-6.1.y 99e6a620de00 3f2748a3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/07/04 02:32 linux-6.1.y 99e6a620de00 f76a75f3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/06/28 16:37 linux-6.1.y 99e6a620de00 757f06b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2024/06/17 10:47 linux-6.1.y eb44d83053d6 1f11cfd7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
* Struck through repros no longer work on HEAD.