syzbot

ntfs3: loop2: ntfs_extend_mft r=0 failed, -22.
======================================================
WARNING: possible circular locking dependency detected
5.15.131-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.2/5112 is trying to acquire lock:
ffff00011ee10540 (mapping.invalidate_lock#6){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
ffff00011ee10540 (mapping.invalidate_lock#6){.+.+}-{3:3}, at: filemap_fault+0x52c/0xf5c mm/filemap.c:3072

but task is already holding lock:
ffff0000d2a5a958 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
ffff0000d2a5a958 (&mm->mmap_lock){++++}-{3:3}, at: __mm_populate+0x19c/0x41c mm/gup.c:1618

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault+0xc8/0x128 mm/memory.c:5324
       _copy_to_user include/linux/uaccess.h:174 [inline]
       copy_to_user include/linux/uaccess.h:200 [inline]
       fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144
       ni_fiemap+0x7dc/0xe10 fs/ntfs3/frecord.c:2017
       ntfs_fiemap+0x110/0x168 fs/ntfs3/file.c:1225
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
       __do_sys_ioctl fs/ioctl.c:872 [inline]
       __se_sys_ioctl fs/ioctl.c:860 [inline]
       __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #2 (&indx->run_lock){.+.+}-{3:3}:
       down_read+0xc0/0x398 kernel/locking/rwsem.c:1488
       ni_fiemap+0x2c4/0xe10 fs/ntfs3/frecord.c:1913
       ntfs_fiemap+0x110/0x168 fs/ntfs3/file.c:1225
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
       __do_sys_ioctl fs/ioctl.c:872 [inline]
       __se_sys_ioctl fs/ioctl.c:860 [inline]
       __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&ni->ni_lock/4){+.+.}-{3:3}:
       __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
       ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline]
       ntfs_readpage+0x140/0x1c0 fs/ntfs3/inode.c:724
       filemap_read_page+0x150/0x454 mm/filemap.c:2386
       filemap_fault+0xac4/0xf5c mm/filemap.c:3165
       __do_fault+0x120/0x5d0 mm/memory.c:3898
       do_read_fault mm/memory.c:4234 [inline]
       do_fault mm/memory.c:4362 [inline]
       handle_pte_fault mm/memory.c:4621 [inline]
       __handle_mm_fault mm/memory.c:4756 [inline]
       handle_mm_fault+0x21ec/0x33c4 mm/memory.c:4854
       faultin_page mm/gup.c:976 [inline]
       __get_user_pages+0x39c/0x92c mm/gup.c:1197
       populate_vma_page_range+0x200/0x290 mm/gup.c:1529
       __mm_populate+0x278/0x41c mm/gup.c:1638
       mm_populate include/linux/mm.h:2632 [inline]
       vm_mmap_pgoff+0x1fc/0x2b4 mm/util.c:556
       ksys_mmap_pgoff+0x458/0x668 mm/mmap.c:1624
       __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
       __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
       __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (mapping.invalidate_lock#6){.+.+}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3787 [inline]
       __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
       lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
       down_read+0xc0/0x398 kernel/locking/rwsem.c:1488
       filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
       filemap_fault+0x52c/0xf5c mm/filemap.c:3072
       __do_fault+0x120/0x5d0 mm/memory.c:3898
       do_read_fault mm/memory.c:4234 [inline]
       do_fault mm/memory.c:4362 [inline]
       handle_pte_fault mm/memory.c:4621 [inline]
       __handle_mm_fault mm/memory.c:4756 [inline]
       handle_mm_fault+0x21ec/0x33c4 mm/memory.c:4854
       faultin_page mm/gup.c:976 [inline]
       __get_user_pages+0x39c/0x92c mm/gup.c:1197
       populate_vma_page_range+0x200/0x290 mm/gup.c:1529
       __mm_populate+0x278/0x41c mm/gup.c:1638
       mm_populate include/linux/mm.h:2632 [inline]
       vm_mmap_pgoff+0x1fc/0x2b4 mm/util.c:556
       ksys_mmap_pgoff+0x458/0x668 mm/mmap.c:1624
       __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
       __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
       __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
  mapping.invalidate_lock#6 --> &indx->run_lock --> &mm->mmap_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&indx->run_lock);
                               lock(&mm->mmap_lock);
  lock(mapping.invalidate_lock#6);

 *** DEADLOCK ***

1 lock held by syz-executor.2/5112:
 #0: ffff0000d2a5a958 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
 #0: ffff0000d2a5a958 (&mm->mmap_lock){++++}-{3:3}, at: __mm_populate+0x19c/0x41c mm/gup.c:1618

stack backtrace:
CPU: 0 PID: 5112 Comm: syz-executor.2 Not tainted 5.15.131-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call trace:
 dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3787 [inline]
 __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
 down_read+0xc0/0x398 kernel/locking/rwsem.c:1488
 filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
 filemap_fault+0x52c/0xf5c mm/filemap.c:3072
 __do_fault+0x120/0x5d0 mm/memory.c:3898
 do_read_fault mm/memory.c:4234 [inline]
 do_fault mm/memory.c:4362 [inline]
 handle_pte_fault mm/memory.c:4621 [inline]
 __handle_mm_fault mm/memory.c:4756 [inline]
 handle_mm_fault+0x21ec/0x33c4 mm/memory.c:4854
 faultin_page mm/gup.c:976 [inline]
 __get_user_pages+0x39c/0x92c mm/gup.c:1197
 populate_vma_page_range+0x200/0x290 mm/gup.c:1529
 __mm_populate+0x278/0x41c mm/gup.c:1638
 mm_populate include/linux/mm.h:2632 [inline]
 vm_mmap_pgoff+0x1fc/0x2b4 mm/util.c:556
 ksys_mmap_pgoff+0x458/0x668 mm/mmap.c:1624
 __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
 __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
 __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584