syzbot


possible deadlock in filemap_fault

Status: upstream: reported on 2023/03/17 21:43
Reported-by: syzbot+aba27cc188c6daf25aa8@syzkaller.appspotmail.com
First crash: 80d, last: 4d06h
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in filemap_fault fat C 288 49m 214d 0/24 upstream: reported C repro on 2022/11/03 22:14
linux-6.1 possible deadlock in filemap_fault 118 4d07h 82d 0/3 upstream: reported on 2023/03/15 12:26

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.15.110-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/10335 is trying to acquire lock:
ffff888075fc22c0 (mapping.invalidate_lock#11){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
ffff888075fc22c0 (mapping.invalidate_lock#11){.+.+}-{3:3}, at: filemap_fault+0x708/0x1470 mm/filemap.c:3072

but task is already holding lock:
ffff888076aee328 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
ffff888076aee328 (&mm->mmap_lock#2){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1338 [inline]
ffff888076aee328 (&mm->mmap_lock#2){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1485 [inline]
ffff888076aee328 (&mm->mmap_lock#2){++++}-{3:3}, at: exc_page_fault+0x181/0x740 arch/x86/mm/fault.c:1541

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&mm->mmap_lock#2){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __might_fault+0xb4/0x110 mm/memory.c:5311
       _copy_to_user+0x28/0x130 lib/usercopy.c:35
       copy_to_user include/linux/uaccess.h:200 [inline]
       fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144
       ni_fiemap+0x9ae/0x1230 fs/ntfs3/frecord.c:1990
       ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1225
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x1934/0x2b70 fs/ioctl.c:814
       __do_sys_ioctl fs/ioctl.c:872 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&ni->file.run_lock){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
       attr_data_get_block+0x26a/0x24e0 fs/ntfs3/attrib.c:828
       ntfs_get_block_vbo+0x3bc/0x1070 fs/ntfs3/inode.c:580
       do_mpage_readpage+0x6c8/0x1f70 fs/mpage.c:231
       mpage_readahead+0x427/0x9b0 fs/mpage.c:389
       read_pages+0x159/0x8e0 mm/readahead.c:130
       page_cache_ra_unbounded+0x7b0/0x930 mm/readahead.c:239
       page_cache_sync_readahead include/linux/pagemap.h:833 [inline]
       filemap_get_pages mm/filemap.c:2551 [inline]
       filemap_read+0x71c/0x2980 mm/filemap.c:2634
       __kernel_read+0x5ac/0xa60 fs/read_write.c:443
       integrity_kernel_read+0xac/0xf0 security/integrity/iint.c:199
       ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline]
       ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
       ima_calc_file_hash+0xa5d/0x1c00 security/integrity/ima/ima_crypto.c:573
       ima_collect_measurement+0x293/0x530 security/integrity/ima/ima_api.c:254
       process_measurement+0x1038/0x1d60 security/integrity/ima/ima_main.c:337
       ima_file_check+0xf3/0x180 security/integrity/ima/ima_main.c:519
       do_open fs/namei.c:3540 [inline]
       path_openat+0x2745/0x2f20 fs/namei.c:3672
       do_filp_open+0x21c/0x460 fs/namei.c:3699
       do_sys_openat2+0x13b/0x500 fs/open.c:1211
       do_sys_open fs/open.c:1227 [inline]
       __do_sys_open fs/open.c:1235 [inline]
       __se_sys_open fs/open.c:1231 [inline]
       __x64_sys_open+0x221/0x270 fs/open.c:1231
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (mapping.invalidate_lock#11){.+.+}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
       filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
       filemap_fault+0x708/0x1470 mm/filemap.c:3072
       __do_fault+0x139/0x340 mm/memory.c:3885
       do_read_fault mm/memory.c:4221 [inline]
       do_fault mm/memory.c:4349 [inline]
       handle_pte_fault mm/memory.c:4608 [inline]
       __handle_mm_fault mm/memory.c:4743 [inline]
       handle_mm_fault+0x376f/0x5950 mm/memory.c:4841
       do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
       handle_page_fault arch/x86/mm/fault.c:1485 [inline]
       exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
       strncpy_from_user+0x170/0x370 lib/strncpy_from_user.c:139
       getname_flags+0xf5/0x4e0 fs/namei.c:149
       do_sys_openat2+0xd2/0x500 fs/open.c:1205
       do_sys_open fs/open.c:1227 [inline]
       __do_sys_open fs/open.c:1235 [inline]
       __se_sys_open fs/open.c:1231 [inline]
       __x64_sys_open+0x221/0x270 fs/open.c:1231
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
  mapping.invalidate_lock#11 --> &ni->file.run_lock --> &mm->mmap_lock#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock#2);
                               lock(&ni->file.run_lock);
                               lock(&mm->mmap_lock#2);
  lock(mapping.invalidate_lock#11);

 *** DEADLOCK ***

1 lock held by syz-executor.5/10335:
 #0: ffff888076aee328 (&mm->mmap_lock#2
){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1338 [inline]
){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1485 [inline]
){++++}-{3:3}, at: exc_page_fault+0x181/0x740 arch/x86/mm/fault.c:1541

stack backtrace:
CPU: 1 PID: 10335 Comm: syz-executor.5 Not tainted 5.15.110-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
 filemap_invalidate_lock_shared include/linux/fs.h:842 [inline]
 filemap_fault+0x708/0x1470 mm/filemap.c:3072
 __do_fault+0x139/0x340 mm/memory.c:3885
 do_read_fault mm/memory.c:4221 [inline]
 do_fault mm/memory.c:4349 [inline]
 handle_pte_fault mm/memory.c:4608 [inline]
 __handle_mm_fault mm/memory.c:4743 [inline]
 handle_mm_fault+0x376f/0x5950 mm/memory.c:4841
 do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
 handle_page_fault arch/x86/mm/fault.c:1485 [inline]
 exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
RIP: 0010:do_strncpy_from_user lib/strncpy_from_user.c:41 [inline]
RIP: 0010:strncpy_from_user+0x170/0x370 lib/strncpy_from_user.c:139
Code: 4c 89 ee e8 b2 b5 58 fd 49 83 fd 07 0f 86 a2 00 00 00 4c 89 7c 24 08 48 c7 44 24 10 f8 ff ff ff 45 31 e4 4c 89 f5 48 8b 04 24 <4e> 8b 3c 20 48 b8 ff fe fe fe fe fe fe fe 49 8d 1c 07 4d 89 fe 49
RSP: 0018:ffffc90004dbfc98 EFLAGS: 00050246
RAX: 0000000020000000 RBX: 00007ffffffff000 RCX: ffff8880165b1d00
RDX: ffffc900062f1000 RSI: 0000000000000fe0 RDI: 0000000000000007
RBP: ffff88803b3d0020 R08: ffffffff84272cae R09: 0000000000001000
R10: ffff888011dc6500 R11: dffffc0000000001 R12: 0000000000000000
R13: 0000000000000fe0 R14: ffff88803b3d0020 R15: 0000000000000fe0
 getname_flags+0xf5/0x4e0 fs/namei.c:149
 do_sys_openat2+0xd2/0x500 fs/open.c:1205
 do_sys_open fs/open.c:1227 [inline]
 __do_sys_open fs/open.c:1235 [inline]
 __se_sys_open fs/open.c:1231 [inline]
 __x64_sys_open+0x221/0x270 fs/open.c:1231
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fd5fabc6169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd5f9138168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007fd5face5f80 RCX: 00007fd5fabc6169
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000000
RBP: 00007fd5fac21ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd599dd93f R14: 00007fd5f9138300 R15: 0000000000022000
 </TASK>
----------------
Code disassembly (best guess):
   0:	4c 89 ee             	mov    %r13,%rsi
   3:	e8 b2 b5 58 fd       	callq  0xfd58b5ba
   8:	49 83 fd 07          	cmp    $0x7,%r13
   c:	0f 86 a2 00 00 00    	jbe    0xb4
  12:	4c 89 7c 24 08       	mov    %r15,0x8(%rsp)
  17:	48 c7 44 24 10 f8 ff 	movq   $0xfffffffffffffff8,0x10(%rsp)
  1e:	ff ff
  20:	45 31 e4             	xor    %r12d,%r12d
  23:	4c 89 f5             	mov    %r14,%rbp
  26:	48 8b 04 24          	mov    (%rsp),%rax
* 2a:	4e 8b 3c 20          	mov    (%rax,%r12,1),%r15 <-- trapping instruction
  2e:	48 b8 ff fe fe fe fe 	movabs $0xfefefefefefefeff,%rax
  35:	fe fe fe
  38:	49 8d 1c 07          	lea    (%r15,%rax,1),%rbx
  3c:	4d 89 fe             	mov    %r15,%r14
  3f:	49                   	rex.WB

Crashes (39):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/05/09 07:35 linux-5.15.y 8a7f2a5c5aa1 c7a5e2a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in filemap_fault
2023/04/13 20:37 linux-5.15.y 4fdad925aa1a 3cfcaa1b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in filemap_fault
2023/04/03 07:42 linux-5.15.y c957cbb87315 41147e3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in filemap_fault
2023/03/29 00:33 linux-5.15.y 115472395b0a fc067f05 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in filemap_fault
2023/03/28 23:21 linux-5.15.y 115472395b0a fc067f05 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in filemap_fault
2023/06/02 04:18 linux-5.15.y 0ab06468cbd1 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/06/01 01:57 linux-5.15.y 0ab06468cbd1 babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/20 18:48 linux-5.15.y 9d6bde853685 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/15 15:29 linux-5.15.y b0ece631f84a c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/15 12:29 linux-5.15.y b0ece631f84a c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/10 16:25 linux-5.15.y 8a7f2a5c5aa1 14b12a99 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/10 12:13 linux-5.15.y 8a7f2a5c5aa1 14b12a99 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/06 18:26 linux-5.15.y 8a7f2a5c5aa1 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/05 21:22 linux-5.15.y 8a7f2a5c5aa1 de870ca5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 21:26 linux-5.15.y 8a7f2a5c5aa1 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/03 20:20 linux-5.15.y 8a7f2a5c5aa1 b5918830 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/02 19:31 linux-5.15.y 8a7f2a5c5aa1 52d40fd2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/01 12:51 linux-5.15.y 8a7f2a5c5aa1 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/05/01 12:17 linux-5.15.y 8a7f2a5c5aa1 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/28 22:05 linux-5.15.y f48aeeaaa64c 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/27 03:29 linux-5.15.y f48aeeaaa64c 19a3dabe .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/25 19:55 linux-5.15.y 3299fb36854f 65320f8e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/20 20:09 linux-5.15.y 3299fb36854f a219f34e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/18 02:03 linux-5.15.y 4fdad925aa1a 436577a9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/14 18:52 linux-5.15.y 4fdad925aa1a ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/14 17:19 linux-5.15.y 4fdad925aa1a ec410564 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/12 13:38 linux-5.15.y d86dfc4d95cd 1a1596b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/11 23:12 linux-5.15.y d86dfc4d95cd 49faf98d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/11 21:37 linux-5.15.y d86dfc4d95cd 49faf98d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/11 21:04 linux-5.15.y d86dfc4d95cd 49faf98d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/10 15:02 linux-5.15.y d86dfc4d95cd 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/10 10:31 linux-5.15.y d86dfc4d95cd 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/08 04:02 linux-5.15.y d86dfc4d95cd 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/05 19:14 linux-5.15.y d86dfc4d95cd 8b834965 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/05 04:59 linux-5.15.y c957cbb87315 831373d3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/04/03 15:36 linux-5.15.y c957cbb87315 41147e3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/03/28 22:49 linux-5.15.y 115472395b0a fc067f05 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/03/25 16:12 linux-5.15.y 115472395b0a fbf0499a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
2023/03/17 21:43 linux-5.15.y 8020ae3c051d 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in filemap_fault
* Struck through repros no longer work on HEAD.