syzbot


possible deadlock in filemap_fault

Status: upstream: reported on 2023/03/15 12:26
Reported-by: syzbot+d1bf1daf6d329faeae18@syzkaller.appspotmail.com
First crash: 78d, last: 11h54m
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in filemap_fault 38 11h28m 75d 0/3 upstream: reported on 2023/03/17 21:43
upstream possible deadlock in filemap_fault fat C 283 16h47m 209d 0/24 upstream: reported C repro on 2022/11/03 22:14

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.27-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/11630 is trying to acquire lock:
ffff888047eeaa20 (mapping.invalidate_lock#7){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
ffff888047eeaa20 (mapping.invalidate_lock#7){.+.+}-{3:3}, at: filemap_fault+0x640/0x17e0 mm/filemap.c:3128

but task is already holding lock:
ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1369 [inline]
ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1519 [inline]
ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: exc_page_fault+0x182/0x790 arch/x86/mm/fault.c:1575

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&mm->mmap_lock#2){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
       __might_fault+0xb2/0x110 mm/memory.c:5655
       _copy_to_user+0x26/0x130 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144
       ni_fiemap+0x9ae/0x1230 fs/ntfs3/frecord.c:2039
       ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1245
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&ni->file.run_lock#3){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
       down_read+0x39/0x50 kernel/locking/rwsem.c:1520
       attr_data_get_block+0x276/0x2520 fs/ntfs3/attrib.c:903
       ntfs_get_block_vbo+0x373/0xe60 fs/ntfs3/inode.c:580
       do_mpage_readpage+0x8d2/0x2040 fs/mpage.c:208
       mpage_readahead+0x450/0x920 fs/mpage.c:361
       read_pages+0x17f/0x830 mm/readahead.c:161
       page_cache_ra_unbounded+0x68b/0x7b0 mm/readahead.c:270
       filemap_readahead mm/filemap.c:2557 [inline]
       filemap_get_pages mm/filemap.c:2598 [inline]
       filemap_read+0xaad/0x31d0 mm/filemap.c:2676
       call_read_iter include/linux/fs.h:2199 [inline]
       generic_file_splice_read+0x23c/0x630 fs/splice.c:309
       do_splice_to fs/splice.c:793 [inline]
       splice_direct_to_actor+0x408/0xbd0 fs/splice.c:865
       do_splice_direct+0x27f/0x3c0 fs/splice.c:974
       do_sendfile+0x61c/0xff0 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (mapping.invalidate_lock#7){.+.+}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
       down_read+0x39/0x50 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
       filemap_fault+0x640/0x17e0 mm/filemap.c:3128
       __do_fault+0x136/0x4f0 mm/memory.c:4212
       do_shared_fault mm/memory.c:4618 [inline]
       do_fault mm/memory.c:4696 [inline]
       handle_pte_fault mm/memory.c:4964 [inline]
       __handle_mm_fault mm/memory.c:5106 [inline]
       handle_mm_fault+0x2240/0x5330 mm/memory.c:5227
       do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
       handle_page_fault arch/x86/mm/fault.c:1519 [inline]
       exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570

other info that might help us debug this:

Chain exists of:
  mapping.invalidate_lock#7 --> &ni->file.run_lock#3 --> &mm->mmap_lock#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock#2);
                               lock(&ni->file.run_lock#3);
                               lock(&mm->mmap_lock#2);
  lock(mapping.invalidate_lock#7);

 *** DEADLOCK ***

1 lock held by syz-executor.0/11630:
 #0: ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
 #0: ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1369 [inline]
 #0: ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1519 [inline]
 #0: ffff88807837ae58 (&mm->mmap_lock#2){++++}-{3:3}, at: exc_page_fault+0x182/0x790 arch/x86/mm/fault.c:1575

stack backtrace:
CPU: 0 PID: 11630 Comm: syz-executor.0 Not tainted 6.1.27-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
 down_read+0x39/0x50 kernel/locking/rwsem.c:1520
 filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
 filemap_fault+0x640/0x17e0 mm/filemap.c:3128
 __do_fault+0x136/0x4f0 mm/memory.c:4212
 do_shared_fault mm/memory.c:4618 [inline]
 do_fault mm/memory.c:4696 [inline]
 handle_pte_fault mm/memory.c:4964 [inline]
 __handle_mm_fault mm/memory.c:5106 [inline]
 handle_mm_fault+0x2240/0x5330 mm/memory.c:5227
 do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
 handle_page_fault arch/x86/mm/fault.c:1519 [inline]
 exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
RIP: 0033:0x7fc65042bde9
Code: 48 8b 04 24 48 85 c0 74 17 48 8b 54 24 18 48 0f ca 48 89 54 24 18 48 83 f8 01 0f 85 9b 02 00 00 48 8b 44 24 10 48 8b 54 24 18 <48> 89 10 e9 c2 fd ff ff 48 8b 44 24 10 0f b7 10 48 8b 04 24 48 85
RSP: 002b:00007ffe2070ba80 EFLAGS: 00010246
RAX: 0000000020000400 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000020000040 RSI: 0000000000000000 RDI: 0000555556ac12e8
RBP: 00007ffe2070bb78 R08: 0000000000000000 R09: 0000000000000000
R10: 00007fc65001fe60 R11: 0000000000054086 R12: 00000000001a71ed
R13: 00007ffe2070bba0 R14: 00007ffe2070bbc0 R15: 0000000000000032
 </TASK>

Crashes (115):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/05/02 22:33 linux-6.1.y ca48fc16c493 48e0a81d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in filemap_fault
2023/06/01 01:30 linux-6.1.y d2869ace6eeb babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/31 22:14 linux-6.1.y d2869ace6eeb babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/31 10:09 linux-6.1.y d2869ace6eeb 09898419 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/31 07:04 linux-6.1.y d2869ace6eeb 09898419 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/30 23:10 linux-6.1.y d2869ace6eeb df37c7f1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/30 20:38 linux-6.1.y d2869ace6eeb df37c7f1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/26 23:48 linux-6.1.y a343b0dd87b4 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/26 11:16 linux-6.1.y a343b0dd87b4 b40ef614 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/24 16:57 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/22 05:08 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/20 13:48 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/19 16:43 linux-6.1.y fa74641fb6b9 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/18 02:50 linux-6.1.y fa74641fb6b9 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/18 01:32 linux-6.1.y fa74641fb6b9 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/18 00:24 linux-6.1.y fa74641fb6b9 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/17 17:26 linux-6.1.y fa74641fb6b9 eaac4681 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/17 10:18 linux-6.1.y bf4ad6fa4e53 eaac4681 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/16 17:36 linux-6.1.y bf4ad6fa4e53 11c89444 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/16 05:28 linux-6.1.y bf4ad6fa4e53 71b00cfb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/15 14:52 linux-6.1.y bf4ad6fa4e53 c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/15 13:41 linux-6.1.y bf4ad6fa4e53 c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/13 10:34 linux-6.1.y bf4ad6fa4e53 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/13 08:47 linux-6.1.y bf4ad6fa4e53 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/12 13:34 linux-6.1.y bf4ad6fa4e53 ecca8a24 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/12 03:07 linux-6.1.y bf4ad6fa4e53 adb9a3cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/10 13:30 linux-6.1.y ca48fc16c493 14b12a99 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/09 13:07 linux-6.1.y ca48fc16c493 30aa2a7e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/09 00:28 linux-6.1.y ca48fc16c493 c7a5e2a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/06 17:45 linux-6.1.y ca48fc16c493 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/06 15:42 linux-6.1.y ca48fc16c493 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/05 22:49 linux-6.1.y ca48fc16c493 de870ca5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/05 16:01 linux-6.1.y ca48fc16c493 de870ca5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 20:43 linux-6.1.y ca48fc16c493 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 19:08 linux-6.1.y ca48fc16c493 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 17:11 linux-6.1.y ca48fc16c493 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 15:59 linux-6.1.y ca48fc16c493 518a39a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/04 06:04 linux-6.1.y ca48fc16c493 5b7ff9dd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/03 18:09 linux-6.1.y ca48fc16c493 b5918830 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/03 03:07 linux-6.1.y ca48fc16c493 48e0a81d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/02 16:36 linux-6.1.y ca48fc16c493 52d40fd2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/02 15:23 linux-6.1.y ca48fc16c493 52d40fd2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/05/01 02:16 linux-6.1.y ca48fc16c493 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/04/29 00:15 linux-6.1.y ca1c9012c941 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/04/28 10:45 linux-6.1.y ca1c9012c941 70a605de .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/04/28 09:32 linux-6.1.y ca1c9012c941 70a605de .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/04/26 19:55 linux-6.1.y ca1c9012c941 8d843721 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
2023/03/15 12:25 linux-6.1.y 6449a0ba6843 18b58603 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in filemap_fault
* Struck through repros no longer work on HEAD.