syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.52-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/8315 is trying to acquire lock:
ffff0000e22dfb40 (mapping.invalidate_lock#4){++++}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
ffff0000e22dfb40 (mapping.invalidate_lock#4){++++}-{3:3}, at: filemap_fault+0x58c/0xf7c mm/filemap.c:3128

but task is already holding lock:
ffff0000d5cf0748 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
ffff0000d5cf0748 (&mm->mmap_lock){++++}-{3:3}, at: __mm_populate+0x190/0x3d8 mm/gup.c:1683

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault+0xc4/0x124 mm/memory.c:5801
       _copy_to_user include/linux/uaccess.h:143 [inline]
       copy_to_user include/linux/uaccess.h:169 [inline]
       fiemap_fill_next_extent+0x1b4/0x424 fs/ioctl.c:144
       ni_fiemap+0x744/0xe10 fs/ntfs3/frecord.c:2045
       ntfs_fiemap+0x110/0x168 fs/ntfs3/file.c:1245
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x194c/0x26f8 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #2 (&ni->file.run_lock){.+.+}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ni_fiemap+0x2c4/0xe10 fs/ntfs3/frecord.c:1962
       ntfs_fiemap+0x110/0x168 fs/ntfs3/file.c:1245
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x194c/0x26f8 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #1 (&ni->ni_lock/4){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline]
       ntfs_fallocate+0x48c/0xd88 fs/ntfs3/file.c:601
       vfs_fallocate+0x478/0x5b4 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __arm64_sys_fallocate+0xc0/0x110 fs/open.c:352
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #0 (mapping.invalidate_lock#4){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3824 [inline]
       __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5048
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5661
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
       filemap_fault+0x58c/0xf7c mm/filemap.c:3128
       __do_fault+0x11c/0x3d8 mm/memory.c:4231
       do_read_fault mm/memory.c:4582 [inline]
       do_fault mm/memory.c:4711 [inline]
       handle_pte_fault mm/memory.c:4983 [inline]
       __handle_mm_fault mm/memory.c:5125 [inline]
       handle_mm_fault+0x1f68/0x3e9c mm/memory.c:5246
       faultin_page mm/gup.c:1009 [inline]
       __get_user_pages+0x3b0/0x968 mm/gup.c:1233
       populate_vma_page_range+0x1fc/0x2a0 mm/gup.c:1590
       __mm_populate+0x240/0x3d8 mm/gup.c:1704
       mm_populate include/linux/mm.h:2795 [inline]
       vm_mmap_pgoff+0x1fc/0x2b4 mm/util.c:525
       ksys_mmap_pgoff+0x3c8/0x5b0 mm/mmap.c:1458
       __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
       __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
       __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

other info that might help us debug this:

Chain exists of:
  mapping.invalidate_lock#4 --> &ni->file.run_lock --> &mm->mmap_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&ni->file.run_lock);
                               lock(&mm->mmap_lock);
  lock(mapping.invalidate_lock#4);

 *** DEADLOCK ***

1 lock held by syz-executor.5/8315:
 #0: ffff0000d5cf0748 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
 #0: ffff0000d5cf0748 (&mm->mmap_lock){++++}-{3:3}, at: __mm_populate+0x190/0x3d8 mm/gup.c:1683

stack backtrace:
CPU: 0 PID: 8315 Comm: syz-executor.5 Not tainted 6.1.52-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3824 [inline]
 __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5048
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5661
 down_read+0x64/0x308 kernel/locking/rwsem.c:1520
 filemap_invalidate_lock_shared include/linux/fs.h:811 [inline]
 filemap_fault+0x58c/0xf7c mm/filemap.c:3128
 __do_fault+0x11c/0x3d8 mm/memory.c:4231
 do_read_fault mm/memory.c:4582 [inline]
 do_fault mm/memory.c:4711 [inline]
 handle_pte_fault mm/memory.c:4983 [inline]
 __handle_mm_fault mm/memory.c:5125 [inline]
 handle_mm_fault+0x1f68/0x3e9c mm/memory.c:5246
 faultin_page mm/gup.c:1009 [inline]
 __get_user_pages+0x3b0/0x968 mm/gup.c:1233
 populate_vma_page_range+0x1fc/0x2a0 mm/gup.c:1590
 __mm_populate+0x240/0x3d8 mm/gup.c:1704
 mm_populate include/linux/mm.h:2795 [inline]
 vm_mmap_pgoff+0x1fc/0x2b4 mm/util.c:525
 ksys_mmap_pgoff+0x3c8/0x5b0 mm/mmap.c:1458
 __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
 __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
 __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581