syzbot

======================================================
WARNING: possible circular locking dependency detected
6.14.0-syzkaller-03576-g1e1ba8d23dae #0 Not tainted
------------------------------------------------------
syz.0.359/10246 is trying to acquire lock:
ffff88805300ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff88805300ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
ffff88805300ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
ffff88805300ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
ffff88805300ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_evict_inode+0x16d7/0x47c0 fs/ocfs2/inode.c:1230

but task is already holding lock:
ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_evict_inode+0xf5d/0x47c0 fs/ocfs2/inode.c:1230

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_del_inode_from_orphan+0x15d/0x8c0 fs/ocfs2/namei.c:2727
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2310 [inline]
       ocfs2_dio_end_io+0x568/0x1330 fs/ocfs2/aops.c:2408
       dio_complete+0x250/0x720 fs/direct-io.c:281
       __blockdev_direct_IO+0x3edd/0x48d0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2445
       generic_file_direct_write+0x1e8/0x400 mm/filemap.c:4036
       __generic_file_write_iter+0x126/0x230 mm/filemap.c:4205
       ocfs2_file_write_iter+0x190f/0x20d0 fs/ocfs2/file.c:2469
       do_iter_readv_writev+0x71f/0x9d0 fs/read_write.c:-1
       vfs_writev+0x38d/0xbc0 fs/read_write.c:1055
       do_writev+0x1b8/0x360 fs/read_write.c:1101
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
       ocfs2_create_local_dquot+0x1e5/0x1dd0 fs/ocfs2/quota_local.c:1232
       ocfs2_acquire_dquot+0x843/0xb80 fs/ocfs2/quota_global.c:883
       dqget+0x770/0xeb0 fs/quota/dquot.c:977
       __dquot_initialize+0x335/0xfc0 fs/quota/dquot.c:1505
       ocfs2_get_init_inode+0x15a/0x1d0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xcfe/0x2b30 fs/ocfs2/namei.c:310
       ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3666 [inline]
       open_last_lookups fs/namei.c:3765 [inline]
       path_openat+0x194b/0x35d0 fs/namei.c:4001
       do_filp_open+0x284/0x4e0 fs/namei.c:4031
       do_sys_openat2+0x12b/0x1d0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_creat fs/open.c:1522 [inline]
       __se_sys_creat fs/open.c:1516 [inline]
       __x64_sys_creat+0x124/0x170 fs/open.c:1516
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&dquot->dq_lock){+.+.}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:587 [inline]
       __mutex_lock+0x1bf/0x1000 kernel/locking/mutex.c:732
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x6e6/0xeb0 fs/quota/dquot.c:972
       __dquot_initialize+0x335/0xfc0 fs/quota/dquot.c:1505
       ocfs2_get_init_inode+0x15a/0x1d0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xcfe/0x2b30 fs/ocfs2/namei.c:310
       ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3666 [inline]
       open_last_lookups fs/namei.c:3765 [inline]
       path_openat+0x194b/0x35d0 fs/namei.c:4001
       do_filp_open+0x284/0x4e0 fs/namei.c:4031
       do_sys_openat2+0x12b/0x1d0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_creat fs/open.c:1522 [inline]
       __se_sys_creat fs/open.c:1516 [inline]
       __x64_sys_creat+0x124/0x170 fs/open.c:1516
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
       __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
       ocfs2_evict_inode+0x16d7/0x47c0 fs/ocfs2/inode.c:1230
       evict+0x4f9/0x9b0 fs/inode.c:810
       ocfs2_dentry_iput+0x23b/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x20d/0x630 fs/dcache.c:643
       dput+0x19f/0x2b0 fs/dcache.c:885
       __fput+0x60b/0x9f0 fs/file_table.c:473
       task_work_run+0x251/0x310 kernel/task_work.c:227
       exit_task_work include/linux/task_work.h:40 [inline]
       do_exit+0xa2a/0x2940 kernel/exit.c:954
       do_group_exit+0x207/0x2c0 kernel/exit.c:1103
       __do_sys_exit_group kernel/exit.c:1114 [inline]
       __se_sys_exit_group kernel/exit.c:1112 [inline]
       __x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1112
       x64_sys_call+0x26c3/0x26d0 arch/x86/include/generated/asm/syscalls_64.h:232
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);

 *** DEADLOCK ***

2 locks held by syz.0.359/10246:
 #0: ffff88803529cbd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0x10b/0x260 fs/ocfs2/dlmglue.c:2875
 #1: ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #1: ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
 #1: ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
 #1: ffff88805f3742c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_evict_inode+0xf5d/0x47c0 fs/ocfs2/inode.c:1230

stack backtrace:
CPU: 1 UID: 0 PID: 10246 Comm: syz.0.359 Not tainted 6.14.0-syzkaller-03576-g1e1ba8d23dae #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079
 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
 down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:867 [inline]
 ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
 ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
 ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
 ocfs2_evict_inode+0x16d7/0x47c0 fs/ocfs2/inode.c:1230
 evict+0x4f9/0x9b0 fs/inode.c:810
 ocfs2_dentry_iput+0x23b/0x390 fs/ocfs2/dcache.c:407
 __dentry_kill+0x20d/0x630 fs/dcache.c:643
 dput+0x19f/0x2b0 fs/dcache.c:885
 __fput+0x60b/0x9f0 fs/file_table.c:473
 task_work_run+0x251/0x310 kernel/task_work.c:227
 exit_task_work include/linux/task_work.h:40 [inline]
 do_exit+0xa2a/0x2940 kernel/exit.c:954
 do_group_exit+0x207/0x2c0 kernel/exit.c:1103
 __do_sys_exit_group kernel/exit.c:1114 [inline]
 __se_sys_exit_group kernel/exit.c:1112 [inline]
 __x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1112
 x64_sys_call+0x26c3/0x26d0 arch/x86/include/generated/asm/syscalls_64.h:232
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f992478d169
Code: Unable to access opcode bytes at 0x7f992478d13f.
RSP: 002b:00007fff03cea9b8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 000000000000000b RCX: 00007f992478d169
RDX: 00007f9924744777 RSI: 0000000000000000 RDI: 000000000000000b
RBP: 0000000000000003 R08: 00007fff03ceae47 R09: 000000000000000b
R10: 00007f99249a5fa0 R11: 0000000000000246 R12: 00007f99249a624c
R13: 00007f99249a6240 R14: 0000000000001c33 R15: 0000000000000007
 </TASK>