KASAN: use-after-free Read in bit_putcs

Status: fixed on 2020/11/16 12:12
Subsystems: fbdev
[Documentation on labels]
Reported-by: syzbot+b308f5fd049fbbc6e74f@syzkaller.appspotmail.com
Fix commit: 988d0763361b vt_ioctl: make VT_RESIZEX behave like VT_RESIZE
First crash: 2349d, last: 2126d
▶ ▼ Discussions (3)
Title Replies (including bot) Last reply
[PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE 12 (12) 2021/04/12 13:30
[PATCH 5.9 00/15] 5.9.1-rc1 review 26 (26) 2020/10/19 17:02
KASAN: use-after-free Read in bit_putcs 5 (7) 2020/09/27 09:27
▶ ▼ Similar bugs (4)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 KASAN: global-out-of-bounds Read in bit_putcs 19 C error 241 1413d 2423d 0/1 upstream: reported C repro on 2019/12/07 16:26
linux-4.14 KASAN: use-after-free Read in bit_putcs 19 17 2139d 2425d 0/1 auto-closed as invalid on 2021/01/15 05:05
linux-4.19 KASAN: global-out-of-bounds Read in bit_putcs 19 C done 214 1889d 2426d 1/1 fixed on 2021/06/24 08:01
linux-4.19 KASAN: use-after-free Read in bit_putcs 19 18 2189d 2423d 0/1 auto-closed as invalid on 2020/11/26 07:35

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in __fb_pad_aligned_buffer include/linux/fb.h:654 [inline]
BUG: KASAN: use-after-free in bit_putcs_aligned drivers/video/fbdev/core/bitblit.c:96 [inline]
BUG: KASAN: use-after-free in bit_putcs+0xbb6/0xd20 drivers/video/fbdev/core/bitblit.c:185
Read of size 1 at addr ffff88809df498fe by task syz-executor859/6860

CPU: 1 PID: 6860 Comm: syz-executor859 Not tainted 5.9.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x198/0x1fd lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xae/0x497 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
 __fb_pad_aligned_buffer include/linux/fb.h:654 [inline]
 bit_putcs_aligned drivers/video/fbdev/core/bitblit.c:96 [inline]
 bit_putcs+0xbb6/0xd20 drivers/video/fbdev/core/bitblit.c:185
 fbcon_putcs+0x35a/0x450 drivers/video/fbdev/core/fbcon.c:1308
 con_flush drivers/tty/vt/vt.c:2575 [inline]
 do_con_write+0xb6b/0x1dd0 drivers/tty/vt/vt.c:2905
 con_write+0x22/0xb0 drivers/tty/vt/vt.c:3250
 process_output_block drivers/tty/n_tty.c:595 [inline]
 n_tty_write+0x3ce/0xf80 drivers/tty/n_tty.c:2333
 do_tty_write drivers/tty/tty_io.c:962 [inline]
 tty_write+0x4d9/0x870 drivers/tty/tty_io.c:1046
 vfs_write+0x2b0/0x730 fs/read_write.c:576
 ksys_write+0x12d/0x250 fs/read_write.c:631
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4403c9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffd97e140c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004403c9
RDX: 0000000000001006 RSI: 0000000020000180 RDI: 0000000000000006
RBP: 00000000006cb018 R08: 00000000004002c8 R09: 00000000004002c8
R10: 000000000000000d R11: 0000000000000246 R12: 0000000000401c30
R13: 0000000000401cc0 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 6860:
 kasan_save_stack+0x1b/0x40 mm/kasan/common.c:48
 kasan_set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:461
 __do_kmalloc mm/slab.c:3655 [inline]
 __kmalloc+0x1b0/0x360 mm/slab.c:3664
 kmalloc include/linux/slab.h:559 [inline]
 kzalloc include/linux/slab.h:666 [inline]
 tomoyo_init_log+0x1376/0x1ee0 security/tomoyo/audit.c:275
 tomoyo_supervisor+0x34d/0xef0 security/tomoyo/common.c:2097
 tomoyo_audit_env_log security/tomoyo/environ.c:36 [inline]
 tomoyo_env_perm+0x17f/0x1f0 security/tomoyo/environ.c:63
 tomoyo_environ security/tomoyo/domain.c:674 [inline]
 tomoyo_find_next_domain+0x1438/0x1f77 security/tomoyo/domain.c:881
 tomoyo_bprm_check_security security/tomoyo/tomoyo.c:101 [inline]
 tomoyo_bprm_check_security+0x121/0x1a0 security/tomoyo/tomoyo.c:91
 security_bprm_check+0x45/0xa0 security/security.c:840
 search_binary_handler fs/exec.c:1807 [inline]
 exec_binprm fs/exec.c:1860 [inline]
 bprm_execve+0x879/0x1b10 fs/exec.c:1931
 do_execveat_common+0x626/0x7c0 fs/exec.c:2026
 do_execve fs/exec.c:2094 [inline]
 __do_sys_execve fs/exec.c:2170 [inline]
 __se_sys_execve fs/exec.c:2165 [inline]
 __x64_sys_execve+0x8f/0xc0 fs/exec.c:2165
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Freed by task 6860:
 kasan_save_stack+0x1b/0x40 mm/kasan/common.c:48
 kasan_set_track+0x1c/0x30 mm/kasan/common.c:56
 kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:355
 __kasan_slab_free+0xd8/0x120 mm/kasan/common.c:422
 __cache_free mm/slab.c:3418 [inline]
 kfree+0x10e/0x2b0 mm/slab.c:3756
 tomoyo_supervisor+0x36e/0xef0 security/tomoyo/common.c:2149
 tomoyo_audit_env_log security/tomoyo/environ.c:36 [inline]
 tomoyo_env_perm+0x17f/0x1f0 security/tomoyo/environ.c:63
 tomoyo_environ security/tomoyo/domain.c:674 [inline]
 tomoyo_find_next_domain+0x1438/0x1f77 security/tomoyo/domain.c:881
 tomoyo_bprm_check_security security/tomoyo/tomoyo.c:101 [inline]
 tomoyo_bprm_check_security+0x121/0x1a0 security/tomoyo/tomoyo.c:91
 security_bprm_check+0x45/0xa0 security/security.c:840
 search_binary_handler fs/exec.c:1807 [inline]
 exec_binprm fs/exec.c:1860 [inline]
 bprm_execve+0x879/0x1b10 fs/exec.c:1931
 do_execveat_common+0x626/0x7c0 fs/exec.c:2026
 do_execve fs/exec.c:2094 [inline]
 __do_sys_execve fs/exec.c:2170 [inline]
 __se_sys_execve fs/exec.c:2165 [inline]
 __x64_sys_execve+0x8f/0xc0 fs/exec.c:2165
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

The buggy address belongs to the object at ffff88809df49800
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 254 bytes inside of
 1024-byte region [ffff88809df49800, ffff88809df49c00)
The buggy address belongs to the page:
page:000000001b295380 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x9df49
flags: 0xfffe0000000200(slab)
raw: 00fffe0000000200 ffffea00027dc7c8 ffff8880aa041850 ffff8880aa040700
raw: 0000000000000000 ffff88809df49000 0000000100000002 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809df49780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88809df49800: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88809df49880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                                ^
 ffff88809df49900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809df49980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (12):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/09/26 02:02 upstream 171d4ff79f96 4a006f63 .config console log report syz C ci-upstream-kasan-gce-root
2020/09/30 12:45 upstream ccc1d052eff9 5abc3f1a .config console log report info ci-upstream-kasan-gce-smack-root
2020/09/26 01:17 upstream 171d4ff79f96 4a006f63 .config console log report info ci-upstream-kasan-gce-root
2020/09/24 04:24 upstream c9c9e6a49f89 54289b08 .config console log report info ci-upstream-kasan-gce-smack-root
2020/09/08 20:29 upstream 6f6a73c8b715 abf9ba4f .config console log report ci-upstream-kasan-gce-smack-root
2020/08/26 11:08 upstream 2ac69819ba9e 344da168 .config console log report ci-upstream-kasan-gce-smack-root
2020/07/30 12:16 upstream d3590ebf6f91 233283a1 .config console log report ci-upstream-kasan-gce-smack-root
2020/07/12 05:00 upstream a581387e415b 18d18b59 .config console log report ci-upstream-kasan-gce-smack-root
2020/06/16 00:40 upstream 7ae77150d94d baca2611 .config console log report ci-upstream-kasan-gce-root
2020/06/08 15:22 upstream 7ae77150d94d 7604bb03 .config console log report ci-upstream-kasan-gce-selinux-root
2020/02/19 16:49 upstream 0a44cac81050 b690a6e3 .config console log report ci-upstream-kasan-gce-smack-root
2020/06/07 14:18 linux-next e7b08814b16b 2c2b926c .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.