syzbot

 sign-in | mailing list | source | docs
🐞 Open [994] ≡ Subsystems 🐞 Fixed [5242] 🐞 Invalid [12515] ⬇ Missing Backports [83] 📈 Kernel Health 📈 Bug Lifetimes 📈 Fuzzing 📈 Crashes 💬 Send us feedback

KASAN: use-after-free Read in rsi_rx_done_handler

Status: fixed on 2020/02/18 14:31
Subsystems: wireless
[Documentation on labels]
Reported-by: syzbot+b563b7f8dbe8223a51e8@syzkaller.appspotmail.com
Fix commit: e93cd35101b6 rsi: fix use-after-free on failed probe and unbind
First crash: 1705d, last: 1568d
▶ ▼ Discussions (7)
Title Replies (including bot) Last reply
[PATCH 3.16 00/99] 3.16.84-rc1 review 112 (112) 2020/05/22 00:00
[PATCH 4.19 00/70] 4.19.102-stable review 77 (77) 2020/02/05 14:42
[PATCH 5.5 00/56] 5.5.1-stable review 66 (66) 2020/01/31 22:33
[PATCH 5.4 000/110] 5.4.17-stable review 116 (116) 2020/01/31 19:44
[PATCH 0/5] rsi: fix use-after-free, memleak and sleep-while-atomic 7 (7) 2019/12/18 18:57
WARNING: ODEBUG bug in rsi_probe 5 (10) 2019/11/29 11:27
KASAN: use-after-free Read in rsi_rx_done_handler 2 (3) 2019/11/28 17:12

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in rsi_rx_done_handler+0x3ba/0x490 drivers/net/wireless/rsi/rsi_91x_usb.c:267
Read of size 8 at addr ffff8881ca2978e8 by task kworker/1:0/17

CPU: 1 PID: 17 Comm: kworker/1:0 Not tainted 5.5.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xef/0x16e lib/dump_stack.c:118
 print_address_description.constprop.0+0x16/0x200 mm/kasan/report.c:374
 __kasan_report.cold+0x37/0x7f mm/kasan/report.c:506
 kasan_report+0xe/0x20 mm/kasan/common.c:639
 rsi_rx_done_handler+0x3ba/0x490 drivers/net/wireless/rsi/rsi_91x_usb.c:267
 __usb_hcd_giveback_urb+0x1f2/0x470 drivers/usb/core/hcd.c:1648
 usb_hcd_giveback_urb+0x368/0x420 drivers/usb/core/hcd.c:1713
 dummy_timer+0x123d/0x2fdb drivers/usb/gadget/udc/dummy_hcd.c:1966
 call_timer_fn+0x179/0x650 kernel/time/timer.c:1404
 expire_timers kernel/time/timer.c:1449 [inline]
 __run_timers kernel/time/timer.c:1773 [inline]
 __run_timers kernel/time/timer.c:1740 [inline]
 run_timer_softirq+0x5e3/0x1490 kernel/time/timer.c:1786
 __do_softirq+0x221/0x912 kernel/softirq.c:292
 invoke_softirq kernel/softirq.c:373 [inline]
 irq_exit+0x178/0x1a0 kernel/softirq.c:413
 exiting_irq arch/x86/include/asm/apic.h:536 [inline]
 smp_apic_timer_interrupt+0x12f/0x500 arch/x86/kernel/apic/apic.c:1137
 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829
 </IRQ>
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/irqflags.h:85 [inline]
RIP: 0010:console_unlock+0xa1b/0xc30 kernel/printk/printk.c:2481
Code: 00 89 ee 48 c7 c7 80 63 d3 86 e8 20 b5 03 00 65 ff 0d a1 0b d9 7e e9 ea f9 ff ff e8 8f ef 15 00 e8 3a 30 1b 00 ff 74 24 30 9d <e9> 18 fe ff ff e8 7b ef 15 00 48 8d 7d 08 48 89 f8 48 c1 e8 03 42
RSP: 0018:ffff8881da667198 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13
RAX: 0000000000000007 RBX: 0000000000000200 RCX: 0000000000000006
RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffff8881da64b94c
RBP: 0000000000000000 R08: ffff8881da64b100 R09: fffffbfff11ad09d
R10: fffffbfff11ad09c R11: ffffffff88d684e7 R12: 000000000000004b
R13: dffffc0000000000 R14: ffffffff8299f110 R15: ffffffff8707c790
 vprintk_emit+0x171/0x3d0 kernel/printk/printk.c:1996
 vprintk_func+0x75/0x113 kernel/printk/printk_safe.c:386
 printk+0xba/0xed kernel/printk/printk.c:2056
 really_probe.cold+0x69/0x1de drivers/base/dd.c:628
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_set_configuration+0xe38/0x16c0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Allocated by task 17:
 save_stack+0x1b/0x80 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 __kasan_kmalloc mm/kasan/common.c:513 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:486
 rsi_init_sdio_interface drivers/net/wireless/rsi/rsi_91x_sdio.c:850 [inline]
 rsi_probe+0x11a/0x1529 drivers/net/wireless/rsi/rsi_91x_sdio.c:1034
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_set_configuration+0xe38/0x16c0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 17:
 save_stack+0x1b/0x80 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 kasan_set_free_info mm/kasan/common.c:335 [inline]
 __kasan_slab_free+0x129/0x170 mm/kasan/common.c:474
 slab_free_hook mm/slub.c:1425 [inline]
 slab_free_freelist_hook mm/slub.c:1458 [inline]
 slab_free mm/slub.c:3005 [inline]
 kfree+0xda/0x310 mm/slub.c:3957
 rsi_91x_deinit+0x270/0x2f0 drivers/net/wireless/rsi/rsi_91x_main.c:407
 rsi_probe+0xe71/0x1529 drivers/net/wireless/rsi/rsi_91x_sdio.c:1279
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_set_configuration+0xe38/0x16c0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff8881ca297800
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 232 bytes inside of
 512-byte region [ffff8881ca297800, ffff8881ca297a00)
The buggy address belongs to the page:
page:ffffea000728a500 refcount:1 mapcount:0 mapping:ffff8881da402500 index:0x0 compound_mapcount: 0
raw: 0200000000010200 dead000000000100 dead000000000122 ffff8881da402500
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881ca297780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff8881ca297800: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8881ca297880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                          ^
 ffff8881ca297900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881ca297980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/10 13:21 https://github.com/google/kasan.git usb-fuzzer ae1794106b94 4de4e9f0 .config console log report ci2-upstream-usb
2019/08/27 20:23 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/27 18:38 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/27 16:01 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/27 14:38 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/27 08:20 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/26 16:23 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
2019/08/26 10:32 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.