syzbot


possible deadlock in rollback_registered_many

Status: closed as invalid on 2017/11/03 12:59
Reported-by: syzbot+f80ba0ad2f1a5541007fa820d22cecac0e2ac54c@syzkaller.appspotmail.com
First crash: 2818d, last: 2813d

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
4.13.0-rc6-next-20170825+ #9 Not tainted
------------------------------------------------------
syz-executor3/3636 is trying to acquire lock:
 (cpu_hotplug_lock.rw_sem){++++}, at: [<ffffffff83e7be67>] get_online_cpus include/linux/cpu.h:126 [inline]
 (cpu_hotplug_lock.rw_sem){++++}, at: [<ffffffff83e7be67>] flush_all_backlogs net/core/dev.c:4592 [inline]
 (cpu_hotplug_lock.rw_sem){++++}, at: [<ffffffff83e7be67>] rollback_registered_many+0x587/0xe80 net/core/dev.c:7127

but task is already holding lock:
 (rtnl_mutex){+.+.}, at: [<ffffffff83ecc7f7>] rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (rtnl_mutex){+.+.}:
       check_prevs_add kernel/locking/lockdep.c:2020 [inline]
       validate_chain kernel/locking/lockdep.c:2469 [inline]
       __lock_acquire+0x3286/0x4620 kernel/locking/lockdep.c:3498
       lock_acquire+0x1d5/0x580 kernel/locking/lockdep.c:4002
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0x16f/0x1870 kernel/locking/mutex.c:893
       mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908
       rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72
       addrconf_dad_work+0xbb/0xfc0 net/ipv6/addrconf.c:3890
       process_one_work+0xbfd/0x1be0 kernel/workqueue.c:2098
       worker_thread+0x223/0x1860 kernel/workqueue.c:2233
       kthread+0x39c/0x470 kernel/kthread.c:231
       ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431

-> #2 ((&(&ifa->dad_work)->work)){+.+.}:
       process_one_work+0xba5/0x1be0 kernel/workqueue.c:2095
       worker_thread+0x223/0x1860 kernel/workqueue.c:2233
       kthread+0x39c/0x470 kernel/kthread.c:231
       ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431
       0xffffffffffffffff

-> #1 ((complete)&rcu.completion){+.+.}:
       check_prevs_add kernel/locking/lockdep.c:2020 [inline]
       validate_chain kernel/locking/lockdep.c:2469 [inline]
       __lock_acquire+0x3286/0x4620 kernel/locking/lockdep.c:3498
       lock_acquire+0x1d5/0x580 kernel/locking/lockdep.c:4002
       complete_acquire include/linux/completion.h:39 [inline]
       __wait_for_common kernel/sched/completion.c:108 [inline]
       wait_for_common kernel/sched/completion.c:122 [inline]
       wait_for_completion+0xc8/0x770 kernel/sched/completion.c:143
       __synchronize_srcu+0x1b5/0x250 kernel/rcu/srcutree.c:898
       synchronize_srcu_expedited kernel/rcu/srcutree.c:923 [inline]
       synchronize_srcu+0x1a3/0x560 kernel/rcu/srcutree.c:974
       quarantine_remove_cache+0xd7/0xf0 mm/kasan/quarantine.c:327
       kasan_cache_shrink+0x9/0x10 mm/kasan/kasan.c:380
       kmem_cache_shrink+0x15/0x30 mm/slab_common.c:857
       acpi_os_purge_cache+0x15/0x20 drivers/acpi/osl.c:1560
       acpi_purge_cached_objects+0x38/0xc9 drivers/acpi/acpica/utxface.c:271
       acpi_initialize_objects+0xc5/0x112 drivers/acpi/acpica/utxfinit.c:302
       acpi_bus_init drivers/acpi/bus.c:1131 [inline]
       acpi_init+0x23c/0x8e6 drivers/acpi/bus.c:1220
       do_one_initcall+0x9e/0x330 init/main.c:826
       do_initcall_level init/main.c:892 [inline]
       do_initcalls init/main.c:900 [inline]
       do_basic_setup init/main.c:918 [inline]
       kernel_init_freeable+0x469/0x521 init/main.c:1066
       kernel_init+0x13/0x172 init/main.c:993
       ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431

-> #0 (cpu_hotplug_lock.rw_sem){++++}:
       check_prev_add+0x865/0x1520 kernel/locking/lockdep.c:1894
       check_prevs_add kernel/locking/lockdep.c:2020 [inline]
       validate_chain kernel/locking/lockdep.c:2469 [inline]
       __lock_acquire+0x3286/0x4620 kernel/locking/lockdep.c:3498
       lock_acquire+0x1d5/0x580 kernel/locking/lockdep.c:4002
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:35 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:58 [inline]
       cpus_read_lock+0x42/0x90 kernel/cpu.c:218
       get_online_cpus include/linux/cpu.h:126 [inline]
       flush_all_backlogs net/core/dev.c:4592 [inline]
       rollback_registered_many+0x587/0xe80 net/core/dev.c:7127
       rollback_registered+0x1be/0x3c0 net/core/dev.c:7183
       unregister_netdevice_queue+0x2e3/0x5d0 net/core/dev.c:8171
       unregister_netdevice include/linux/netdevice.h:2428 [inline]
       __tun_detach+0x1020/0x1390 drivers/net/tun.c:576
       tun_detach drivers/net/tun.c:587 [inline]
       tun_chr_close+0x44/0x60 drivers/net/tun.c:2595
       __fput+0x333/0x7f0 fs/file_table.c:210
       ____fput+0x15/0x20 fs/file_table.c:246
       task_work_run+0x199/0x270 kernel/task_work.c:112
       exit_task_work include/linux/task_work.h:21 [inline]
       do_exit+0xa52/0x1b40 kernel/exit.c:865
       do_group_exit+0x149/0x400 kernel/exit.c:968
       get_signal+0x7e8/0x17e0 kernel/signal.c:2334
       do_signal+0x94/0x1ee0 arch/x86/kernel/signal.c:808
       exit_to_usermode_loop+0x224/0x300 arch/x86/entry/common.c:158
       prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
       syscall_return_slowpath+0x42f/0x500 arch/x86/entry/common.c:266
       entry_SYSCALL_64_fastpath+0xbc/0xbe

other info that might help us debug this:

Chain exists of:
  cpu_hotplug_lock.rw_sem --> (&(&ifa->dad_work)->work) --> rtnl_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(rtnl_mutex);
                               lock((&(&ifa->dad_work)->work));
                               lock(rtnl_mutex);
  lock(cpu_hotplug_lock.rw_sem);

 *** DEADLOCK ***

1 lock held by syz-executor3/3636:
 #0:  (rtnl_mutex){+.+.}, at: [<ffffffff83ecc7f7>] rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72

stack backtrace:
CPU: 1 PID: 3636 Comm: syz-executor3 Not tainted 4.13.0-rc6-next-20170825+ #9
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:16 [inline]
 dump_stack+0x194/0x257 lib/dump_stack.c:52
 print_circular_bug+0x503/0x710 kernel/locking/lockdep.c:1259
 check_prev_add+0x865/0x1520 kernel/locking/lockdep.c:1894
 check_prevs_add kernel/locking/lockdep.c:2020 [inline]
 validate_chain kernel/locking/lockdep.c:2469 [inline]
 __lock_acquire+0x3286/0x4620 kernel/locking/lockdep.c:3498
 lock_acquire+0x1d5/0x580 kernel/locking/lockdep.c:4002
 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:35 [inline]
 percpu_down_read include/linux/percpu-rwsem.h:58 [inline]
 cpus_read_lock+0x42/0x90 kernel/cpu.c:218
 get_online_cpus include/linux/cpu.h:126 [inline]
 flush_all_backlogs net/core/dev.c:4592 [inline]
 rollback_registered_many+0x587/0xe80 net/core/dev.c:7127
 rollback_registered+0x1be/0x3c0 net/core/dev.c:7183
 unregister_netdevice_queue+0x2e3/0x5d0 net/core/dev.c:8171
 unregister_netdevice include/linux/netdevice.h:2428 [inline]
 __tun_detach+0x1020/0x1390 drivers/net/tun.c:576
 tun_detach drivers/net/tun.c:587 [inline]
 tun_chr_close+0x44/0x60 drivers/net/tun.c:2595
 __fput+0x333/0x7f0 fs/file_table.c:210
 ____fput+0x15/0x20 fs/file_table.c:246
 task_work_run+0x199/0x270 kernel/task_work.c:112
 exit_task_work include/linux/task_work.h:21 [inline]
 do_exit+0xa52/0x1b40 kernel/exit.c:865
 do_group_exit+0x149/0x400 kernel/exit.c:968
 get_signal+0x7e8/0x17e0 kernel/signal.c:2334
 do_signal+0x94/0x1ee0 arch/x86/kernel/signal.c:808
 exit_to_usermode_loop+0x224/0x300 arch/x86/entry/common.c:158
 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
 syscall_return_slowpath+0x42f/0x500 arch/x86/entry/common.c:266
 entry_SYSCALL_64_fastpath+0xbc/0xbe
RIP: 0033:0x4512e9
RSP: 002b:00007f7518535cf8 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: 0000000000000000 RBX: 0000000000718020 RCX: 00000000004512e9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000718020
RBP: 0000000000718000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000a6f7ef R14: 00007f75185369c0 R15: 0000000000000000
netlink: 3 bytes leftover after parsing attributes in process `syz-executor6'.
Can not set IPV6_FL_F_REFLECT if flowlabel_consistency sysctl is enable
Can not set IPV6_FL_F_REFLECT if flowlabel_consistency sysctl is enable
syz-executor7 uses obsolete (PF_INET,SOCK_PACKET)
ptm ptm1: ldisc open failed (-12), clearing slot 1
TCP: request_sock_TCPv6: Possible SYN flooding on port 20001. Sending cookies.  Check SNMP counters.
rpcbind: RPC call returned error 22
raw_sendmsg: syz-executor7 forgot to set AF_INET. Fix it!
rpcbind: RPC call returned error 22
program syz-executor2 is using a deprecated SCSI ioctl, please convert it to SG_IO
sd 0:0:1:0: ioctl_internal_command: ILLEGAL REQUEST asc=0x20 ascq=0x0
program syz-executor2 is using a deprecated SCSI ioctl, please convert it to SG_IO
program syz-executor2 is using a deprecated SCSI ioctl, please convert it to SG_IO
sd 0:0:1:0: ioctl_internal_command: ILLEGAL REQUEST asc=0x20 ascq=0x0
program syz-executor2 is using a deprecated SCSI ioctl, please convert it to SG_IO
sd 0:0:1:0: ioctl_internal_command: ILLEGAL REQUEST asc=0x20 ascq=0x0
sd 0:0:1:0: ioctl_internal_command: ILLEGAL REQUEST asc=0x20 ascq=0x0
QAT: Invalid ioctl
sctp: [Deprecated]: syz-executor2 (pid 3991) Use of int in maxseg socket option.
Use struct sctp_assoc_value instead
sctp: [Deprecated]: syz-executor2 (pid 3999) Use of int in max_burst socket option deprecated.
Use struct sctp_assoc_value instead
sctp: [Deprecated]: syz-executor2 (pid 3991) Use of int in maxseg socket option.
Use struct sctp_assoc_value instead
sctp: [Deprecated]: syz-executor2 (pid 3991) Use of int in max_burst socket option deprecated.
Use struct sctp_assoc_value instead
mmap: syz-executor6 (4072) uses deprecated remap_file_pages() syscall. See Documentation/vm/remap_file_pages.txt.
QAT: Invalid ioctl
nla_parse: 7 callbacks suppressed
netlink: 13 bytes leftover after parsing attributes in process `syz-executor1'.
QAT: Invalid ioctl
netlink: 13 bytes leftover after parsing attributes in process `syz-executor1'.
capability: warning: `syz-executor1' uses 32-bit capabilities (legacy support in use)
netlink: 64 bytes leftover after parsing attributes in process `syz-executor0'.
netlink: 13 bytes leftover after parsing attributes in process `syz-executor3'.
netlink: 13 bytes leftover after parsing attributes in process `syz-executor3'.
netlink: 64 bytes leftover after parsing attributes in process `syz-executor0'.
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4327 comm=syz-executor7
audit: type=1326 audit(1503912379.320:4): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4354 comm="syz-executor3" exe="/root/syz-executor3" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
QAT: Invalid ioctl
netlink: 1 bytes leftover after parsing attributes in process `syz-executor7'.
QAT: Invalid ioctl
netlink: 1 bytes leftover after parsing attributes in process `syz-executor7'.
audit: type=1326 audit(1503912379.345:5): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4354 comm="syz-executor3" exe="/root/syz-executor3" sig=31 arch=c000003e syscall=35 compat=0 ip=0x47c951 code=0xffff0000
netlink: 4 bytes leftover after parsing attributes in process `syz-executor4'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor4'.
sctp: [Deprecated]: syz-executor0 (pid 4464) Use of int in max_burst socket option.
Use struct sctp_assoc_value instead
sctp: [Deprecated]: syz-executor0 (pid 4464) Use of int in max_burst socket option.
Use struct sctp_assoc_value instead
audit: type=1326 audit(1503912380.105:6): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4512 comm="syz-executor3" exe="/root/syz-executor3" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
audit: type=1326 audit(1503912380.131:7): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4515 comm="syz-executor2" exe="/root/syz-executor2" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
audit: type=1326 audit(1503912380.160:8): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4512 comm="syz-executor3" exe="/root/syz-executor3" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
audit: type=1326 audit(1503912380.310:9): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4561 comm="syz-executor2" exe="/root/syz-executor2" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
kvm [4549]: vcpu0, guest rIP: 0xfff0 ignored wrmsr: 0x11e data 0x7ff
kvm [4549]: vcpu0, guest rIP: 0xfff0 ignored wrmsr: 0x11e data 0x7ff
audit: type=1326 audit(1503912380.392:10): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4561 comm="syz-executor2" exe="/root/syz-executor2" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
audit: type=1326 audit(1503912380.488:11): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4595 comm="syz-executor6" exe="/root/syz-executor6" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
dccp_invalid_packet: P.Data Offset(172) too large
audit: type=1326 audit(1503912380.539:12): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4628 comm="syz-executor2" exe="/root/syz-executor2" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4642 comm=syz-executor1
audit: type=1326 audit(1503912380.620:13): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=4595 comm="syz-executor6" exe="/root/syz-executor6" sig=31 arch=c000003e syscall=202 compat=0 ip=0x4512e9 code=0xffff0000
dccp_invalid_packet: P.Data Offset(172) too large
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4767 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4767 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4782 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4819 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4789 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=0 sclass=netlink_route_socket pig=4819 comm=syz-executor5
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
SELinux: failure in selinux_parse_skb(), unable to parse packet
QAT: Invalid ioctl
QAT: Invalid ioctl
8021q: VLANs not supported on lo
8021q: VLANs not supported on lo
irq bypass consumer (token ffff8801c9b7ba80) registration fails: -16
nla_parse: 22 callbacks suppressed
netlink: 5 bytes leftover after parsing attributes in process `syz-executor5'.
irq bypass consumer (token ffff8801c389e600) registration fails: -16
netlink: 5 bytes leftover after parsing attributes in process `syz-executor5'.
netlink: 13 bytes leftover after parsing attributes in process `syz-executor7'.
netlink: 5 bytes leftover after parsing attributes in process `syz-executor4'.
netlink: 13 bytes leftover after parsing attributes in process `syz-executor7'.
QAT: Invalid ioctl
netlink: 2 bytes leftover after parsing attributes in process `syz-executor1'.
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
QAT: Invalid ioctl
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=256 sclass=netlink_route_socket pig=5739 comm=syz-executor1
netlink: 5 bytes leftover after parsing attributes in process `syz-executor0'.
netlink: 5 bytes leftover after parsing attributes in process `syz-executor0'.
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=256 sclass=netlink_route_socket pig=5748 comm=syz-executor1
dccp_invalid_packet: pskb_may_pull failed
netlink: 13 bytes leftover after parsing attributes in process `syz-executor7'.
sit0: Invalid MTU 16711680 requested, hw max 65508
netlink: 1 bytes leftover after parsing attributes in process `syz-executor3'.
dccp_invalid_packet: pskb_may_pull failed
sit0: Invalid MTU 16711680 requested, hw max 65508
device lo entered promiscuous mode
sock: process `syz-executor7' is using obsolete getsockopt SO_BSDCOMPAT
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=65535 sclass=netlink_route_socket pig=5988 comm=syz-executor3
TCP: request_sock_TCP: Possible SYN flooding on port 20008. Sending cookies.  Check SNMP counters.

Crashes (199):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2017/08/28 09:26 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/28 09:23 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/28 02:00 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/28 01:03 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/27 19:45 linux-next 7159188b70e3 4074aed7 .config console log report skylake-linux-next-kasan-qemu
2017/08/27 19:06 linux-next 7159188b70e3 4074aed7 .config console log report skylake-linux-next-kasan-qemu
2017/08/27 17:23 linux-next 7159188b70e3 4074aed7 .config console log report skylake-linux-next-kasan-qemu
2017/08/27 12:07 linux-next 7159188b70e3 4074aed7 .config console log report skylake-linux-next-kasan-qemu
2017/08/26 23:51 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/26 20:46 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/26 13:53 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/26 12:33 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/26 09:43 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/25 20:02 linux-next 7159188b70e3 4074aed7 .config console log report ci-upstream-next-kasan-gce
2017/08/25 04:00 linux-next 9506597de2cd 3f1aca48 .config console log report ci-upstream-next-kasan-gce
2017/08/24 21:11 linux-next 9506597de2cd 3f1aca48 .config console log report ci-upstream-next-kasan-gce
2017/08/24 10:08 linux-next 9506597de2cd 3f1aca48 .config console log report ci-upstream-next-kasan-gce
2017/08/23 21:14 linux-next cc6d46bb99b5 f238fbd4 .config console log report ci-upstream-next-kasan-gce
2017/08/23 20:30 linux-next cc6d46bb99b5 f238fbd4 .config console log report ci-upstream-next-kasan-gce
2017/08/23 14:34 linux-next cc6d46bb99b5 f238fbd4 .config console log report ci-upstream-next-kasan-gce
* Struck through repros no longer work on HEAD.