syzbot


possible deadlock in ocfs2_read_folio

Status: upstream: reported C repro on 2025/02/13 14:33
Subsystems: ocfs2
[Documentation on labels]
Reported-by: syzbot+bd316bb736c7dc2f318e@syzkaller.appspotmail.com
First crash: 267d, last: 53d
Cause bisection: failed (error log, bisect log)
  
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ocfs2?] possible deadlock in ocfs2_read_folio 0 (2) 2025/05/28 14:48
Last patch testing requests (4)
Created Duration User Patch Repo Result
2025/10/14 11:01 55m retest repro linux-next OK log
2025/08/20 15:48 20m retest repro upstream OK log
2025/08/05 03:47 17m retest repro linux-next report log
2025/06/11 14:59 18m retest repro upstream report log
Cause bisection attempts (2)
Created Duration User Patch Repo Result
2025/08/02 15:07 12h44m bisect linux-next error job log
2025/07/22 04:19 11h03m bisect linux-next error job log

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.5.484/9219 is trying to acquire lock:
ffff88803da607d0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_read_folio+0x353/0x970 fs/ocfs2/aops.c:287

but task is already holding lock:
ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:935 [inline]
ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_create_folio mm/filemap.c:2539 [inline]
ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_get_pages+0xbe1/0x1df0 mm/filemap.c:2609

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (mapping.invalidate_lock#15){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       filemap_invalidate_lock_shared include/linux/fs.h:935 [inline]
       filemap_fault+0x551/0x1210 mm/filemap.c:3433
       ocfs2_fault+0xa4/0x400 fs/ocfs2/mmap.c:38
       __do_fault+0x138/0x390 mm/memory.c:5152
       do_read_fault mm/memory.c:5573 [inline]
       do_fault mm/memory.c:5707 [inline]
       do_pte_missing mm/memory.c:4234 [inline]
       handle_pte_fault mm/memory.c:6052 [inline]
       __handle_mm_fault mm/memory.c:6195 [inline]
       handle_mm_fault+0x23c6/0x3400 mm/memory.c:6364
       faultin_page mm/gup.c:1144 [inline]
       __get_user_pages+0x16e4/0x2b60 mm/gup.c:1446
       populate_vma_page_range+0x29f/0x3a0 mm/gup.c:1880
       __mm_populate+0x24c/0x380 mm/gup.c:1983
       mm_populate include/linux/mm.h:3367 [inline]
       vm_mmap_pgoff+0x38a/0x4d0 mm/util.c:585
       ksys_mmap_pgoff+0x4e9/0x720 mm/mmap.c:604
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __might_fault+0xcc/0x130 mm/memory.c:6958
       _inline_copy_to_user include/linux/uaccess.h:192 [inline]
       _copy_to_user+0x2c/0xb0 lib/usercopy.c:26
       copy_to_user include/linux/uaccess.h:225 [inline]
       fiemap_fill_next_extent+0x1c0/0x390 fs/ioctl.c:145
       ocfs2_fiemap_inline fs/ocfs2/extent_map.c:735 [inline]
       ocfs2_fiemap+0x9dc/0xc90 fs/ocfs2/extent_map.c:772
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x1185/0x1440 fs/ioctl.c:532
       __do_sys_ioctl fs/ioctl.c:596 [inline]
       __se_sys_ioctl+0x82/0x170 fs/ioctl.c:584
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       ocfs2_read_folio+0x353/0x970 fs/ocfs2/aops.c:287
       filemap_read_folio+0x114/0x380 mm/filemap.c:2413
       filemap_create_folio mm/filemap.c:2548 [inline]
       filemap_get_pages+0xcf8/0x1df0 mm/filemap.c:2609
       filemap_read+0x3f9/0x11a0 mm/filemap.c:2712
       ocfs2_file_read_iter+0x400/0xa90 fs/ocfs2/file.c:2589
       __kernel_read+0x4d5/0x970 fs/read_write.c:530
       integrity_kernel_read+0x89/0xd0 security/integrity/iint.c:28
       ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
       ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
       ima_calc_file_hash+0x86a/0x1700 security/integrity/ima/ima_crypto.c:568
       ima_collect_measurement+0x42e/0x8e0 security/integrity/ima/ima_api.c:293
       process_measurement+0x112d/0x1a40 security/integrity/ima/ima_main.c:405
       ima_file_check+0xd7/0x120 security/integrity/ima/ima_main.c:633
       security_file_post_open+0xbb/0x290 security/security.c:3160
       do_open fs/namei.c:3889 [inline]
       path_openat+0x2f32/0x3840 fs/namei.c:4046
       do_filp_open+0x1fa/0x410 fs/namei.c:4073
       do_sys_openat2+0x121/0x1c0 fs/open.c:1435
       do_sys_open fs/open.c:1450 [inline]
       __do_sys_openat fs/open.c:1466 [inline]
       __se_sys_openat fs/open.c:1461 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1461
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> &mm->mmap_lock --> mapping.invalidate_lock#15

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(mapping.invalidate_lock#15);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#15);
  rlock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

2 locks held by syz.5.484/9219:
 #0: ffff88802712c858 (&ima_iint_mutex_key[depth]){+.+.}-{4:4}, at: process_measurement+0x757/0x1a40 security/integrity/ima/ima_main.c:299
 #1: ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:935 [inline]
 #1: ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_create_folio mm/filemap.c:2539 [inline]
 #1: ffff88803da60d50 (mapping.invalidate_lock#15){.+.+}-{4:4}, at: filemap_get_pages+0xbe1/0x1df0 mm/filemap.c:2609

stack backtrace:
CPU: 1 UID: 0 PID: 9219 Comm: syz.5.484 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
 down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
 ocfs2_read_folio+0x353/0x970 fs/ocfs2/aops.c:287
 filemap_read_folio+0x114/0x380 mm/filemap.c:2413
 filemap_create_folio mm/filemap.c:2548 [inline]
 filemap_get_pages+0xcf8/0x1df0 mm/filemap.c:2609
 filemap_read+0x3f9/0x11a0 mm/filemap.c:2712
 ocfs2_file_read_iter+0x400/0xa90 fs/ocfs2/file.c:2589
 __kernel_read+0x4d5/0x970 fs/read_write.c:530
 integrity_kernel_read+0x89/0xd0 security/integrity/iint.c:28
 ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
 ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
 ima_calc_file_hash+0x86a/0x1700 security/integrity/ima/ima_crypto.c:568
 ima_collect_measurement+0x42e/0x8e0 security/integrity/ima/ima_api.c:293
 process_measurement+0x112d/0x1a40 security/integrity/ima/ima_main.c:405
 ima_file_check+0xd7/0x120 security/integrity/ima/ima_main.c:633
 security_file_post_open+0xbb/0x290 security/security.c:3160
 do_open fs/namei.c:3889 [inline]
 path_openat+0x2f32/0x3840 fs/namei.c:4046
 do_filp_open+0x1fa/0x410 fs/namei.c:4073
 do_sys_openat2+0x121/0x1c0 fs/open.c:1435
 do_sys_open fs/open.c:1450 [inline]
 __do_sys_openat fs/open.c:1466 [inline]
 __se_sys_openat fs/open.c:1461 [inline]
 __x64_sys_openat+0x138/0x170 fs/open.c:1461
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8b2a3feba9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8b2863d038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f8b2a646090 RCX: 00007f8b2a3feba9
RDX: 0000000000000042 RSI: 0000200000000080 RDI: ffffffffffffff9c
RBP: 00007f8b2a481e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f8b2a646128 R14: 00007f8b2a646090 R15: 00007ffcdea6e328
 </TASK>
ocfs2: Unmounting device (7,5) on (node local)

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/09/11 10:16 upstream 7aac71907bde fdeaa69b .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/07/10 18:08 upstream 8c2e52ebbe88 3cda49cf .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/06/12 15:23 upstream 2c4a1f3fe03e 98683f8f .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/04/24 19:07 upstream e72e9e693307 9882047a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/04/15 18:15 upstream 1a1d569a75f3 23b969b7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/02/09 14:24 upstream 9946eaf552b1 ef44b750 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/05/28 14:47 upstream c89756bcf406 874a1386 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro (clean fs)] ci-snapshot-upstream-root possible deadlock in ocfs2_read_folio
2025/05/28 13:19 upstream c89756bcf406 874a1386 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in ocfs2_read_folio
2025/07/22 01:57 linux-next d086c886ceb9 0b3788a0 .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro (clean fs)] ci-upstream-linux-next-kasan-gce-root possible deadlock in ocfs2_read_folio
* Struck through repros no longer work on HEAD.