syzbot


possible deadlock in ovl_maybe_copy_up

Status: upstream: reported C repro on 2020/11/23 10:05
Reported-by: syzbot+c18f2f6a7b08c51e3025@syzkaller.appspotmail.com
First crash: 679d, last: 2d01h

Cause bisection: introduced by (bisect log) [merge commit]:
commit b753c5a7f99f390fc100de18647ce0dcacdceafc
Author: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed Aug 14 01:12:45 2019 +0000

  Merge branch 'r8152-RX-improve'

Crash: general protection fault in batadv_iv_ogm_queue_add (log)
Repro: C syz .config

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.12.0-rc5-next-20210401-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor144/9166 is trying to acquire lock:
ffff888144cf0460 (sb_writers#5){.+.+}-{0:0}, at: ovl_maybe_copy_up+0x11f/0x190 fs/overlayfs/copy_up.c:995

but task is already holding lock:
ffff8880256d42c0 (&iint->mutex){+.+.}-{3:3}, at: process_measurement+0x3a8/0x17e0 security/integrity/ima/ima_main.c:253

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&iint->mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:949 [inline]
       __mutex_lock+0x139/0x1120 kernel/locking/mutex.c:1096
       process_measurement+0x3a8/0x17e0 security/integrity/ima/ima_main.c:253
       ima_file_check+0xb9/0x100 security/integrity/ima/ima_main.c:499
       do_open fs/namei.c:3361 [inline]
       path_openat+0x15b5/0x27e0 fs/namei.c:3492
       do_filp_open+0x17e/0x3c0 fs/namei.c:3519
       do_sys_openat2+0x16d/0x420 fs/open.c:1187
       do_sys_open fs/open.c:1203 [inline]
       __do_sys_open fs/open.c:1211 [inline]
       __se_sys_open fs/open.c:1207 [inline]
       __x64_sys_open+0x119/0x1c0 fs/open.c:1207
       do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #0 (sb_writers#5){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:2938 [inline]
       check_prevs_add kernel/locking/lockdep.c:3061 [inline]
       validate_chain kernel/locking/lockdep.c:3676 [inline]
       __lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
       lock_acquire kernel/locking/lockdep.c:5512 [inline]
       lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1758 [inline]
       sb_start_write include/linux/fs.h:1828 [inline]
       mnt_want_write+0x6e/0x3e0 fs/namespace.c:375
       ovl_maybe_copy_up+0x11f/0x190 fs/overlayfs/copy_up.c:995
       ovl_open+0xba/0x270 fs/overlayfs/file.c:149
       do_dentry_open+0x4b9/0x11b0 fs/open.c:826
       vfs_open fs/open.c:940 [inline]
       dentry_open+0x132/0x1d0 fs/open.c:956
       ima_calc_file_hash+0x2d2/0x4b0 security/integrity/ima/ima_crypto.c:557
       ima_collect_measurement+0x4ca/0x570 security/integrity/ima/ima_api.c:252
       process_measurement+0xd1c/0x17e0 security/integrity/ima/ima_main.c:330
       ima_file_check+0xb9/0x100 security/integrity/ima/ima_main.c:499
       do_open fs/namei.c:3361 [inline]
       path_openat+0x15b5/0x27e0 fs/namei.c:3492
       do_filp_open+0x17e/0x3c0 fs/namei.c:3519
       do_sys_openat2+0x16d/0x420 fs/open.c:1187
       do_sys_open fs/open.c:1203 [inline]
       __do_sys_open fs/open.c:1211 [inline]
       __se_sys_open fs/open.c:1207 [inline]
       __x64_sys_open+0x119/0x1c0 fs/open.c:1207
       do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x44/0xae

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&iint->mutex);
                               lock(sb_writers#5);
                               lock(&iint->mutex);
  lock(sb_writers#5);

 *** DEADLOCK ***

1 lock held by syz-executor144/9166:
 #0: ffff8880256d42c0 (&iint->mutex){+.+.}-{3:3}, at: process_measurement+0x3a8/0x17e0 security/integrity/ima/ima_main.c:253

stack backtrace:
CPU: 1 PID: 9166 Comm: syz-executor144 Not tainted 5.12.0-rc5-next-20210401-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x141/0x1d7 lib/dump_stack.c:120
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2129
 check_prev_add kernel/locking/lockdep.c:2938 [inline]
 check_prevs_add kernel/locking/lockdep.c:3061 [inline]
 validate_chain kernel/locking/lockdep.c:3676 [inline]
 __lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
 lock_acquire kernel/locking/lockdep.c:5512 [inline]
 lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1758 [inline]
 sb_start_write include/linux/fs.h:1828 [inline]
 mnt_want_write+0x6e/0x3e0 fs/namespace.c:375
 ovl_maybe_copy_up+0x11f/0x190 fs/overlayfs/copy_up.c:995
 ovl_open+0xba/0x270 fs/overlayfs/file.c:149
 do_dentry_open+0x4b9/0x11b0 fs/open.c:826
 vfs_open fs/open.c:940 [inline]
 dentry_open+0x132/0x1d0 fs/open.c:956
 ima_calc_file_hash+0x2d2/0x4b0 security/integrity/ima/ima_crypto.c:557
 ima_collect_measurement+0x4ca/0x570 security/integrity/ima/ima_api.c:252
 process_measurement+0xd1c/0x17e0 security/integrity/ima/ima_main.c:330
 ima_file_check+0xb9/0x100 security/integrity/ima/ima_main.c:499
 do_open fs/namei.c:3361 [inline]
 path_openat+0x15b5/0x27e0 fs/namei.c:3492
 do_filp_open+0x17e/0x3c0 fs/namei.c:3519
 do_sys_openat2+0x16d/0x420 fs/open.c:1187
 do_sys_open fs/open.c:1203 [inline]
 __do_sys_open fs/open.c:1211 [inline]
 __se_sys_open fs/open.c:1207 [inline]
 __x64_sys_open+0x119/0x1c0 fs/open.c:1207
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x446109
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe4412f12f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00000000004cb4c0 RCX: 0000000000446109
RDX: 0000000000000000 RSI: 0000000000000007 RDI: 00000000200001c0
RBP: 000000000049b06c R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 69662f7375622f2e
R13: 79706f636174656d R14: 0079616c7265766f R15: 00000000004cb4c8

Crashes (614):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-linux-next-kasan-gce-root 2021/04/03 19:18 linux-next 454c576c3f5e 6a81331a .config log report syz C possible deadlock in ovl_maybe_copy_up
ci-upstream-kasan-gce-root 2022/10/01 03:07 upstream 5a77386984b5 feb56351 .config log report info possible deadlock in ovl_maybe_copy_up
ci-upstream-kasan-gce-selinux-root 2022/09/27 04:40 upstream 3800a713b607 10323ddf .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream 2022/09/07 17:30 upstream 0066f1b0e275 c5b7bc57 .config log report info possible deadlock in ovl_maybe_copy_up
ci-upstream-kasan-gce-root 2022/08/27 11:40 upstream 3e5c673f0d75 07177916 .config log report info possible deadlock in ovl_maybe_copy_up
ci-upstream-kasan-gce-selinux-root 2022/08/07 06:35 upstream 200e340f2196 88e3a122 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/09 16:38 upstream 9b4509495418 90058bdc .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/09 15:10 upstream 9b4509495418 90058bdc .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/09 11:02 upstream 506357871c18 90058bdc .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/09 03:16 upstream 506357871c18 f3027468 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/08 17:57 upstream 26b1224903b3 f3027468 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/08 14:37 upstream 26b1224903b3 f3027468 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/08 02:36 upstream 0066f1b0e275 435aeef7 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/07 12:28 upstream 0066f1b0e275 c5b7bc57 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/07 00:03 upstream d2ec799d1c1b 5fc30c37 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/06 20:46 upstream d2ec799d1c1b 65aea2b9 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/06 12:47 upstream 53e99dcff61e 65aea2b9 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/05 13:08 upstream 7e18e42e4b28 922294ab .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/05 06:51 upstream 7e18e42e4b28 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/04 19:34 upstream 7726d4c3e60b 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/04 08:09 upstream 65eea2c060ae 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/04 03:27 upstream 65eea2c060ae 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/03 17:39 upstream d895ec7938c4 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/03 14:22 upstream d895ec7938c4 28811d0a .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/03 04:44 upstream 0b3acd1cc022 49e94a20 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/02 22:59 upstream 0b3acd1cc022 25194605 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/01 21:13 upstream 2880e1a175b9 86c46e46 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/01 17:06 upstream c5e4d5e99162 86c46e46 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/01 14:39 upstream c5e4d5e99162 86c46e46 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/09/01 04:30 upstream c5e4d5e99162 b01ec571 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/31 23:11 upstream c5e4d5e99162 51e54e30 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/31 19:05 upstream c5e4d5e99162 51e54e30 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/31 14:21 upstream dcf8e5633e2e 51e54e30 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/31 11:14 upstream dcf8e5633e2e 51e54e30 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/30 14:06 upstream dcf8e5633e2e 4a380809 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/30 11:29 upstream dcf8e5633e2e 4a380809 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/30 03:27 upstream dcf8e5633e2e 5bddaa04 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/30 00:55 upstream dcf8e5633e2e 5bddaa04 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/29 15:20 upstream b90cb1053190 94da0b6b .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/28 23:44 upstream 8379c0b31fbc 07177916 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/28 22:18 upstream 8379c0b31fbc 07177916 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/27 18:58 upstream 89b749d8552d 07177916 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/26 22:27 upstream 3e5c673f0d75 e5a303f1 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/26 20:52 upstream 3e5c673f0d75 e5a303f1 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/26 17:50 upstream 4c612826bec1 e5a303f1 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/26 15:50 upstream 4c612826bec1 e5a303f1 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/26 04:32 upstream 4c612826bec1 15195ea3 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/25 16:06 upstream c40e8341e3b3 e5fb9cf5 .config log report info possible deadlock in ovl_maybe_copy_up
ci-qemu-upstream-386 2022/08/24 01:30 upstream 95607ad99b5a cea8b0f7 .config log report info possible deadlock in ovl_maybe_copy_up
ci-upstream-linux-next-kasan-gce-root 2022/07/23 23:23 linux-next cb71b93c2dc3 22343af4 .config log report info possible deadlock in ovl_maybe_copy_up
ci-upstream-kasan-gce-root 2021/01/03 14:41 upstream 3516bd729358 79264ae3 .config log report info
ci-upstream-kasan-gce-selinux-root 2020/11/22 09:45 upstream a349e4c65960 0d27f508 .config log report info
ci-upstream-kasan-gce-root 2020/11/22 09:40 upstream a349e4c65960 0d27f508 .config log report info
* Struck through repros no longer work on HEAD.