WARNING in fanotify_handle_event

Status: fixed on 2019/07/10 21:40
Subsystems: fs
[Documentation on labels]
Reported-by: syzbot+c277e8e2f46414645508@syzkaller.appspotmail.com
Fix commit: c285a2f01d69 fanotify: update connector fsid cache on add mark
First crash: 2596d, last: 2593d
Cause bisection: introduced by (bisect log) :
commit 77115225acc67d9ac4b15f04dd138006b9cd1ef2
Author: Amir Goldstein <amir73il@gmail.com>
Date: Thu Jan 10 17:04:37 2019 +0000

  fanotify: cache fsid in fsnotify_mark_connector

Crash: WARNING in fanotify_handle_event (log)
Repro: C syz .config
  
▶ ▼ Discussions (4)
Title Replies (including bot) Last reply
[PATCH 5.1 00/55] 5.1.16-stable review 69 (69) 2019/07/04 05:27
[PATCH AUTOSEL 5.1 01/95] ARM: dts: dra76x: Disable rtc target module 95 (95) 2019/06/27 00:30
[PATCH] fanotify: update connector fsid cache on add mark 4 (4) 2019/06/19 13:13
WARNING in fanotify_handle_event 2 (4) 2019/06/19 07:11
▶ ▼ Similar bugs (4)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.6 WARNING in fanotify_handle_event origin:upstream -1 C error 3 53d 324d 0/2 upstream: reported C repro on 2025/09/02 05:01
upstream WARNING in fanotify_handle_event (2) exfat -1 C error 31 29d 618d 0/29 upstream: reported C repro on 2024/11/12 04:21
linux-5.15 WARNING in fanotify_handle_event origin:upstream -1 C error 4 32d 380d 0/3 upstream: reported C repro on 2025/07/08 09:14
linux-6.1 WARNING in fanotify_handle_event origin:upstream -1 C error 5 209d 380d 0/3 upstream: reported C repro on 2025/07/08 10:20
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/06/19 06:40 18m amir73il@gmail.com https://github.com/amir73il/linux.git fsnotify-fix-fsid-cache OK

Sample crash report:
WARNING: CPU: 1 PID: 8898 at fs/notify/fanotify/fanotify.c:359 fanotify_get_fsid fs/notify/fanotify/fanotify.c:359 [inline]
WARNING: CPU: 1 PID: 8898 at fs/notify/fanotify/fanotify.c:359 fanotify_handle_event+0x5ff/0xc6d fs/notify/fanotify/fanotify.c:418
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 8898 Comm: rs:main Q:Reg Not tainted 5.2.0-rc4+ #34
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x2cb/0x744 kernel/panic.c:219
 __warn.cold+0x20/0x4d kernel/panic.c:576
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:179 [inline]
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:272
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:291
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:986
RIP: 0010:fanotify_get_fsid fs/notify/fanotify/fanotify.c:359 [inline]
RIP: 0010:fanotify_handle_event+0x5ff/0xc6d fs/notify/fanotify/fanotify.c:418
Code: 06 00 00 8b 5b 40 31 ff 8b b5 fc fe ff ff 09 de 89 b5 f0 fe ff ff e8 f0 64 ab ff 8b b5 f0 fe ff ff 85 f6 75 55 e8 61 63 ab ff <0f> 0b e8 5a 63 ab ff 41 83 c6 01 bf 03 00 00 00 44 89 f6 e8 c9 64
RSP: 0018:ffff888089a37b80 EFLAGS: 00010293
RAX: ffff88808f5b6400 RBX: 0000000000000000 RCX: ffffffff81c55df0
RDX: 0000000000000000 RSI: ffffffff81c55dff RDI: 0000000000000005
RBP: ffff888089a37cc8 R08: ffff88808f5b6400 R09: 0000000000000000
R10: ffff88808f5b6cd0 R11: ffff88808f5b6400 R12: 0000000000000002
R13: 0000000000000000 R14: 0000000000000002 R15: dffffc0000000000
 send_to_group fs/notify/fsnotify.c:271 [inline]
 fsnotify+0x71f/0xbc0 fs/notify/fsnotify.c:409
 fsnotify_path include/linux/fsnotify.h:54 [inline]
 fsnotify_path include/linux/fsnotify.h:47 [inline]
 fsnotify_modify include/linux/fsnotify.h:230 [inline]
 vfs_write+0x4dc/0x580 fs/read_write.c:560
 ksys_write+0x14f/0x290 fs/read_write.c:611
 __do_sys_write fs/read_write.c:623 [inline]
 __se_sys_write fs/read_write.c:620 [inline]
 __x64_sys_write+0x73/0xb0 fs/read_write.c:620
 do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f11d3e0e19d
Code: d1 20 00 00 75 10 b8 01 00 00 00 0f 05 48 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 be fa ff ff 48 89 04 24 b8 01 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 07 fb ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007f11d23af000 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000078 RCX: 00007f11d3e0e19d
RDX: 0000000000000078 RSI: 0000000001b04a90 RDI: 0000000000000005
RBP: 0000000001b04a90 R08: 0000000001b04af8 R09: 31203731206e754a
R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000000
R13: 00007f11d23af480 R14: 0000000000000001 R15: 0000000001b04890
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/06/17 13:06 upstream 963172d9c7e8 442206d7 .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/06/17 12:54 upstream 963172d9c7e8 442206d7 .config console log report syz C ci-upstream-kasan-gce-root
2019/06/17 07:24 upstream 963172d9c7e8 442206d7 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/06/17 06:31 upstream 963172d9c7e8 442206d7 .config console log report ci-upstream-kasan-gce-selinux-root
2019/06/14 16:04 upstream c11fb13a117e 998ccc76 .config console log report ci-upstream-kasan-gce-selinux-root
* Struck through repros no longer work on HEAD.