syzbot


possible deadlock in reiserfs_dirty_inode

Status: upstream: reported on 2022/11/28 10:04
Labels: reiserfs (incorrect?)
Reported-by: syzbot+c319bb5b1014113a92cf@syzkaller.appspotmail.com
First crash: 186d, last: 16h28m
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] possible deadlock in reiserfs_dirty_inode 0 (1) 2022/11/28 10:04
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in reiserfs_dirty_inode 11 17d 57d 0/3 upstream: reported on 2023/04/06 01:23
linux-5.15 possible deadlock in reiserfs_dirty_inode 4 40d 74d 0/3 upstream: reported on 2023/03/19 20:48
linux-4.19 possible deadlock in reiserfs_dirty_inode reiserfs 2 107d 189d 0/1 upstream: reported on 2022/11/25 09:22

Sample crash report:
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
6.4.0-rc4-syzkaller-00099-g1874a42a7d74 #0 Not tainted
------------------------------------------------------
syz-executor.0/16824 is trying to acquire lock:
ffff88802a6b5b68 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x93/0x120 mm/memory.c:5731

but task is already holding lock:
ffff88807ad05090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7a/0xd0 fs/reiserfs/lock.c:27

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sbi->lock){+.+.}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       reiserfs_write_lock+0x7a/0xd0 fs/reiserfs/lock.c:27
       reiserfs_dirty_inode+0xf2/0x240 fs/reiserfs/super.c:704
       __mark_inode_dirty+0x305/0xd90 fs/fs-writeback.c:2424
       generic_update_time fs/inode.c:1859 [inline]
       inode_update_time fs/inode.c:1872 [inline]
       touch_atime+0x3fe/0x680 fs/inode.c:1944
       file_accessed include/linux/fs.h:2198 [inline]
       generic_file_mmap+0xc0/0x120 mm/filemap.c:3600
       call_mmap include/linux/fs.h:1873 [inline]
       mmap_region+0xe65/0x2250 mm/mmap.c:2652
       do_mmap+0x8c9/0xf70 mm/mmap.c:1394
       vm_mmap_pgoff+0x1db/0x410 mm/util.c:543
       ksys_mmap_pgoff+0x4f9/0x6d0 mm/mmap.c:1440
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3113 [inline]
       check_prevs_add kernel/locking/lockdep.c:3232 [inline]
       validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847
       __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
       __might_fault+0xba/0x120 mm/memory.c:5732
       reiserfs_ioctl+0x121/0x340 fs/reiserfs/ioctl.c:96
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->lock);
                               lock(&mm->mmap_lock);
                               lock(&sbi->lock);
  rlock(&mm->mmap_lock);

 *** DEADLOCK ***

1 lock held by syz-executor.0/16824:
 #0: ffff88807ad05090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7a/0xd0 fs/reiserfs/lock.c:27

stack backtrace:
CPU: 0 PID: 16824 Comm: syz-executor.0 Not tainted 6.4.0-rc4-syzkaller-00099-g1874a42a7d74 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3113 [inline]
 check_prevs_add kernel/locking/lockdep.c:3232 [inline]
 validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847
 __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
 __might_fault+0xba/0x120 mm/memory.c:5732
 reiserfs_ioctl+0x121/0x340 fs/reiserfs/ioctl.c:96
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f6e8028c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6e80f07168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f6e803abf80 RCX: 00007f6e8028c169
RDX: 0000000020000040 RSI: 0000000080087601 RDI: 0000000000000005
RBP: 00007f6e802e7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fffdee6209f R14: 00007f6e80f07300 R15: 0000000000022000
 </TASK>

Crashes (142):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/06/01 23:25 upstream 1874a42a7d74 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/06/01 06:22 upstream 48b1320a674e babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/31 20:13 upstream 48b1320a674e babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/31 04:46 upstream afead42fdfca 09898419 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/30 23:44 upstream afead42fdfca df37c7f1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/30 16:13 upstream 8b817fded42d df37c7f1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/29 22:55 upstream 8b817fded42d cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/29 14:40 upstream 8b817fded42d cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/27 08:57 upstream 49572d536129 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/27 00:15 upstream 0d85b27b0cc6 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/26 05:11 upstream 9db898594c54 b40ef614 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/26 00:35 upstream 9db898594c54 0513b3e6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/25 08:57 upstream 933174ae28ba 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/24 03:12 upstream 27e462c8fad4 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/23 13:10 upstream ae8373a5add4 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/22 09:50 upstream 44c026a73be8 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/21 00:38 upstream 0dd2a6fb1e34 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/20 05:42 upstream cbd6ac3837cd 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/18 12:09 upstream 4d6d4c7f541d 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/18 01:01 upstream 1b66c114d161 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/17 19:14 upstream 1b66c114d161 eaac4681 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/16 15:41 upstream f1fcbaa18b28 11c89444 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/15 19:53 upstream f1fcbaa18b28 c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/13 19:44 upstream 9a48d6046722 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/13 12:05 upstream 9a48d6046722 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/11 17:30 upstream d295b66a7b66 0fbd49f4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/11 02:28 upstream d295b66a7b66 14b12a99 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/10 06:44 upstream 16a8829130ca 1964022b .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/09 19:39 upstream 1dc3731daf1f 30aa2a7e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/09 16:47 upstream ba0ad6ed89fd 30aa2a7e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/08 08:24 upstream 17784de648be 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/07 01:06 upstream 2e1e1337881b 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/04 07:05 upstream fa31fc82fb77 5b7ff9dd .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/05/03 21:00 upstream 348551ddaf31 b5918830 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/29 05:16 upstream 22b8cc3e78f5 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_dirty_inode
2023/04/28 17:30 upstream 33afd4b76393 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/28 11:51 upstream 91ec4b0d11fe 70a605de .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/28 04:34 upstream 91ec4b0d11fe 70a605de .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/28 03:11 upstream 91ec4b0d11fe 6f3d6fa7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/27 12:34 upstream 6e98b09da931 6f3d6fa7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/26 13:31 upstream 0cfd8703e7da 8d843721 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/26 10:59 upstream 0cfd8703e7da 8d843721 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in reiserfs_dirty_inode
2023/04/07 04:58 upstream f2afccfefe7b 00ce4c67 .config console log report info ci-qemu-upstream possible deadlock in reiserfs_dirty_inode
2022/12/15 23:44 upstream 785d21ba2f44 6f9c033e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in reiserfs_dirty_inode
2022/11/27 18:59 upstream faf68e3523c2 74a66371 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in reiserfs_dirty_inode
2023/04/09 02:04 upstream a79d5c76f705 71147e29 .config console log report info ci-qemu-upstream-386 possible deadlock in reiserfs_dirty_inode
2023/04/26 21:37 linux-next b7455b10da76 19a3dabe .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in reiserfs_dirty_inode
2023/06/01 18:13 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci eb0f1697d729 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in reiserfs_dirty_inode
2023/05/19 03:16 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci f1fcbaa18b28 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in reiserfs_dirty_inode
2023/05/17 23:50 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci f1fcbaa18b28 eaac4681 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in reiserfs_dirty_inode
* Struck through repros no longer work on HEAD.