======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.7.798/18467 is trying to acquire lock:
ffff888067fd9918 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1575

but task is already holding lock:
ffff888038fc4118 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3af/0x700 fs/ocfs2/journal.c:369

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3af/0x700 fs/ocfs2/journal.c:369
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:801 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:950
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1100
       ocfs2_mknod+0xe5f/0x21a0 fs/ocfs2/namei.c:351
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:662
       vfs_mkdir+0x408/0x620 fs/namei.c:5439
       filename_mkdirat+0x289/0x520 fs/namei.c:5472
       __do_sys_mkdir fs/namei.c:5499 [inline]
       __se_sys_mkdir+0x34/0x150 fs/namei.c:5496
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#5){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_xattr_set+0xe9c/0x13a0 fs/ocfs2/xattr.c:3889
       __vfs_removexattr+0x41c/0x450 fs/xattr.c:544
       __vfs_removexattr_locked+0xe2/0x280 fs/xattr.c:579
       vfs_removexattr+0x7f/0x230 fs/xattr.c:601
       ovl_do_removexattr fs/overlayfs/overlayfs.h:344 [inline]
       ovl_removexattr fs/overlayfs/overlayfs.h:352 [inline]
       ovl_make_workdir fs/overlayfs/super.c:756 [inline]
       ovl_get_workdir+0xe0e/0x1980 fs/overlayfs/super.c:836
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
       vfs_get_super fs/super.c:1390 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1409
       vfs_get_tree+0x92/0x2a0 fs/super.c:1932
       fc_mount fs/namespace.c:1278 [inline]
       do_new_mount_fc fs/namespace.c:3885 [inline]
       do_new_mount+0x325/0xb00 fs/namespace.c:3961
       do_mount fs/namespace.c:4325 [inline]
       __do_sys_mount fs/namespace.c:4543 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4520
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1575
       __vfs_getxattr+0x412/0x440 fs/xattr.c:446
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3679
       security_d_instantiate+0x106/0x1d0 security/security.c:3703
       d_instantiate+0x54/0xb0 fs/dcache.c:2182
       ocfs2_mknod+0x199c/0x21a0 fs/ocfs2/namei.c:454
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:662
       vfs_mkdir+0x408/0x620 fs/namei.c:5439
       filename_mkdirat+0x289/0x520 fs/namei.c:5472
       __do_sys_mkdirat fs/namei.c:5493 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5490
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> sb_internal#5 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&journal->j_trans_barrier);
                               lock(sb_internal#5);
                               lock(&journal->j_trans_barrier);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

locks held by syz.7.798/18467: 8, last CPU#0:
 #0: ffff888022736510 (sb_writers#38){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:527
 #1: ffff888067d75f40 (&type->i_mutex_dir_key#29/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1069 [inline]
 #1: ffff888067d75f40 (&type->i_mutex_dir_key#29/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2947 [inline]
 #1: ffff888067d75f40 (&type->i_mutex_dir_key#29/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2971 [inline]
 #1: ffff888067d75f40 (&type->i_mutex_dir_key#29/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:5121
 #2: ffff888067d51c40 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #2: ffff888067d51c40 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x170/0x4850 fs/ocfs2/suballoc.c:904
 #3: ffff888057fc7000 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #3: ffff888057fc7000 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x170/0x4850 fs/ocfs2/suballoc.c:904
 #4: ffff888067d52d00 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #4: ffff888067d52d00 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x11f/0x2680 fs/ocfs2/localalloc.c:636
 #5: ffff888022736800 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_mknod+0xeed/0x21a0 fs/ocfs2/namei.c:365
 #6: ffff888038fc4118 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3af/0x700 fs/ocfs2/journal.c:369
 #7: ffff88802d1bebb0 (jbd2_handle#2){.+.+}-{0:0}, at: start_this_handle+0x1fbf/0x2200 fs/jbd2/transaction.c:444

stack backtrace:
CPU: 0 UID: 0 PID: 18467 Comm: syz.7.798 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/07/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 down_read+0x97/0x200 kernel/locking/rwsem.c:1574
 ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1575
 __vfs_getxattr+0x412/0x440 fs/xattr.c:446
 smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298
 smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3679
 security_d_instantiate+0x106/0x1d0 security/security.c:3703
 d_instantiate+0x54/0xb0 fs/dcache.c:2182
 ocfs2_mknod+0x199c/0x21a0 fs/ocfs2/namei.c:454
 ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:662
 vfs_mkdir+0x408/0x620 fs/namei.c:5439
 filename_mkdirat+0x289/0x520 fs/namei.c:5472
 __do_sys_mkdirat fs/namei.c:5493 [inline]
 __se_sys_mkdirat+0x35/0x150 fs/namei.c:5490
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f27aa2ed3c7
Code: 00 66 90 48 89 f2 b9 00 01 00 00 48 89 fe bf 9c ff ff ff e9 db f7 ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f27a8503e58 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007f27a8503ee0 RCX: 00007f27aa2ed3c7
RDX: 00000000000001ff RSI: 000020000000f980 RDI: 00000000ffffff9c
RBP: 000020000000f940 R08: 000020000000fa00 R09: 0000000000000000
R10: 000020000000f940 R11: 0000000000000246 R12: 000020000000f980
R13: 00007f27a8503ea0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>