syzbot


KASAN: use-after-free Read in usb_autopm_put_interface

Status: fixed on 2019/11/06 12:39
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+cd24df4d075c319ebfc5@syzkaller.appspotmail.com
Fix commit: 7a7591979748 USB: usblp: fix use-after-free on disconnect
First crash: 1742d, last: 1728d
Discussions (8)
Title Replies (including bot) Last reply
[PATCH 3.16 000/136] 3.16.80-rc1 review 140 (140) 2019/12/23 14:00
[PATCH 4.19 00/93] 4.19.81-stable review 107 (107) 2019/11/09 15:53
[PATCH 4.14 000/119] 4.14.151-stable review 132 (132) 2019/11/01 18:48
[PATCH 4.9 00/49] 4.9.198-stable review 55 (55) 2019/10/29 15:17
[PATCH 4.4 00/41] 4.4.198-stable review 52 (52) 2019/10/29 13:29
[PATCH 5.3 000/197] 5.3.8-stable review 203 (203) 2019/10/29 13:03
[PATCH] USB: usblp: fix use-after-free on disconnect 1 (1) 2019/10/15 17:55
KASAN: use-after-free Read in usb_autopm_put_interface 0 (1) 2019/10/15 15:51

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in usb_autopm_put_interface+0x70/0x90 drivers/usb/core/driver.c:1629
Read of size 8 at addr ffff8881c8d30070 by task syz-executor943/2065

CPU: 0 PID: 2065 Comm: syz-executor943 Not tainted 5.4.0-rc3+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 print_address_description.constprop.0+0x36/0x50 mm/kasan/report.c:374
 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:506
 kasan_report+0xe/0x20 mm/kasan/common.c:634
 usb_autopm_put_interface+0x70/0x90 drivers/usb/core/driver.c:1629
 usblp_release+0x121/0x1d0 drivers/usb/class/usblp.c:467
 __fput+0x2d7/0x840 fs/file_table.c:280
 task_work_run+0x13f/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x8c4/0x2c00 kernel/exit.c:817
 do_group_exit+0x125/0x340 kernel/exit.c:921
 get_signal+0x466/0x23d0 kernel/signal.c:2734
 do_signal+0x88/0x14e0 arch/x86/kernel/signal.c:815
 exit_to_usermode_loop+0x1a2/0x200 arch/x86/entry/common.c:159
 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:274 [inline]
 do_syscall_64+0x45f/0x580 arch/x86/entry/common.c:300
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x447497
Code: Bad RIP value.
RSP: 002b:00007fb25debe548 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: fffffffffffffffc RBX: 0000000000000003 RCX: 0000000000447497
RDX: 00007fb25debe970 RSI: 0000000080085502 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007fb25debf700 R09: 00007fb25debf700
R10: 00007fb25debf9d0 R11: 0000000000000246 R12: 00000000006dcc3c
R13: 00007ffff4c3b9af R14: 00007fb25debf9c0 R15: 0000000000000001

Allocated by task 1742:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:510 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:483
 kmalloc include/linux/slab.h:556 [inline]
 kzalloc include/linux/slab.h:690 [inline]
 usb_set_configuration+0x2c4/0x1670 drivers/usb/core/message.c:1846
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0xae6/0x16f0 drivers/base/core.c:2201
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5183 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5323 [inline]
 port_event drivers/usb/core/hub.c:5469 [inline]
 hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 1745:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 kasan_set_free_info mm/kasan/common.c:332 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:471
 slab_free_hook mm/slub.c:1424 [inline]
 slab_free_freelist_hook mm/slub.c:1475 [inline]
 slab_free mm/slub.c:3018 [inline]
 kfree+0xe4/0x320 mm/slub.c:3967
 device_release+0x71/0x200 drivers/base/core.c:1100
 kobject_cleanup lib/kobject.c:693 [inline]
 kobject_release lib/kobject.c:722 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x171/0x280 lib/kobject.c:739
 put_device+0x1b/0x30 drivers/base/core.c:2300
 usb_disable_device+0x2ce/0x690 drivers/usb/core/message.c:1244
 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:5034 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5323 [inline]
 port_event drivers/usb/core/hub.c:5469 [inline]
 hub_event+0x16ca/0x37e0 drivers/usb/core/hub.c:5551
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff8881c8d30000
 which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 112 bytes inside of
 2048-byte region [ffff8881c8d30000, ffff8881c8d30800)
The buggy address belongs to the page:
page:ffffea0007234c00 refcount:1 mapcount:0 mapping:ffff8881da00c000 index:0x0 compound_mapcount: 0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 dead000000000100 dead000000000122 ffff8881da00c000
raw: 0000000000000000 0000000000080008 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881c8d2ff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff8881c8d2ff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8881c8d30000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                             ^
 ffff8881c8d30080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881c8d30100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (2373):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/10/22 05:43 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 c59a7cd8 .config console log report syz C ci2-upstream-usb
2019/10/14 13:32 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 a6aef847 .config console log report syz C ci2-upstream-usb
2019/10/28 17:05 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 439d7b14 .config console log report ci2-upstream-usb
2019/10/28 15:39 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 15:29 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 14:11 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 13:10 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 12:09 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 11:20 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 10:07 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 09:06 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 08:02 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 06:39 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 06:28 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 05:21 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 04:13 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 03:01 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 01:39 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/28 00:42 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 23:42 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 22:23 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 20:44 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 19:11 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 18:21 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 17:16 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 15:55 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 14:05 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 12:47 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 11:43 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 10:39 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 08:58 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 07:35 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 06:31 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 05:18 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 05:07 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 03:47 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 02:44 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 02:28 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 01:19 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/27 00:03 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/26 22:16 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/26 21:29 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/26 20:05 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
2019/10/26 19:02 https://github.com/google/kasan.git usb-fuzzer 22be26f76193 25bb509e .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.