syzbot


KASAN: use-after-free Read in iowarrior_disconnect

Status: fixed on 2019/11/20 22:01
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+cfe6d93e0abab9a0de05@syzkaller.appspotmail.com
Fix commit: edc4746f253d USB: iowarrior: fix use-after-free on disconnect
First crash: 1706d, last: 1646d
Duplicate bugs (4)
duplicates (4):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
KASAN: use-after-free Read in iowarrior_release usb C 3 1704d 1702d 0/26 closed as dup on 2019/09/20 15:39
KASAN: use-after-free Write in iowarrior_disconnect usb 1 1689d 1687d 0/26 closed as dup on 2019/09/03 12:14
KASAN: invalid-free in iowarrior_disconnect usb 26 1688d 1702d 0/26 closed as dup on 2019/09/05 12:12
KASAN: use-after-free Read in iowarrior_callback usb 1 1704d 1702d 0/26 closed as dup on 2019/09/20 15:38
Discussions (4)
Title Replies (including bot) Last reply
KASAN: use-after-free Read in iowarrior_disconnect 7 (9) 2019/11/19 14:57
Reminder: 67 active syzbot reports in usb subsystem 1 (1) 2019/10/04 03:38
Reminder: 52 active syzbot reports in usb subsystem 4 (4) 2019/09/19 19:01
Reminder: 52 active syzbot reports in usb subsystem 1 (1) 2019/08/22 03:28
Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/08/19 15:24 10m oneukum@suse.com patch https://github.com/google/kasan.git d0847550 report log

Sample crash report:
usb 1-1: USB disconnect, device number 8
==================================================================
BUG: KASAN: use-after-free in __mutex_lock_common kernel/locking/mutex.c:912 [inline]
BUG: KASAN: use-after-free in __mutex_lock+0xf23/0x1360 kernel/locking/mutex.c:1077
Read of size 8 at addr ffff8881cebb42d8 by task kworker/1:1/21

CPU: 1 PID: 21 Comm: kworker/1:1 Not tainted 5.3.0-rc5+ #28
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 print_address_description+0x6a/0x32c mm/kasan/report.c:351
 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482
 kasan_report+0xe/0x12 mm/kasan/common.c:612
 __mutex_lock_common kernel/locking/mutex.c:912 [inline]
 __mutex_lock+0xf23/0x1360 kernel/locking/mutex.c:1077
 iowarrior_disconnect+0xf0/0x2c0 drivers/usb/misc/iowarrior.c:878
 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
 __device_release_driver drivers/base/dd.c:1134 [inline]
 device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165
 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556
 device_del+0x420/0xb10 drivers/base/core.c:2339
 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:4949 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Allocated by task 17:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:487 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460
 kmalloc include/linux/slab.h:552 [inline]
 kzalloc include/linux/slab.h:748 [inline]
 iowarrior_probe+0x7a/0x10b2 drivers/usb/misc/iowarrior.c:753
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 1814:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:449
 slab_free_hook mm/slub.c:1423 [inline]
 slab_free_freelist_hook mm/slub.c:1474 [inline]
 slab_free mm/slub.c:3016 [inline]
 kfree+0xe4/0x2f0 mm/slub.c:3957
 iowarrior_delete drivers/usb/misc/iowarrior.c:246 [inline]
 iowarrior_release+0x187/0x280 drivers/usb/misc/iowarrior.c:670
 __fput+0x2d7/0x840 fs/file_table.c:280
 task_work_run+0x13f/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x8ef/0x2c00 kernel/exit.c:879
 do_group_exit+0x125/0x340 kernel/exit.c:983
 __do_sys_exit_group kernel/exit.c:994 [inline]
 __se_sys_exit_group kernel/exit.c:992 [inline]
 __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:992
 do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8881cebb4280
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 88 bytes inside of
 512-byte region [ffff8881cebb4280, ffff8881cebb4480)
The buggy address belongs to the page:
page:ffffea00073aed00 refcount:1 mapcount:0 mapping:ffff8881da002500 index:0x0 compound_mapcount: 0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 ffffea00073a4100 0000000c0000000c ffff8881da002500
raw: 0000000000000000 00000000000c000c 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881cebb4180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881cebb4200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8881cebb4280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                    ^
 ffff8881cebb4300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881cebb4380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (3056):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/09/02 12:53 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 db7c31ca .config console log report syz C ci2-upstream-usb
2019/09/01 21:34 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/09/01 19:50 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/09/01 17:22 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/09/01 07:16 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/09/01 03:12 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/08/31 19:05 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/08/31 17:39 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/08/31 14:26 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bad3cce2 .config console log report syz C ci2-upstream-usb
2019/08/30 08:45 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 cd626f3b .config console log report syz C ci2-upstream-usb
2019/08/29 18:19 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 cd626f3b .config console log report syz C ci2-upstream-usb
2019/08/29 09:35 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 40203c15 .config console log report syz C ci2-upstream-usb
2019/08/28 19:16 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 1eb076e9 .config console log report syz C ci2-upstream-usb
2019/08/25 13:29 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report syz C ci2-upstream-usb
2019/08/25 12:09 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report syz C ci2-upstream-usb
2019/08/24 21:41 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 d21c5d9d .config console log report syz C ci2-upstream-usb
2019/08/24 10:13 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report syz C ci2-upstream-usb
2019/08/24 05:38 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report syz C ci2-upstream-usb
2019/08/23 21:21 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report syz C ci2-upstream-usb
2019/08/22 14:19 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 c6c81a0b .config console log report syz C ci2-upstream-usb
2019/08/21 19:19 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 4ea67ff8 .config console log report syz C ci2-upstream-usb
2019/08/21 09:21 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 4ea67ff8 .config console log report syz C ci2-upstream-usb
2019/08/17 06:16 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 22:54 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/31 05:34 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 bcd7bcc2 .config console log report syz ci2-upstream-usb
2019/08/30 10:09 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 cd626f3b .config console log report syz ci2-upstream-usb
2019/08/29 22:59 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 cd626f3b .config console log report syz ci2-upstream-usb
2019/08/28 01:21 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 fd37b39e .config console log report syz ci2-upstream-usb
2019/08/24 12:46 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report syz ci2-upstream-usb
2019/08/19 23:52 https://github.com/google/kasan.git usb-fuzzer e06ce4da6fa7 ae348fb7 .config console log report syz ci2-upstream-usb
2019/08/19 13:02 https://github.com/google/kasan.git usb-fuzzer e06ce4da6fa7 b8ceabfc .config console log report syz ci2-upstream-usb
2019/10/14 10:16 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 a6aef847 .config console log report ci2-upstream-usb
2019/10/14 08:49 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/14 05:10 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/14 03:24 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/14 01:59 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 22:55 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 21:39 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 20:28 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 14:18 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 12:59 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 10:58 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 07:07 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/13 06:05 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/13 04:49 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/13 03:26 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/13 00:47 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 20:30 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 18:34 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 15:37 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 12:01 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 10:56 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 10:39 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 09:31 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 07:53 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 03:47 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 01:46 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 20:15 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 18:21 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 14:41 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 08:12 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 07:06 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 06:12 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 02:56 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 01:46 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/10 19:04 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 d52eff28 .config console log report ci2-upstream-usb
2019/10/10 14:51 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 d52eff28 .config console log report ci2-upstream-usb
2019/10/10 07:46 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/10 05:02 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/10 03:50 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/10 02:11 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/10 01:05 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 23:35 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 21:30 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 20:14 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/08/15 02:47 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 0d298d6b .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.