syzbot


KASAN: slab-out-of-bounds Read in ds_probe

Status: fixed on 2019/05/27 12:48
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+d65f673b847a1a96cdba@syzkaller.appspotmail.com
Fix commit: c114944d7d67 USB: w1 ds2490: Fix bug caused by improper use of altsetting array
First crash: 1864d, last: 1825d
Duplicate bugs (1)
duplicates (1):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
KASAN: use-after-free Read in ds_probe usb C 80 1824d 1866d 0/26 closed as dup on 2019/08/13 12:54
Discussions (9)
Title Replies (including bot) Last reply
[PATCH 3.16 000/157] 3.16.72-rc1 review 162 (162) 2019/08/11 15:25
[PATCH 4.4 000/266] 4.4.180-stable review 282 (282) 2019/05/17 09:42
[PATCH 3.18 00/86] 3.18.140-stable review 93 (93) 2019/05/16 14:59
[PATCH 5.0 000/122] 5.0.14-stable review 134 (134) 2019/05/08 06:36
[PATCH 4.19 00/99] 4.19.41-stable review 111 (111) 2019/05/08 06:35
[PATCH 4.14 00/75] 4.14.117-stable review 81 (81) 2019/05/07 22:47
[PATCH 4.9 00/62] 4.9.174-stable review 73 (73) 2019/05/07 20:34
USB: w1 ds2490: Fix bug caused by improper use of altsetting array 1 (1) 2019/04/22 15:16
KASAN: slab-out-of-bounds Read in ds_probe 1 (3) 2019/04/19 20:17
Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/04/19 19:39 36m stern@rowland.harvard.edu patch https://github.com/google/kasan.git usb-fuzzer OK

Sample crash report:
usb 1-1: config 0 has no interface number 0
usb 1-1: New USB device found, idVendor=04fa, idProduct=2490, bcdDevice=74.f9
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
==================================================================
BUG: KASAN: slab-out-of-bounds in ds_probe+0x604/0x760 drivers/w1/masters/ds2490.c:1019
Read of size 1 at addr ffff88809fb50fe2 by task kworker/1:1/21

CPU: 1 PID: 21 Comm: kworker/1:1 Not tainted 5.1.0-rc5-319617-gd34f951 #4
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xe8/0x16e lib/dump_stack.c:113
 print_address_description+0x6c/0x236 mm/kasan/report.c:187
 kasan_report.cold+0x1a/0x3c mm/kasan/report.c:317
 ds_probe+0x604/0x760 drivers/w1/masters/ds2490.c:1019
 usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021
 generic_probe+0xa2/0xda drivers/usb/core/generic.c:210
 usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x1398/0x3b00 drivers/usb/core/hub.c:5432
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 worker_thread+0x9b/0xe20 kernel/workqueue.c:2415
 kthread+0x313/0x420 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352

Allocated by task 21:
 set_track mm/kasan/common.c:87 [inline]
 __kasan_kmalloc mm/kasan/common.c:497 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:470
 kmalloc include/linux/slab.h:552 [inline]
 kzalloc include/linux/slab.h:742 [inline]
 usb_parse_configuration drivers/usb/core/config.c:710 [inline]
 usb_get_configuration+0xc4c/0x32b0 drivers/usb/core/config.c:882
 usb_enumerate_device drivers/usb/core/hub.c:2367 [inline]
 usb_new_device+0x2fe/0x450 drivers/usb/core/hub.c:2503
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x1398/0x3b00 drivers/usb/core/hub.c:5432
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 worker_thread+0x9b/0xe20 kernel/workqueue.c:2415
 kthread+0x313/0x420 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352

Freed by task 4095:
 set_track mm/kasan/common.c:87 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:459
 slab_free_hook mm/slub.c:1429 [inline]
 slab_free_freelist_hook+0x5e/0x140 mm/slub.c:1456
 slab_free mm/slub.c:3003 [inline]
 kfree+0xce/0x280 mm/slub.c:3958
 security_task_free+0x9a/0xf0 security/security.c:1470
 __put_task_struct+0xec/0x4d0 kernel/fork.c:724
 put_task_struct include/linux/sched/task.h:98 [inline]
 delayed_put_task_struct+0x189/0x290 kernel/exit.c:181
 __rcu_reclaim kernel/rcu/rcu.h:227 [inline]
 rcu_do_batch kernel/rcu/tree.c:2475 [inline]
 invoke_rcu_callbacks kernel/rcu/tree.c:2788 [inline]
 rcu_core+0x843/0x1a90 kernel/rcu/tree.c:2769
 __do_softirq+0x22a/0x8cd kernel/softirq.c:293

The buggy address belongs to the object at ffff88809fb50f60
 which belongs to the cache kmalloc-64 of size 64
The buggy address is located 66 bytes to the right of
 64-byte region [ffff88809fb50f60, ffff88809fb50fa0)
The buggy address belongs to the page:
page:ffffea00027ed400 count:1 mapcount:0 mapping:ffff88812c3f5600 index:0xffff88809fb50de0
flags: 0xfff00000000200(slab)
raw: 00fff00000000200 ffffea00027dbe80 0000001100000011 ffff88812c3f5600
raw: ffff88809fb50de0 00000000802a0028 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809fb50e80: fc fc fc fc 00 00 00 00 00 00 fc fc fc fc fc fc
 ffff88809fb50f00: fb fb fb fb fb fb fb fb fc fc fc fc 00 00 00 00
>ffff88809fb50f80: 00 00 fc fc fc fc fc fc fc fc fc fc fc fc fc fc
                                                       ^
 ffff88809fb51000: fb fb fb fb fb fb fb fb fb fb fc fc fc fc fb fb
 ffff88809fb51080: fb fb fb fb fb fb fb fb fc fc fc fc fb fb fb fb
==================================================================

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/04/18 12:56 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa b0e8efcb .config console log report syz C ci2-upstream-usb
2019/04/18 06:23 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa b0e8efcb .config console log report syz C ci2-upstream-usb
2019/04/16 22:46 https://github.com/google/kasan.git usb-fuzzer 9a33b36996cb 505ab413 .config console log report syz C ci2-upstream-usb
2019/05/25 11:45 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 85c57315 .config console log report ci2-upstream-usb
2019/04/22 02:55 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa b0e8efcb .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.