syzbot

ocfs2: Slot 0 on device (7,5) was already allocated to this node!
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.5.526/7679 is trying to acquire lock:
ffff888059a36d80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff888059a36d80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_remove_inode+0x15b/0x860 fs/ocfs2/inode.c:733

but task is already holding lock:
ffff888047c3a640 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff888047c3a640 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2cd/0x11f0 fs/ocfs2/inode.c:854

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write+0x2cd/0xee0 fs/ocfs2/aops.c:2306
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2404
       dio_complete+0x224/0x950 fs/direct-io.c:281
       __blockdev_direct_IO+0x309f/0x3ae0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2441
       generic_file_direct_write+0x198/0x410 mm/filemap.c:4248
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4417
       ocfs2_file_write_iter+0xd79/0x2160 fs/ocfs2/file.c:2475
       iter_file_splice_write+0x82b/0x10a0 fs/splice.c:738
       do_splice_from fs/splice.c:938 [inline]
       direct_splice_actor+0x192/0x6c0 fs/splice.c:1161
       splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105
       do_splice_direct_actor fs/splice.c:1204 [inline]
       do_splice_direct+0x174/0x240 fs/splice.c:1230
       do_sendfile+0xadc/0xe20 fs/read_write.c:1370
       __do_sys_sendfile64 fs/read_write.c:1431 [inline]
       __se_sys_sendfile64 fs/read_write.c:1417 [inline]
       __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       ocfs2_create_local_dquot+0x157/0xb30 fs/ocfs2/quota_local.c:1227
       ocfs2_acquire_dquot+0x7e5/0xae0 fs/ocfs2/quota_global.c:883
       dqget+0x666/0x1130 fs/quota/dquot.c:980
       __dquot_initialize+0x5a5/0xd70 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0xe9/0x1b0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xd5f/0x2750 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0xf2/0x3f0 fs/ocfs2/namei.c:660
       vfs_mkdir+0x729/0xb50 fs/namei.c:5139
       do_mkdirat+0x435/0x590 fs/namei.c:5173
       __do_sys_mkdirat fs/namei.c:5195 [inline]
       __se_sys_mkdirat fs/namei.c:5193 [inline]
       __x64_sys_mkdirat+0x112/0x170 fs/namei.c:5193
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:614 [inline]
       __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776
       wait_on_dquot fs/quota/dquot.c:357 [inline]
       dqget+0x5c7/0x1130 fs/quota/dquot.c:975
       __dquot_initialize+0x5a5/0xd70 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0xe9/0x1b0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xd5f/0x2750 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0xf2/0x3f0 fs/ocfs2/namei.c:660
       vfs_mkdir+0x729/0xb50 fs/namei.c:5139
       do_mkdirat+0x435/0x590 fs/namei.c:5173
       __do_sys_mkdirat fs/namei.c:5195 [inline]
       __se_sys_mkdirat fs/namei.c:5193 [inline]
       __x64_sys_mkdirat+0x112/0x170 fs/namei.c:5193
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x17c/0x330 kernel/locking/lockdep.c:5825
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_remove_inode+0x15b/0x860 fs/ocfs2/inode.c:733
       ocfs2_wipe_inode+0x6db/0x11f0 fs/ocfs2/inode.c:896
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x7b9/0x13c0 fs/ocfs2/inode.c:1299
       evict+0x3c2/0xad0 fs/inode.c:837
       iput_final fs/inode.c:1954 [inline]
       iput.part.0+0x624/0x1150 fs/inode.c:2006
       iput+0x35/0x40 fs/inode.c:1969
       ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
       dentry_unlink_inode+0x282/0x490 fs/dcache.c:465
       __dentry_kill+0x1d0/0x600 fs/dcache.c:670
       finish_dput+0x76/0x480 fs/dcache.c:879
       dput.part.0+0x456/0x570 fs/dcache.c:928
       dput+0x1f/0x30 fs/dcache.c:920
       end_renaming fs/namei.c:4061 [inline]
       do_renameat2+0x802/0xa10 fs/namei.c:6058
       __do_sys_rename fs/namei.c:6099 [inline]
       __se_sys_rename fs/namei.c:6097 [inline]
       __x64_sys_rename+0x17f/0x210 fs/namei.c:6097
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE] --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
  lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);

 *** DEADLOCK ***

3 locks held by syz.5.526/7679:
 #0: ffff8880518ce420 (sb_writers#17){.+.+}-{0:0}, at: do_renameat2+0x3c7/0xa10 fs/namei.c:6020
 #1: ffff888053ba0bd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0xe4/0x2e0 fs/ocfs2/dlmglue.c:2875
 #2: ffff888047c3a640 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff888047c3a640 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2cd/0x11f0 fs/ocfs2/inode.c:854

stack backtrace:
CPU: 0 UID: 0 PID: 7679 Comm: syz.5.526 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/13/2026
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120
 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043
 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x17c/0x330 kernel/locking/lockdep.c:5825
 down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
 inode_lock include/linux/fs.h:1027 [inline]
 ocfs2_remove_inode+0x15b/0x860 fs/ocfs2/inode.c:733
 ocfs2_wipe_inode+0x6db/0x11f0 fs/ocfs2/inode.c:896
 ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
 ocfs2_evict_inode+0x7b9/0x13c0 fs/ocfs2/inode.c:1299
 evict+0x3c2/0xad0 fs/inode.c:837
 iput_final fs/inode.c:1954 [inline]
 iput.part.0+0x624/0x1150 fs/inode.c:2006
 iput+0x35/0x40 fs/inode.c:1969
 ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
 dentry_unlink_inode+0x282/0x490 fs/dcache.c:465
 __dentry_kill+0x1d0/0x600 fs/dcache.c:670
 finish_dput+0x76/0x480 fs/dcache.c:879
 dput.part.0+0x456/0x570 fs/dcache.c:928
 dput+0x1f/0x30 fs/dcache.c:920
 end_renaming fs/namei.c:4061 [inline]
 do_renameat2+0x802/0xa10 fs/namei.c:6058
 __do_sys_rename fs/namei.c:6099 [inline]
 __se_sys_rename fs/namei.c:6097 [inline]
 __x64_sys_rename+0x17f/0x210 fs/namei.c:6097
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe92df9acb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe92ee16028 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007fe92e215fa0 RCX: 00007fe92df9acb9
RDX: 0000000000000000 RSI: 0000200000000200 RDI: 00002000000003c0
RBP: 00007fe92e008bf7 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe92e216038 R14: 00007fe92e215fa0 R15: 00007fff39ca8f88
 </TASK>
(syz.5.526,7679,0):ocfs2_check_set_options:1244 ERROR: Invalid heartbeat mount options