WARNING: kobject bug in br_add_if

Status: fixed on 2018/05/16 09:57
Subsystems: bridge
[Documentation on labels]
Reported-by: syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com
Fix commit: e8238fc2bd7b bridge: check iface upper dev when setting master via ioctl 3e14c6abbfb5 kobject: don't use WARN for registration failures
First crash: 3037d, last: 3000d
▶ ▼ Discussions (13)
Title Replies (including bot) Last reply
[PATCH 4.4 00/92] 4.4.133-stable review 126 (126) 2018/11/01 21:45
[PATCH 3.18 00/45] 3.18.110-stable review 52 (52) 2018/05/24 19:46
[PATCH 4.16 00/55] 4.16.10-stable review 63 (63) 2018/05/19 07:43
[PATCH 4.9 00/33] 4.9.101-stable review 40 (40) 2018/05/18 20:47
[PATCH 4.14 00/45] 4.14.42-stable review 50 (50) 2018/05/18 20:46
[PATCH 4.16 000/113] 4.16.7-stable review 120 (120) 2018/05/01 19:26
[PATCH 4.4 00/44] 4.4.131-stable review 53 (53) 2018/05/01 19:08
[PATCH 4.9 00/61] 4.9.98-stable review 66 (66) 2018/05/01 19:07
[PATCH 4.14 00/91] 4.14.39-stable review 97 (97) 2018/05/01 19:06
[PATCH 3.18 00/25] 3.18.108-stable review 32 (32) 2018/05/01 19:04
[PATCH net] bridge: check iface upper dev when setting master via ioctl 8 (8) 2018/04/30 01:08
WARNING: kobject bug in br_add_if 6 (7) 2018/04/26 11:51
[PATCH] kobject: don't use WARN for registration failures 1 (1) 2018/04/11 15:22

Sample crash report:
RBP: 000000000072bea0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000015
R13: 0000000000000373 R14: 00000000006f8368 R15: 0000000000000006
------------[ cut here ]------------
kobject_add_internal failed for brport (error: -12 parent: team_slave_0)
WARNING: CPU: 0 PID: 12031 at lib/kobject.c:242 kobject_add_internal+0x42c/0xba0 lib/kobject.c:240
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 12031 Comm: syz-executor3 Not tainted 4.17.0-rc2+ #19
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b9/0x294 lib/dump_stack.c:113
 panic+0x22f/0x4de kernel/panic.c:184
 __warn.cold.8+0x163/0x1b3 kernel/panic.c:536
 report_bug+0x252/0x2d0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 do_error_trap+0x1de/0x490 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:992
RIP: 0010:kobject_add_internal+0x42c/0xba0 lib/kobject.c:240
RSP: 0018:ffff8801a86e7580 EFLAGS: 00010286
RAX: 0000000000000048 RBX: ffff8801d9724a78 RCX: ffffc900038c5000
RDX: 0000000000040000 RSI: ffffffff8160f4e1 RDI: ffff8801a86e70e0
RBP: ffff8801a86e7678 R08: ffff88018b5420c0 R09: 0000000000000006
R10: ffff88018b5420c0 R11: 0000000000000000 R12: 00000000fffffff4
R13: ffff8801cdb8c8e8 R14: ffff8801d6c088c0 R15: ffff8801cdb8c8e8
 kobject_add_varg lib/kobject.c:364 [inline]
 kobject_init_and_add+0xed/0x130 lib/kobject.c:435
 br_add_if+0x76a/0x19e0 net/bridge/br_if.c:542
 add_del_if+0x10f/0x140 net/bridge/br_ioctl.c:101
 br_dev_ioctl+0xbf/0xe0 net/bridge/br_ioctl.c:396
 dev_ifsioc+0x43e/0xb90 net/core/dev_ioctl.c:334
 dev_ioctl+0x1b5/0xcc0 net/core/dev_ioctl.c:500
 sock_do_ioctl+0x1d3/0x3e0 net/socket.c:980
 sock_ioctl+0x30d/0x680 net/socket.c:1081
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:500 [inline]
 do_vfs_ioctl+0x1cf/0x16a0 fs/ioctl.c:684
 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:701
 __do_sys_ioctl fs/ioctl.c:708 [inline]
 __se_sys_ioctl fs/ioctl.c:706 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:706
 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x455979
RSP: 002b:00007faca745dc68 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007faca745e6d4 RCX: 0000000000455979
RDX: 0000000020000000 RSI: 00000000000089a2 RDI: 0000000000000014
RBP: 000000000072bea0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000015
R13: 0000000000000373 R14: 00000000006f8368 R15: 0000000000000006
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (41):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/04/27 17:49 upstream 0644f186fc9d 7785e404 .config console log report ci-upstream-kasan-gce-root
2018/04/24 08:10 upstream 6d08b06e67cd e7e85d36 .config console log report ci-upstream-kasan-gce
2018/04/19 09:44 upstream 87ef12027b9b d1b2ef69 .config console log report ci-upstream-kasan-gce
2018/04/19 02:58 upstream 87ef12027b9b 829f0234 .config console log report ci-upstream-kasan-gce-root
2018/04/18 15:53 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 14:19 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce
2018/04/17 04:28 upstream a27fc14219f2 b80fd3b5 .config console log report ci-upstream-kasan-gce
2018/04/15 02:26 upstream 18b7fd1c93e5 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/14 01:43 upstream 1bad9ce155a7 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/13 14:59 upstream 16e205cf42da 0a0c5db6 .config console log report ci-upstream-kasan-gce-root
2018/04/13 14:57 upstream 16e205cf42da 0a0c5db6 .config console log report ci-upstream-kasan-gce
2018/04/13 00:10 upstream c17b0aadb7d8 eb2295de .config console log report ci-upstream-kasan-gce
2018/04/13 00:07 upstream c17b0aadb7d8 eb2295de .config console log report ci-upstream-kasan-gce
2018/04/12 08:25 upstream b284d4d5a678 9cd56d71 .config console log report ci-upstream-kasan-gce
2018/04/12 03:13 upstream b284d4d5a678 9cd56d71 .config console log report ci-upstream-kasan-gce-root
2018/04/12 03:13 upstream b284d4d5a678 9cd56d71 .config console log report ci-upstream-kasan-gce
2018/04/01 11:46 upstream 10b84daddbec 0174c6c8 .config console log report ci-upstream-kasan-gce
2018/04/12 03:15 upstream f2d285669aae 9cd56d71 .config console log report ci-upstream-kasan-gce-386
2018/04/24 22:30 net-next-old 9c20b9372fba 37e76fe2 .config console log report ci-upstream-net-kasan-gce
2018/04/23 15:35 net-next-old a56e6bcd34b5 0d8e591c .config console log report ci-upstream-net-kasan-gce
2018/04/19 12:35 net-next-old 415787d7799f 3642839c .config console log report ci-upstream-net-kasan-gce
2018/04/18 10:38 net-next-old 0565de29cbd6 52643b44 .config console log report ci-upstream-net-kasan-gce
2018/04/13 08:56 net-next-old 5d1365940a68 0a0c5db6 .config console log report ci-upstream-net-kasan-gce
2018/04/12 12:27 net-next-old 17dec0a94915 9cd56d71 .config console log report ci-upstream-net-kasan-gce
2018/04/12 08:38 net-next-old 17dec0a94915 9cd56d71 .config console log report ci-upstream-net-kasan-gce
2018/04/12 08:26 net-next-old 17dec0a94915 9cd56d71 .config console log report ci-upstream-net-kasan-gce
2018/04/03 08:31 net-next-old 159f02977b2f 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/01 05:09 net-next-old 8bde261e5352 0174c6c8 .config console log report ci-upstream-net-kasan-gce
2018/04/01 00:18 net-next-old c0b6edef0bf0 0174c6c8 .config console log report ci-upstream-net-kasan-gce
2018/05/08 11:10 https://github.com/google/kmsan.git master d2d741e5d189 045bbd4a .config console log report ci-upstream-kmsan-gce
2018/05/07 14:54 https://github.com/google/kmsan.git master d2d741e5d189 a211da1a .config console log report ci-upstream-kmsan-gce
2018/05/06 04:06 https://github.com/google/kmsan.git master d2d741e5d189 78b251cb .config console log report ci-upstream-kmsan-gce
2018/05/05 14:33 https://github.com/google/kmsan.git master d2d741e5d189 6a0382b5 .config console log report ci-upstream-kmsan-gce
2018/05/03 09:39 https://github.com/google/kmsan.git master d2d741e5d189 9ce14f4b .config console log report ci-upstream-kmsan-gce
2018/04/30 23:03 https://github.com/google/kmsan.git master d2d741e5d189 d5b114b4 .config console log report ci-upstream-kmsan-gce
2018/04/30 21:22 https://github.com/google/kmsan.git master d2d741e5d189 d5b114b4 .config console log report ci-upstream-kmsan-gce
2018/04/30 11:33 https://github.com/google/kmsan.git master d2d741e5d189 06db3cec .config console log report ci-upstream-kmsan-gce
2018/04/30 02:52 https://github.com/google/kmsan.git master d2d741e5d189 bb79c6ab .config console log report ci-upstream-kmsan-gce
2018/04/28 06:39 https://github.com/google/kmsan.git master d2d741e5d189 d5a5d045 .config console log report ci-upstream-kmsan-gce
2018/04/26 03:30 https://github.com/google/kmsan.git master d2d741e5d189 73417389 .config console log report ci-upstream-kmsan-gce
2018/04/25 23:04 https://github.com/google/kmsan.git master d2d741e5d189 73417389 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.