syzbot


INFO: trying to register non-static key in __io_uring_register

Status: fixed on 2020/05/10 10:42
Subsystems: fs
[Documentation on labels]
Reported-by: syzbot+e6eeca4a035da76b3065@syzkaller.appspotmail.com
Fix commit: f7fe9346869a io_uring: initialize fixed_file_data lock
First crash: 1645d, last: 1643d
Cause bisection: introduced by (bisect log) :
commit 0558955373023b08f638c9ede36741b0e4200f58
Author: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Date: Tue Mar 31 06:05:18 2020 +0000

  io_uring: refactor file register/unregister/update handling

Crash: INFO: trying to register non-static key in __io_uring_register (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH for-next] io_uring: initialize fixed_file_data lock 2 (2) 2020/04/07 15:46
INFO: trying to register non-static key in __io_uring_register 0 (1) 2020/04/07 08:16

Sample crash report:
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 1 PID: 7099 Comm: syz-executor897 Not tainted 5.6.0-next-20200406-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 assign_lock_key kernel/locking/lockdep.c:913 [inline]
 register_lock_class+0x1664/0x1760 kernel/locking/lockdep.c:1225
 __lock_acquire+0x104/0x4e00 kernel/locking/lockdep.c:4223
 lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4923
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0x8c/0xbf kernel/locking/spinlock.c:159
 io_sqe_files_register fs/io_uring.c:6599 [inline]
 __io_uring_register+0x1fe8/0x2f00 fs/io_uring.c:8001
 __do_sys_io_uring_register fs/io_uring.c:8081 [inline]
 __se_sys_io_uring_register fs/io_uring.c:8063 [inline]
 __x64_sys_io_uring_register+0x192/0x560 fs/io_uring.c:8063
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x440289
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffff1bbf558 EFLAGS: 00000246 ORIG_RAX: 00000000000001ab
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440289
RDX: 0000000020000280 RSI: 0000000000000002 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000401b10
R13: 0000000000401ba0 R14: 0000000000000000 R15: 0000000000000000

Crashes (39):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/04/06 20:16 linux-next b2e2a818a017 99a96044 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/04/08 20:12 linux-next 5798bd75ab13 db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/08 17:40 linux-next 5798bd75ab13 db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/08 04:18 linux-next 5798bd75ab13 db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/08 00:35 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/08 00:22 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/08 00:18 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 23:37 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 19:05 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 18:57 linux-next 5fab54423a0a db9bcd4b .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 13:31 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 11:18 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 10:42 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 09:56 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 09:50 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 09:46 linux-next 5fab54423a0a 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 06:46 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 06:27 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 06:19 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 04:25 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 02:29 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 02:07 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 02:07 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 02:03 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 02:03 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 01:59 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 01:58 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 01:56 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 01:42 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 01:38 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 00:01 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/07 00:00 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 23:59 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 23:39 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 19:31 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 19:21 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 19:20 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 19:18 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/06 19:17 linux-next b2e2a818a017 99a96044 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.