possible deadlock in ieee80211_change

Title	Replies (including bot)	Last reply
[syzbot] [wireless?] possible deadlock in ieee80211_change_mac (2)	0 (1)	2024/10/04 22:17
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	possible deadlock in ieee80211_change_mac wireless				1	410d	406d	25/28	fixed on 2023/12/21 01:43
======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc1-syzkaller-00131-gf66ebf37d69c #0 Not tainted
------------------------------------------------------
syz.2.718/8035 is trying to acquire lock:
ffff888055530768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: wiphy_lock include/net/cfg80211.h:6014 [inline]
ffff888055530768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: ieee80211_change_mac+0xcc/0x11e0 net/mac80211/iface.c:309

but task is already holding lock:
ffff88807b14cd40 (team->team_lock_key#8){+.+.}-{3:3}, at: team_del_slave+0x32/0x1d0 drivers/net/team/team_core.c:1990

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (team->team_lock_key#8){+.+.}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
       team_port_change_check+0x51/0x1e0 drivers/net/team/team_core.c:2950
       team_device_event+0x161/0x5b0 drivers/net/team/team_core.c:2976
       notifier_call_chain+0x19f/0x3e0 kernel/notifier.c:93
       call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
       call_netdevice_notifiers net/core/dev.c:2048 [inline]
       dev_close_many+0x33c/0x4c0 net/core/dev.c:1589
       unregister_netdevice_many_notify+0x530/0x1da0 net/core/dev.c:11377
       macvlan_device_event+0x7e0/0x870 drivers/net/macvlan.c:1830
       notifier_call_chain+0x19f/0x3e0 kernel/notifier.c:93
       call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
       call_netdevice_notifiers net/core/dev.c:2048 [inline]
       unregister_netdevice_many_notify+0xedd/0x1da0 net/core/dev.c:11403
       unregister_netdevice_many net/core/dev.c:11465 [inline]
       unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11339
       unregister_netdevice include/linux/netdevice.h:3118 [inline]
       _cfg80211_unregister_wdev+0x162/0x560 net/wireless/core.c:1211
       ieee80211_if_remove+0x25d/0x3a0 net/mac80211/iface.c:2240
       ieee80211_del_iface+0x19/0x30 net/mac80211/cfg.c:202
       rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline]
       cfg80211_remove_virtual_intf+0x23f/0x410 net/wireless/util.c:2875
       genl_family_rcv_msg_doit net/netlink/genetlink.c:1115 [inline]
       genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
       genl_rcv_msg+0xb14/0xec0 net/netlink/genetlink.c:1210
       netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
       genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
       netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
       netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1357
       netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901
       sock_sendmsg_nosec net/socket.c:729 [inline]
       __sock_sendmsg+0x221/0x270 net/socket.c:744
       ____sys_sendmsg+0x52a/0x7e0 net/socket.c:2602
       ___sys_sendmsg net/socket.c:2656 [inline]
       __sys_sendmsg+0x292/0x380 net/socket.c:2685
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&rdev->wiphy.mtx){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
       __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
       wiphy_lock include/net/cfg80211.h:6014 [inline]
       ieee80211_change_mac+0xcc/0x11e0 net/mac80211/iface.c:309
       dev_set_mac_address+0x327/0x510 net/core/dev.c:9099
       bond_set_mac_address+0x28e/0x7f0 drivers/net/bonding/bond_main.c:4880
       dev_set_mac_address+0x327/0x510 net/core/dev.c:9099
       __set_port_dev_addr drivers/net/team/team_core.c:57 [inline]
       team_port_set_orig_dev_addr drivers/net/team/team_core.c:62 [inline]
       team_port_del+0xb08/0xcc0 drivers/net/team/team_core.c:1367
       team_del_slave+0x3d/0x1d0 drivers/net/team/team_core.c:1991
       do_set_master net/core/rtnetlink.c:2687 [inline]
       do_setlink+0xeff/0x41f0 net/core/rtnetlink.c:2907
       rtnl_group_changelink net/core/rtnetlink.c:3447 [inline]
       __rtnl_newlink net/core/rtnetlink.c:3706 [inline]
       rtnl_newlink+0x1119/0x20a0 net/core/rtnetlink.c:3743
       rtnetlink_rcv_msg+0x73f/0xcf0 net/core/rtnetlink.c:6646
       netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
       netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
       netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1357
       netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901
       sock_sendmsg_nosec net/socket.c:729 [inline]
       __sock_sendmsg+0x221/0x270 net/socket.c:744
       ____sys_sendmsg+0x52a/0x7e0 net/socket.c:2602
       ___sys_sendmsg net/socket.c:2656 [inline]
       __sys_sendmsg+0x292/0x380 net/socket.c:2685
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(team->team_lock_key#8);
                               lock(&rdev->wiphy.mtx);
                               lock(team->team_lock_key#8);
  lock(&rdev->wiphy.mtx);

 *** DEADLOCK ***

2 locks held by syz.2.718/8035:
 #0: ffffffff8fcd1748 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:79 [inline]
 #0: ffffffff8fcd1748 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x6e6/0xcf0 net/core/rtnetlink.c:6643
 #1: ffff88807b14cd40 (team->team_lock_key#8){+.+.}-{3:3}, at: team_del_slave+0x32/0x1d0 drivers/net/team/team_core.c:1990

stack backtrace:
CPU: 0 UID: 0 PID: 8035 Comm: syz.2.718 Not tainted 6.12.0-rc1-syzkaller-00131-gf66ebf37d69c #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
 wiphy_lock include/net/cfg80211.h:6014 [inline]
 ieee80211_change_mac+0xcc/0x11e0 net/mac80211/iface.c:309
 dev_set_mac_address+0x327/0x510 net/core/dev.c:9099
 bond_set_mac_address+0x28e/0x7f0 drivers/net/bonding/bond_main.c:4880
 dev_set_mac_address+0x327/0x510 net/core/dev.c:9099
 __set_port_dev_addr drivers/net/team/team_core.c:57 [inline]
 team_port_set_orig_dev_addr drivers/net/team/team_core.c:62 [inline]
 team_port_del+0xb08/0xcc0 drivers/net/team/team_core.c:1367
 team_del_slave+0x3d/0x1d0 drivers/net/team/team_core.c:1991
 do_set_master net/core/rtnetlink.c:2687 [inline]
 do_setlink+0xeff/0x41f0 net/core/rtnetlink.c:2907
 rtnl_group_changelink net/core/rtnetlink.c:3447 [inline]
 __rtnl_newlink net/core/rtnetlink.c:3706 [inline]
 rtnl_newlink+0x1119/0x20a0 net/core/rtnetlink.c:3743
 rtnetlink_rcv_msg+0x73f/0xcf0 net/core/rtnetlink.c:6646
 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
 netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
 netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1357
 netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901
 sock_sendmsg_nosec net/socket.c:729 [inline]
 __sock_sendmsg+0x221/0x270 net/socket.c:744
 ____sys_sendmsg+0x52a/0x7e0 net/socket.c:2602
 ___sys_sendmsg net/socket.c:2656 [inline]
 __sys_sendmsg+0x292/0x380 net/socket.c:2685
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2f9977dff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2f9a4b4038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f2f99936058 RCX: 00007f2f9977dff9
RDX: 0000000000000000 RSI: 0000000020000280 RDI: 0000000000000005
RBP: 00007f2f997f0296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f2f99936058 R15: 00007ffe9593e008
 </TASK>
team0: Port device bond0 removed
bond0: (slave wlan1): Releasing backup interface