KASAN: double-free or invalid-free in relay_open

Status: fixed on 2018/02/12 17:26
Subsystems: trace block
[Documentation on labels]
Reported-by: syzbot+eb8be6216b6b712efe5df541be1ad63a51f70008@syzkaller.appspotmail.com
Fix commit: a1be1f3931bf kernel/relay.c: revert "kernel/relay.c: fix potential memory leak"
First crash: 3224d, last: 3116d
▶ ▼ Similar bugs (1)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
android-49 KASAN: double-free or invalid-free in relay_open 24 syz, C 64 3105d 3157d 2/3 fixed on 2018/02/20 22:33

Sample crash report:
audit: type=1400 audit(1514426602.652:7): avc:  denied  { map } for  pid=3146 comm="syzkaller047195" path="/root/syzkaller047195405" dev="sda1" ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
==================================================================
BUG: KASAN: double-free or invalid-free in relay_open+0x6a1/0xa40 kernel/relay.c:614

CPU: 1 PID: 3146 Comm: syzkaller047195 Not tainted 4.15.0-rc5+ #239
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x194/0x257 lib/dump_stack.c:53
 print_address_description+0x73/0x250 mm/kasan/report.c:252
 kasan_report_double_free+0x55/0x80 mm/kasan/report.c:333
 kasan_slab_free+0xa3/0xc0 mm/kasan/kasan.c:514
 __cache_free mm/slab.c:3488 [inline]
 kfree+0xd6/0x260 mm/slab.c:3803
 relay_open+0x6a1/0xa40 kernel/relay.c:614
 do_blk_trace_setup+0x4a4/0xcd0 kernel/trace/blktrace.c:544
 __blk_trace_setup+0xbe/0x150 kernel/trace/blktrace.c:589
 blk_trace_setup+0x4d/0x70 kernel/trace/blktrace.c:607
 sg_ioctl+0xc71/0x2d90 drivers/scsi/sg.c:1089
 vfs_ioctl fs/ioctl.c:46 [inline]
 do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686
 SYSC_ioctl fs/ioctl.c:701 [inline]
 SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
 entry_SYSCALL_64_fastpath+0x1f/0x96
RIP: 0033:0x443de9
RSP: 002b:00007ffcff34a028 EFLAGS: 00000202 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00000000004002e0 RCX: 0000000000443de9
RDX: 0000000020001f8a RSI: 00000000c0481273 RDI: 0000000000000003
RBP: 00000000006ce018 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000401ad0
R13: 0000000000401b60 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 3146:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:551
 kmem_cache_alloc_trace+0x136/0x750 mm/slab.c:3610
 kmalloc include/linux/slab.h:499 [inline]
 kzalloc include/linux/slab.h:688 [inline]
 relay_open+0xf2/0xa40 kernel/relay.c:576
 do_blk_trace_setup+0x4a4/0xcd0 kernel/trace/blktrace.c:544
 __blk_trace_setup+0xbe/0x150 kernel/trace/blktrace.c:589
 blk_trace_setup+0x4d/0x70 kernel/trace/blktrace.c:607
 sg_ioctl+0xc71/0x2d90 drivers/scsi/sg.c:1089
 vfs_ioctl fs/ioctl.c:46 [inline]
 do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686
 SYSC_ioctl fs/ioctl.c:701 [inline]
 SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
 entry_SYSCALL_64_fastpath+0x1f/0x96

Freed by task 3146:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_slab_free+0x71/0xc0 mm/kasan/kasan.c:524
 __cache_free mm/slab.c:3488 [inline]
 kfree+0xd6/0x260 mm/slab.c:3803
 relay_destroy_channel kernel/relay.c:199 [inline]
 kref_put include/linux/kref.h:70 [inline]
 relay_open+0x84a/0xa40 kernel/relay.c:612
 do_blk_trace_setup+0x4a4/0xcd0 kernel/trace/blktrace.c:544
 __blk_trace_setup+0xbe/0x150 kernel/trace/blktrace.c:589
 blk_trace_setup+0x4d/0x70 kernel/trace/blktrace.c:607
 sg_ioctl+0xc71/0x2d90 drivers/scsi/sg.c:1089
 vfs_ioctl fs/ioctl.c:46 [inline]
 do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686
 SYSC_ioctl fs/ioctl.c:701 [inline]
 SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
 entry_SYSCALL_64_fastpath+0x1f/0x96

The buggy address belongs to the object at ffff8801ce8b7340
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 0 bytes inside of
 512-byte region [ffff8801ce8b7340, ffff8801ce8b7540)
The buggy address belongs to the page:
page:00000000a9b1225b count:1 mapcount:0 mapping:000000009c14237f index:0xffff8801ce8b75c0
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801ce8b70c0 ffff8801ce8b75c0 0000000100000004
raw: ffffea00073a3060 ffffea00073319a0 ffff8801db000940 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8801ce8b7200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8801ce8b7280: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff8801ce8b7300: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
                                           ^
 ffff8801ce8b7380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8801ce8b7400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (106):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2017/12/28 02:05 upstream 5f520fc31876 7d240098 .config console log report syz C ci-upstream-kasan-gce
2017/12/28 10:04 linux-next 0e08c463db38 7d240098 .config console log report syz C ci-upstream-next-kasan-gce
2017/12/28 00:45 mmots 37759fa6d0fa 7d240098 .config console log report syz C ci-upstream-mmots-kasan-gce
2017/12/11 21:10 mmots 82bcf1def3b5 da131727 .config console log report syz C ci-upstream-mmots-kasan-gce
2017/12/09 09:47 linux-next ad4dac17f9d5 5ad0ce95 .config console log report syz C ci-upstream-next-kasan-gce
2017/11/08 08:21 linux-next 5a3517e009e9 e0a2b195 .config console log report syz C ci-upstream-next-kasan-gce
2017/10/29 06:11 linux-next 36ef71cae353 e511d9f8 .config console log report syz C ci-upstream-next-kasan-gce
2017/10/28 19:01 linux-next 36ef71cae353 e511d9f8 .config console log report syz C ci-upstream-next-kasan-gce
2017/10/24 10:44 linux-next 36ef71cae353 e511d9f8 .config console log report syz C ci-upstream-next-kasan-gce
2018/02/06 14:01 upstream e237f98a9c13 645ce5da .config console log report ci-upstream-kasan-gce
2018/02/06 14:01 upstream e237f98a9c13 645ce5da .config console log report ci-upstream-kasan-gce
2018/02/04 12:13 upstream 617aebe6a97e a1bc9d40 .config console log report ci-upstream-kasan-gce
2018/02/04 11:52 upstream 617aebe6a97e a1bc9d40 .config console log report ci-upstream-kasan-gce
2018/02/04 11:44 upstream 617aebe6a97e a1bc9d40 .config console log report ci-upstream-kasan-gce
2018/02/04 11:44 upstream 617aebe6a97e a1bc9d40 .config console log report ci-upstream-kasan-gce
2018/02/02 17:37 upstream 4bf772b14675 632a8c2c .config console log report ci-upstream-kasan-gce
2018/02/02 16:12 upstream 4bf772b14675 826b35d6 .config console log report ci-upstream-kasan-gce
2018/02/02 04:49 upstream 4bf772b14675 826b35d6 .config console log report ci-upstream-kasan-gce
2018/02/01 16:27 upstream 255442c93843 67bd3383 .config console log report ci-upstream-kasan-gce
2018/02/01 16:27 upstream 255442c93843 67bd3383 .config console log report ci-upstream-kasan-gce
2018/02/01 16:23 upstream 255442c93843 67bd3383 .config console log report ci-upstream-kasan-gce
2018/02/01 16:20 upstream 255442c93843 67bd3383 .config console log report ci-upstream-kasan-gce
2018/01/30 15:30 upstream 6304672b7f0a a899be78 .config console log report ci-upstream-kasan-gce
2018/01/30 05:59 upstream 6304672b7f0a 08d47756 .config console log report ci-upstream-kasan-gce
2018/01/29 23:26 upstream d8a5b80568a9 08d47756 .config console log report ci-upstream-kasan-gce
2018/01/29 16:28 upstream d8a5b80568a9 08d47756 .config console log report ci-upstream-kasan-gce
2018/01/29 04:56 upstream 24b1cccf9229 08d47756 .config console log report ci-upstream-kasan-gce
2018/01/28 08:37 upstream c4e0ca7fa241 08d47756 .config console log report ci-upstream-kasan-gce
2018/01/27 14:45 upstream c4e0ca7fa241 1d18b112 .config console log report ci-upstream-kasan-gce
2018/01/27 01:38 upstream c4e0ca7fa241 1d18b112 .config console log report ci-upstream-kasan-gce
2018/01/26 00:47 upstream 6e20630e3004 1d18b112 .config console log report ci-upstream-kasan-gce
2018/01/25 08:59 upstream 5b7d27967dab 6b2a715e .config console log report ci-upstream-kasan-gce
2018/01/25 05:50 upstream 5132ede0fe80 866f1102 .config console log report ci-upstream-kasan-gce
2018/01/23 12:29 upstream 1995266727fa a5b7566c .config console log report ci-upstream-kasan-gce
2018/01/20 06:49 upstream ec835f8104a2 fbbdcd92 .config console log report ci-upstream-kasan-gce
2018/01/20 02:55 upstream ec835f8104a2 fbbdcd92 .config console log report ci-upstream-kasan-gce
2018/01/19 15:40 upstream dda3e15231b3 161c1d64 .config console log report ci-upstream-kasan-gce
2018/01/19 05:01 upstream dda3e15231b3 161c1d64 .config console log report ci-upstream-kasan-gce
2018/01/18 08:46 upstream 1d966eb4d632 56cc113a .config console log report ci-upstream-kasan-gce
2018/01/17 20:20 upstream 8cbab92dff77 b8970f31 .config console log report ci-upstream-kasan-gce
2018/01/17 19:05 upstream 8cbab92dff77 d7bc5820 .config console log report ci-upstream-kasan-gce
2018/01/16 20:05 upstream a8750ddca918 a46e5318 .config console log report ci-upstream-kasan-gce
2018/01/16 08:53 upstream a8750ddca918 4198e588 .config console log report ci-upstream-kasan-gce
2018/01/15 21:02 upstream a8750ddca918 e17f4a5d .config console log report ci-upstream-kasan-gce
2018/01/15 18:17 upstream a8750ddca918 66d492a6 .config console log report ci-upstream-kasan-gce
2018/01/12 17:36 upstream 1545dec46db3 9dc808a6 .config console log report ci-upstream-kasan-gce
2018/01/11 19:32 upstream 5f615b97cdea 9dc808a6 .config console log report ci-upstream-kasan-gce
2018/01/09 23:15 upstream d476c5334f1d 1f60c828 .config console log report ci-upstream-kasan-gce
2018/01/07 17:17 upstream 3219e264b984 19c05fff .config console log report ci-upstream-kasan-gce
* Struck through repros no longer work on HEAD.