syzbot


KMSAN: uninit-value in dvb_usb_adapter_dvb_init

Status: fixed on 2020/02/18 14:31
Subsystems: media
[Documentation on labels]
Reported-by: syzbot+ec869945d3dde5f33b43@syzkaller.appspotmail.com
Fix commit: 26cff637121d media: vp7045: do not read uninitialized values if usb transfer fails
First crash: 1577d, last: 1577d
Discussions (6)
Title Replies (including bot) Last reply
[PATCH 5.5 00/23] 5.5.2-stable review 31 (31) 2020/02/08 16:13
[PATCH 5.4 00/90] 5.4.18-stable review 107 (107) 2020/02/05 21:21
[PATCH 4.19 00/70] 4.19.102-stable review 77 (77) 2020/02/05 14:42
[PATCH 0/5] Fix various syzbot errors 10 (10) 2019/11/12 09:53
[PATCH 1/3] media: digitv: don't continue if remote control state can't be read 3 (3) 2019/11/10 10:34
KMSAN: uninit-value in dvb_usb_adapter_dvb_init 0 (1) 2019/11/08 13:24
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KMSAN: uninit-value in dvb_usb_adapter_dvb_init (2) usb media C 34 979d 1195d 20/26 fixed on 2022/03/16 16:02

Sample crash report:
vp7045: USB control message 'out' went wrong.
vp7045: USB control message 'out' went wrong.
vp7045: USB control message 'out' went wrong.
vp7045: USB control message 'out' went wrong.
=====================================================
BUG: KMSAN: uninit-value in mac_address_string+0xcd5/0x1000 lib/vsprintf.c:604
CPU: 0 PID: 13542 Comm: kworker/0:7 Not tainted 5.4.0-rc5+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x128/0x220 mm/kmsan/kmsan_report.c:108
 __msan_warning+0x73/0xe0 mm/kmsan/kmsan_instr.c:245
 mac_address_string+0xcd5/0x1000 lib/vsprintf.c:604
 pointer+0x56d/0x1d10 lib/vsprintf.c:2148
 vsnprintf+0x1c0c/0x3210 lib/vsprintf.c:2514
 vscnprintf+0xc2/0x180 lib/vsprintf.c:2613
 vprintk_store+0xef/0x11e0 kernel/printk/printk.c:1922
 vprintk_emit+0x2c6/0x860 kernel/printk/printk.c:1984
 vprintk_default+0x90/0xa0 kernel/printk/printk.c:2029
 vprintk_func+0x635/0x810 kernel/printk/printk_safe.c:386
 printk+0x180/0x1c3 kernel/printk/printk.c:2062
 dvb_usb_adapter_dvb_init+0x90e/0x13f0 drivers/media/usb/dvb-usb/dvb-usb-dvb.c:166
 dvb_usb_adapter_init drivers/media/usb/dvb-usb/dvb-usb-init.c:83 [inline]
 dvb_usb_init drivers/media/usb/dvb-usb/dvb-usb-init.c:173 [inline]
 dvb_usb_device_init+0x22fe/0x2e10 drivers/media/usb/dvb-usb/dvb-usb-init.c:287
 vp7045_usb_probe+0x73/0x80 drivers/media/usb/dvb-usb/vp7045.c:164
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Uninit was stored to memory at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:151 [inline]
 kmsan_internal_chain_origin+0xbd/0x180 mm/kmsan/kmsan.c:319
 __msan_chain_origin+0x6b/0xd0 mm/kmsan/kmsan_instr.c:179
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:123 [inline]
 vp7045_read_mac_addr+0x62e/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132
 dvb_usb_adapter_dvb_init+0x890/0x13f0 drivers/media/usb/dvb-usb/dvb-usb-dvb.c:165
 dvb_usb_adapter_init drivers/media/usb/dvb-usb/dvb-usb-init.c:83 [inline]
 dvb_usb_init drivers/media/usb/dvb-usb/dvb-usb-init.c:173 [inline]
 dvb_usb_device_init+0x22fe/0x2e10 drivers/media/usb/dvb-usb/dvb-usb-init.c:287
 vp7045_usb_probe+0x73/0x80 drivers/media/usb/dvb-usb/vp7045.c:164
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Local variable description: ----br.i@vp7045_read_mac_addr
Variable was created at:
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132
=====================================================

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/11/01 01:54 https://github.com/google/kmsan.git master 6f88939b3fa3 a41ca8fa .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.