syzbot


general protection fault in j1939_netdev_start

Status: fixed on 2020/09/16 22:51
Subsystems: can
[Documentation on labels]
Reported-by: syzbot+f03d384f3455d28833eb@syzkaller.appspotmail.com
Fix commit: af804b782635 can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated
First crash: 1718d, last: 1566d
Cause bisection: introduced by (bisect log) :
commit 8330f73fe9742f201f467639f8356cf58756fb9f
Author: Jiri Pirko <jiri@mellanox.com>
Date: Wed Sep 4 07:40:47 2019 +0000

  rocker: add missing init_net check in FIB notifier

Crash: general protection fault in batadv_iv_ogm_queue_add (log)
Repro: C syz .config
  
Discussions (7)
Title Replies (including bot) Last reply
[PATCH 5.8 000/148] 5.8.4-rc1 review 152 (152) 2020/08/24 16:54
[PATCH 5.4 000/107] 5.4.61-rc1 review 108 (108) 2020/08/24 08:31
[PATCH 5.7 000/124] 5.7.18-rc1 review 125 (125) 2020/08/24 08:30
[PATCH 4/6] can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated 1 (1) 2020/08/14 11:04
[PATCH v1 0/5] j1939 fixes 6 (6) 2020/08/07 10:52
[PATCH v1] can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated 1 (1) 2020/03/13 15:28
general protection fault in j1939_netdev_start 0 (2) 2020/03/11 20:17
Fix bisection attempts (4)
Created Duration User Patch Repo Result
2020/07/26 07:09 20m bisect fix upstream OK (0) job log log
2020/06/04 21:16 20m bisect fix upstream OK (0) job log log
2020/05/02 11:25 19m bisect fix upstream OK (0) job log log
2020/04/02 10:01 19m bisect fix upstream OK (0) job log log

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000c05: 0000 [#1] PREEMPT SMP KASAN
KASAN: probably user-memory-access in range [0x0000000000006028-0x000000000000602f]
CPU: 1 PID: 10663 Comm: syz-executor410 Not tainted 5.6.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:j1939_priv_set net/can/j1939/main.c:145 [inline]
RIP: 0010:j1939_netdev_start+0x361/0x650 net/can/j1939/main.c:280
Code: 03 80 3c 02 00 0f 85 bc 02 00 00 4c 8b ab 90 05 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d bd 28 60 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 89 02 00 00 4d 89 a5 28 60 00 00 48 c7 c7 e0 8d
RSP: 0018:ffffc90002337d00 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff88809c9e4000 RCX: ffffffff87162b84
RDX: 0000000000000c05 RSI: ffffffff87163b3c RDI: 0000000000006028
RBP: ffffc90002337d40 R08: ffff88808ec00280 R09: fffff52000466f8e
R10: fffff52000466f8d R11: 0000000000000003 R12: ffff8880a34c8000
R13: 0000000000000000 R14: ffff8880a34c9050 R15: ffff88809c9e4558
FS:  00007f8cb2aea700(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f8cb2ae9e78 CR3: 0000000091462000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 j1939_sk_bind+0x68d/0x980 net/can/j1939/socket.c:469
 __sys_bind+0x239/0x290 net/socket.c:1662
 __do_sys_bind net/socket.c:1673 [inline]
 __se_sys_bind net/socket.c:1671 [inline]
 __x64_sys_bind+0x73/0xb0 net/socket.c:1671
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x446d39
Code: e8 8c e7 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 07 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f8cb2ae9d98 EFLAGS: 00000246 ORIG_RAX: 0000000000000031
RAX: ffffffffffffffda RBX: 00000000006dbc78 RCX: 0000000000446d39
RDX: 0000000000000018 RSI: 0000000020000040 RDI: 0000000000000003
RBP: 00000000006dbc70 R08: 00007f8cb2aea700 R09: 0000000000000000
R10: 00007f8cb2aea700 R11: 0000000000000246 R12: 00000000006dbc7c
R13: 000000006f340000 R14: 0000000000000000 R15: 068500100000003c
Modules linked in:
---[ end trace 00b4ec7244aa50f2 ]---
RIP: 0010:j1939_priv_set net/can/j1939/main.c:145 [inline]
RIP: 0010:j1939_netdev_start+0x361/0x650 net/can/j1939/main.c:280
Code: 03 80 3c 02 00 0f 85 bc 02 00 00 4c 8b ab 90 05 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d bd 28 60 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 89 02 00 00 4d 89 a5 28 60 00 00 48 c7 c7 e0 8d
RSP: 0018:ffffc90002337d00 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff88809c9e4000 RCX: ffffffff87162b84
RDX: 0000000000000c05 RSI: ffffffff87163b3c RDI: 0000000000006028
RBP: ffffc90002337d40 R08: ffff88808ec00280 R09: fffff52000466f8e
R10: fffff52000466f8d R11: 0000000000000003 R12: ffff8880a34c8000
R13: 0000000000000000 R14: ffff8880a34c9050 R15: ffff88809c9e4558
FS:  00007f8cb2aea700(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f8cb2ae9e78 CR3: 0000000091462000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/03/03 02:24 upstream 63623fd44972 c88c7b75 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/02/28 06:52 upstream f8788d86ab28 59b57593 .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/02/28 02:31 upstream f8788d86ab28 59b57593 .config console log report syz C ci-upstream-kasan-gce
2020/02/25 13:19 net-old 6132c1d9033d 59b57593 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/02/25 14:19 net-next-old c3e042f54107 59b57593 .config console log report syz C ci-upstream-net-kasan-gce
2020/02/25 12:08 linux-next bdc5461b23ca 59b57593 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/05/05 21:16 net-next-old 354d86141796 4b76dd25 .config console log report ci-upstream-net-kasan-gce
2020/02/25 10:57 linux-next bdc5461b23ca 59b57593 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.