WARNING in loop_add

Status: fixed on 2022/03/08 16:11
Reported-by: syzbot+f41893bb8c45cd18cf08@syzkaller.appspotmail.com
Fix commit: 278167fd2f8f block: add __must_check for *add_disk*() callers
First crash: 2541d, last: 1727d
Cause bisection: introduced by (bisect log) :
commit e41d58185f1444368873d4d7422f7664a68be61d
Author: Dmitry Vyukov <dvyukov@google.com>
Date: Wed Jul 12 21:34:35 2017 +0000

  fault-inject: support systematic fault injection

Crash: general protection fault in sysfs_do_create_link_sd (log)
Repro: C syz .config
  
Fix bisection: failed (error log, bisect log)
  
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH] block: switch to pr_warn() in __device_add_disk() 3 (3) 2020/10/11 15:32
WARNING in loop_add 0 (1) 2019/08/23 02:28
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 WARNING in loop_add -1 syz, C error 94 1262d 2547d 0/1 upstream: reported C repro on 2019/08/16 07:43
linux-5.15 WARNING in loop_add origin:lts-only -1 syz, C done 5 60d 1161d 0/3 upstream: reported C repro on 2023/06/02 07:04
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2020/10/11 08:48 17m rkovhaev@gmail.com patch upstream OK

Sample crash report:
RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f476fdaf689
RDX: 0000000000000000 RSI: 0000000000004c80 RDI: 0000000000000003
RBP: 00007ffccbcaaec0 R08: 0000000000000002 R09: 00007f476f003038
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
kobject_add_internal failed for integrity (error: -12 parent: loop0)
------------[ cut here ]------------
WARNING: CPU: 1 PID: 6541 at block/genhd.c:538 device_add_disk+0x60b/0xfc0 block/genhd.c:538
Modules linked in:
CPU: 1 PID: 6541 Comm: syz-executor483 Not tainted 5.15.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:device_add_disk+0x60b/0xfc0 block/genhd.c:538
Code: 8e ec 07 00 00 8b 5d 00 bf 03 01 00 00 89 de e8 db 20 ad fd 81 fb 03 01 00 00 0f 85 69 fd ff ff e9 22 fd ff ff e8 85 19 ad fd <0f> 0b 41 bc 01 00 00 00 e9 6a fd ff ff e8 73 19 ad fd 0f 0b 41 bc
RSP: 0018:ffffc900012efdb8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000007 RCX: 0000000000000000
RDX: ffff888011f8b900 RSI: ffffffff83c9d39b RDI: 0000000000000003
RBP: ffff888025cbb000 R08: 0000000000000000 R09: ffff8880b9d32a0b
R10: ffffffff83c9d109 R11: 0000000000000000 R12: 00000000fffffff4
R13: ffff88801cc950c8 R14: ffff888025cbb008 R15: ffff888017585280
FS:  0000555555f61300(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000010 CR3: 0000000012791000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 add_disk include/linux/genhd.h:222 [inline]
 loop_add+0x753/0x960 drivers/block/loop.c:2397
 loop_control_ioctl+0x130/0x4a0 drivers/block/loop.c:2512
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:874 [inline]
 __se_sys_ioctl fs/ioctl.c:860 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:860
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f476fdaf689
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffccbcaaeb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f476fdaf689
RDX: 0000000000000000 RSI: 0000000000004c80 RDI: 0000000000000003
RBP: 00007ffccbcaaec0 R08: 0000000000000002 R09: 00007f476f003038
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Crashes (64):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/10/30 11:23 upstream f25a5481af12 098b5d53 .config console log report syz C ci-upstream-kasan-gce WARNING in loop_add
2021/06/21 04:38 upstream cba5e97280f5 aba2b2fb .config console log report syz C ci-upstream-kasan-gce-selinux-root WARNING in loop_add
2021/05/19 03:54 upstream 8ac91e6c6033 a343ba6b .config console log report syz C ci-upstream-kasan-gce-smack-root WARNING in loop_add
2021/05/18 14:21 upstream 8ac91e6c6033 a343ba6b .config console log report syz C ci-upstream-kasan-gce-root WARNING in loop_add
2021/01/18 18:40 upstream 19c329f68089 63631df1 .config console log report syz C ci-upstream-kasan-gce-386 WARNING in loop_add
2021/06/11 17:13 linux-next a1f92694393a 1ba81399 .config console log report syz C ci-upstream-linux-next-kasan-gce-root WARNING in loop_add
2021/01/08 12:56 upstream f5e6c330254a c104d4a3 .config console log report syz C ci-upstream-kasan-gce
2019/08/22 02:02 upstream bb7ba8069de9 984250d5 .config console log report syz C ci-upstream-kasan-gce
2021/10/15 01:16 upstream 26d657410983 7aa5fe41 .config console log report info ci-upstream-kasan-gce-root WARNING in loop_add
2021/07/04 10:28 upstream 3dbdb38e2869 55aa55c2 .config console log report info ci-upstream-kasan-gce-root WARNING in loop_add
2021/11/13 14:08 upstream 66f4beaa6c1d 83f5c9b5 .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/11/08 07:08 upstream bf152b0b41dc 4c1be0be .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/10/24 15:46 upstream 9c0c4d24ac00 282f03fb .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/10/11 06:10 upstream efb52a7d9511 838e7e2c .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/29 22:37 upstream a4e6f95a891a e08fe937 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/26 05:03 upstream 85736168463d 8cac236e .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/24 03:44 upstream bf152b0b41dc 8cac236e .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/09/23 18:15 upstream 58e2cf5d7946 8cac236e .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/16 23:21 upstream ff1ffd71d5f0 7612dc77 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/09 13:22 upstream bf152b0b41dc e2776ee4 .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/09/03 07:54 upstream 46f4945e2b39 f62a5829 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/09/02 06:57 upstream 46f4945e2b39 7eb7e152 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/08/21 14:30 upstream fa54d366a6e4 b599f2fc .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/08/14 07:14 upstream bf152b0b41dc 2489ab88 .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/08/07 21:08 upstream c9194f32bfd9 6972b106 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/08/01 15:21 upstream f3438b4c4e69 6c236867 .config console log report info ci-qemu2-arm64 WARNING in loop_add
2021/07/27 13:54 upstream ff1176468d36 fd511809 .config console log report info ci-qemu2-arm64 WARNING in loop_add
2021/07/25 19:09 upstream d8079fac1681 4d1b57d4 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/07/20 09:49 upstream 2734d6c1b1a0 bc48c9ab .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/06/20 11:04 upstream bf152b0b41dc aba2b2fb .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/06/01 14:28 upstream bf152b0b41dc 032639db .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/05/26 04:30 upstream ad9f25d33860 93d3a9f6 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/05/16 15:38 upstream bf152b0b41dc f54a5c09 .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/05/05 03:11 upstream d72cd4ad4174 06c27ff5 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/04/30 17:41 upstream d72cd4ad4174 77e2b668 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/04/18 23:16 upstream bf152b0b41dc 7e2b734b .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/04/18 01:23 upstream bf152b0b41dc 7e2b734b .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/04/17 03:58 upstream 2f7b98d1e55c 7e2b734b .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/04/13 17:14 upstream 89698becf06d bfeda1b1 .config console log report info ci-qemu2-arm64 WARNING in loop_add
2021/04/11 07:56 upstream 95c7b0755187 bfeda1b1 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/04/07 07:26 upstream bf152b0b41dc 6a81331a .config console log report info ci-qemu2-arm32 WARNING in loop_add
2021/04/05 09:46 upstream e49d033bddf5 6a81331a .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/03/27 12:16 upstream 0f4498cef9f5 a8529b82 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/03/26 21:30 upstream db24726bfefa a8529b82 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/03/14 15:12 upstream 88fe49249c99 4a003785 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/03/04 10:57 upstream f69d02e37a85 d7e4e604 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/03/01 06:54 upstream cd278456d4ca 4c37c133 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/02/20 20:09 upstream f40ddce88593 053a2b26 .config console log report info ci-qemu2-arm64-mte WARNING in loop_add
2021/08/19 05:21 linux-next f26c3abc432a a2fe1cb5 .config console log report info ci-upstream-linux-next-kasan-gce-root WARNING in loop_add
2021/01/05 06:03 upstream 36bbbd0e234d 2a28ff1f .config console log report info ci-upstream-kasan-gce
2020/10/10 15:49 upstream 6f2f486d57c4 93817d89 .config console log report info ci-upstream-kasan-gce
2020/08/25 19:33 upstream 6a9dc5fd6170 344da168 .config console log report ci-upstream-kasan-gce-selinux-root
2020/08/20 16:00 upstream 7eac66d0456f ed282a3a .config console log report ci-upstream-kasan-gce
2020/07/26 23:40 upstream 04300d66f0a0 51265195 .config console log report ci-upstream-kasan-gce-root
2020/07/26 07:23 upstream 23ee3e4e5bd2 1f7cc1ca .config console log report ci-upstream-kasan-gce
2020/06/17 16:04 upstream 7ae77150d94d b9f3810b .config console log report ci-upstream-kasan-gce-smack-root
2020/06/11 04:26 upstream 7ae77150d94d a6f7998d .config console log report ci-upstream-kasan-gce
2020/05/21 09:19 upstream b85051e755b0 c61086ab .config console log report ci-upstream-kasan-gce
2020/04/16 18:17 upstream 00086336a8d9 c743fcb3 .config console log report ci-upstream-kasan-gce
2020/04/14 01:29 upstream 8f3d9f354286 7c54686a .config console log report ci-upstream-kasan-gce
2019/11/26 15:25 upstream 0be0ee71816b f746151a .config console log report ci-upstream-kasan-gce-smack-root
2019/08/24 12:40 upstream 9140d8bdd4c5 78ded196 .config console log report ci-upstream-kasan-gce-root
2019/08/22 00:42 upstream bb7ba8069de9 984250d5 .config console log report ci-upstream-kasan-gce
2020/07/04 19:14 linux-next 9e50b94b3eb0 51095195 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.