syzbot


KASAN: use-after-free Read in atusb_disconnect

Status: fixed on 2019/10/15 23:40
Subsystems: usb wpan
[Documentation on labels]
Reported-by: syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com
Fix commit: 7fd25e6fc035 ieee802154: atusb: fix use-after-free at disconnect
First crash: 1738d, last: 1686d
Discussions (7)
Title Replies (including bot) Last reply
[PATCH 5.3 000/148] 5.3.6-stable review 163 (163) 2019/11/14 15:05
[PATCH 4.9 00/92] 4.9.197-stable review 98 (98) 2019/10/18 07:56
[PATCH 4.4 00/79] 4.4.197-stable review 86 (86) 2019/10/18 07:55
[PATCH 4.19 000/114] 4.19.79-stable review 124 (124) 2019/10/13 15:47
[PATCH 4.14 00/61] 4.14.149-stable review 72 (72) 2019/10/11 14:01
[PATCH] ieee802154: atusb: fix use-after-free at disconnect 2 (3) 2019/09/19 14:56
KASAN: use-after-free Read in atusb_disconnect 0 (1) 2019/09/03 12:08
Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/09/19 12:12 19m johan@kernel.org patch https://github.com/google/kasan.git f0df5c1b OK

Sample crash report:
usb 1-1: USB disconnect, device number 2
==================================================================
BUG: KASAN: use-after-free in atusb_disconnect+0x17f/0x1c0 drivers/net/ieee802154/atusb.c:1143
Read of size 8 at addr ffff8881d53eee28 by task kworker/1:2/83

CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.3.0-rc5+ #28
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 print_address_description+0x6a/0x32c mm/kasan/report.c:351
 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482
 kasan_report+0xe/0x12 mm/kasan/common.c:612
 atusb_disconnect+0x17f/0x1c0 drivers/net/ieee802154/atusb.c:1143
 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
 __device_release_driver drivers/base/dd.c:1134 [inline]
 device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165
 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556
 device_del+0x420/0xb10 drivers/base/core.c:2339
 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:4949 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Allocated by task 12:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:487 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460
 kmalloc include/linux/slab.h:557 [inline]
 kzalloc include/linux/slab.h:748 [inline]
 wpan_phy_new+0x22/0x290 net/ieee802154/core.c:109
 ieee802154_alloc_hw+0x11d/0x750 net/mac802154/main.c:77
 atusb_probe+0x9b/0xfa2 drivers/net/ieee802154/atusb.c:1023
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 83:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:449
 slab_free_hook mm/slub.c:1423 [inline]
 slab_free_freelist_hook mm/slub.c:1474 [inline]
 slab_free mm/slub.c:3016 [inline]
 kfree+0xe4/0x2f0 mm/slub.c:3957
 device_release+0x71/0x200 drivers/base/core.c:1064
 kobject_cleanup lib/kobject.c:693 [inline]
 kobject_release lib/kobject.c:722 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x171/0x280 lib/kobject.c:739
 put_device+0x1b/0x30 drivers/base/core.c:2264
 atusb_disconnect+0x117/0x1c0 drivers/net/ieee802154/atusb.c:1140
 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
 __device_release_driver drivers/base/dd.c:1134 [inline]
 device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165
 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:556
 device_del+0x420/0xb10 drivers/base/core.c:2339
 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:4949 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff8881d53ee600
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 2088 bytes inside of
 4096-byte region [ffff8881d53ee600, ffff8881d53ef600)
The buggy address belongs to the page:
page:ffffea000754fa00 refcount:1 mapcount:0 mapping:ffff8881da00c280 index:0x0 compound_mapcount: 0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 0000000000000000 0000000600000001 ffff8881da00c280
raw: 0000000000000000 0000000000070007 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881d53eed00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881d53eed80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8881d53eee00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                  ^
 ffff8881d53eee80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881d53eef00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (112):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/23 19:07 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report syz C ci2-upstream-usb
2019/10/06 01:32 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 f3f7d9c8 .config console log report syz ci2-upstream-usb
2019/09/21 09:57 https://github.com/google/kasan.git usb-fuzzer e0bd8d794fc9 d96e88f3 .config console log report syz ci2-upstream-usb
2019/10/14 12:33 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 a6aef847 .config console log report ci2-upstream-usb
2019/10/14 11:13 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 a6aef847 .config console log report ci2-upstream-usb
2019/10/14 06:24 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/14 02:10 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/14 01:03 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/13 16:49 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 2f661ec4 .config console log report ci2-upstream-usb
2019/10/12 23:11 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 21:53 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 18:00 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 13:37 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 09:59 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 08:24 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/12 04:36 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 23:42 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 21:16 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 19:19 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 426631dd .config console log report ci2-upstream-usb
2019/10/11 09:28 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/11 07:14 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 1a3bad90 .config console log report ci2-upstream-usb
2019/10/10 18:44 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 d52eff28 .config console log report ci2-upstream-usb
2019/10/10 16:51 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 d52eff28 .config console log report ci2-upstream-usb
2019/10/10 07:19 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/10 03:51 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 21:29 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 20:40 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 c4b9981b .config console log report ci2-upstream-usb
2019/10/09 18:13 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 16:17 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 14:30 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 13:20 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 11:54 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 10:03 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 312c6a5a .config console log report ci2-upstream-usb
2019/10/09 02:00 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 b1ebbfef .config console log report ci2-upstream-usb
2019/10/09 00:59 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 b1ebbfef .config console log report ci2-upstream-usb
2019/10/08 20:28 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 b1ebbfef .config console log report ci2-upstream-usb
2019/10/08 17:32 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 137e37ca .config console log report ci2-upstream-usb
2019/10/08 14:54 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 137e37ca .config console log report ci2-upstream-usb
2019/10/08 10:30 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/08 09:24 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/08 06:20 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/08 04:28 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/08 03:24 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/08 01:34 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 22:49 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 18:32 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 16:25 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 14:25 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 12:47 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 11:07 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 09:52 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 28ac6e64 .config console log report ci2-upstream-usb
2019/10/07 05:22 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 f3f7d9c8 .config console log report ci2-upstream-usb
2019/10/07 05:02 https://github.com/google/kasan.git usb-fuzzer 58d5f26a5584 f3f7d9c8 .config console log report ci2-upstream-usb
2019/08/23 17:56 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 78ded196 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.