syzbot


inconsistent lock state in padata_do_parallel

Status: fixed on 2020/10/10 01:52
Subsystems: crypto
[Documentation on labels]
Reported-by: syzbot+f4b9f49e38e25eb4ef52@syzkaller.appspotmail.com
Fix commit: 1b0df11fde0f padata: fix possible padata_works_lock deadlock
First crash: 1359d, last: 1335d
Discussions (3)
Title Replies (including bot) Last reply
[PATCH 5.8 000/177] 5.8.10-rc1 review 196 (196) 2020/09/17 17:40
[PATCH] padata: fix possible padata_works_lock deadlock 2 (2) 2020/09/04 08:29
inconsistent lock state in padata_do_parallel 0 (1) 2020/09/02 01:28
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream inconsistent lock state in padata_do_parallel (2) crypto 2 48d 47d 23/26 upstream: reported on 2024/04/01 14:08

Sample crash report:
================================
WARNING: inconsistent lock state
5.9.0-rc2-syzkaller #0 Not tainted
--------------------------------
inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage.
syz-executor.0/26715 [HC0[0]:SC0[0]:HE1:SE1] takes:
ffffffff89c54eb8 (padata_works_lock){+.?.}-{2:2}, at: spin_lock include/linux/spinlock.h:354 [inline]
ffffffff89c54eb8 (padata_works_lock){+.?.}-{2:2}, at: padata_do_parallel+0x4d7/0x860 kernel/padata.c:220
{IN-SOFTIRQ-W} state was registered at:
  lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:5005
  __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
  _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
  spin_lock include/linux/spinlock.h:354 [inline]
  padata_do_parallel+0x4d7/0x860 kernel/padata.c:220
  pcrypt_aead_encrypt+0x39f/0x4d0 crypto/pcrypt.c:115
  crypto_aead_encrypt+0xaa/0xf0 crypto/aead.c:94
  tipc_aead_encrypt net/tipc/crypto.c:736 [inline]
  tipc_crypto_xmit+0x1868/0x2790 net/tipc/crypto.c:1607
  tipc_bearer_xmit_skb+0x180/0x3f0 net/tipc/bearer.c:523
  tipc_disc_timeout+0x84b/0xc90 net/tipc/discover.c:334
  call_timer_fn+0x1ac/0x760 kernel/time/timer.c:1413
  expire_timers kernel/time/timer.c:1458 [inline]
  __run_timers.part.0+0x67c/0xaa0 kernel/time/timer.c:1755
  __run_timers kernel/time/timer.c:1736 [inline]
  run_timer_softirq+0xae/0x1a0 kernel/time/timer.c:1768
  __do_softirq+0x2de/0xa24 kernel/softirq.c:298
  asm_call_on_stack+0xf/0x20 arch/x86/entry/entry_64.S:706
  __run_on_irqstack arch/x86/include/asm/irq_stack.h:22 [inline]
  run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:48 [inline]
  do_softirq_own_stack+0x9d/0xd0 arch/x86/kernel/irq_64.c:77
  invoke_softirq kernel/softirq.c:393 [inline]
  __irq_exit_rcu kernel/softirq.c:423 [inline]
  irq_exit_rcu+0x1f3/0x230 kernel/softirq.c:435
  sysvec_apic_timer_interrupt+0x51/0xf0 arch/x86/kernel/apic/apic.c:1091
  asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581
  tomoyo_check_acl+0xad/0x410 security/tomoyo/domain.c:173
  tomoyo_path_permission security/tomoyo/file.c:586 [inline]
  tomoyo_path_permission+0x1f5/0x360 security/tomoyo/file.c:573
  tomoyo_path_perm+0x2e7/0x3f0 security/tomoyo/file.c:838
  security_inode_getattr+0xcf/0x140 security/security.c:1278
  vfs_getattr fs/stat.c:121 [inline]
  vfs_statx_fd+0x70/0xf0 fs/stat.c:151
  vfs_fstat include/linux/fs.h:3189 [inline]
  __do_sys_newfstat+0x88/0x100 fs/stat.c:398
  do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
  entry_SYSCALL_64_after_hwframe+0x44/0xa9
irq event stamp: 311
hardirqs last  enabled at (311): [<ffffffff8146df01>] __local_bh_enable_ip+0xd1/0x190 kernel/softirq.c:200
hardirqs last disabled at (309): [<ffffffff8146dec9>] __local_bh_enable_ip+0x99/0x190 kernel/softirq.c:177
softirqs last  enabled at (310): [<ffffffff81939bcd>] rcu_read_unlock_bh include/linux/rcupdate.h:719 [inline]
softirqs last  enabled at (310): [<ffffffff81939bcd>] padata_do_parallel+0x49d/0x860 kernel/padata.c:218
softirqs last disabled at (308): [<ffffffff81939767>] padata_do_parallel+0x37/0x860 kernel/padata.c:183

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(padata_works_lock);
  <Interrupt>
    lock(padata_works_lock);

 *** DEADLOCK ***

1 lock held by syz-executor.0/26715:
 #0: ffff88804f22c120 (sk_lock-AF_ALG){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1583 [inline]
 #0: ffff88804f22c120 (sk_lock-AF_ALG){+.+.}-{0:0}, at: aead_recvmsg+0xc1/0x15c0 crypto/algif_aead.c:328

stack backtrace:
CPU: 0 PID: 26715 Comm: syz-executor.0 Not tainted 5.9.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_usage_bug kernel/locking/lockdep.c:4020 [inline]
 valid_state kernel/locking/lockdep.c:3361 [inline]
 mark_lock_irq kernel/locking/lockdep.c:3560 [inline]
 mark_lock.cold+0x7a/0x7f kernel/locking/lockdep.c:4006
 mark_usage kernel/locking/lockdep.c:3923 [inline]
 __lock_acquire+0x8cd/0x5640 kernel/locking/lockdep.c:4380
 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:5005
 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
 _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
 spin_lock include/linux/spinlock.h:354 [inline]
 padata_do_parallel+0x4d7/0x860 kernel/padata.c:220
 pcrypt_aead_encrypt+0x39f/0x4d0 crypto/pcrypt.c:115
 crypto_aead_encrypt+0xaa/0xf0 crypto/aead.c:94
 _aead_recvmsg crypto/algif_aead.c:310 [inline]
 aead_recvmsg+0x844/0x15c0 crypto/algif_aead.c:330
 sock_recvmsg_nosec net/socket.c:885 [inline]
 sock_recvmsg net/socket.c:903 [inline]
 sock_recvmsg net/socket.c:899 [inline]
 ____sys_recvmsg+0x2c4/0x640 net/socket.c:2576
 ___sys_recvmsg+0x127/0x200 net/socket.c:2618
 __sys_recvmsg+0xe2/0x1a0 net/socket.c:2652
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45d5b9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f7547b83c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002f
RAX: ffffffffffffffda RBX: 0000000000026b00 RCX: 000000000045d5b9
RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 000000000118cf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118cf4c
R13: 000000000169fb6f R14: 00007f7547b849c0 R15: 000000000118cf4c

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/08/29 01:24 upstream 96d454cd2c16 d5a3ae1f .config console log report ci-upstream-kasan-gce
2020/09/11 23:28 net-old ee460417d254 79fb24e2 .config console log report ci-upstream-net-this-kasan-gce
2020/09/09 02:19 net-old 19162fd4063a abf9ba4f .config console log report ci-upstream-net-this-kasan-gce
2020/09/05 06:48 net-old c70672d8d316 abf9ba4f .config console log report ci-upstream-net-this-kasan-gce
2020/09/05 06:44 net-old c70672d8d316 abf9ba4f .config console log report ci-upstream-net-this-kasan-gce
2020/09/04 16:17 net-old b61ac5bb420a abf9ba4f .config console log report ci-upstream-net-this-kasan-gce
2020/09/21 20:26 net-next-old 3cec0369905d 9e1fa68e .config console log report info ci-upstream-net-kasan-gce
2020/09/11 23:27 net-next-old 9984c0bb22dc 79fb24e2 .config console log report ci-upstream-net-kasan-gce
2020/09/08 15:36 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.