syzbot

======================================================
WARNING: possible circular locking dependency detected
6.4.0-rc3-syzkaller-00291-g4e893b5aa4ac #0 Not tainted
------------------------------------------------------
syz-executor.3/3000 is trying to acquire lock:
ffff88807cdc0120 (&wnd->rw_lock/1){++++}-{3:3}, at: ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741

but task is already holding lock:
ffff88802fa8a5e0 (&ni->ni_lock#3){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1141 [inline]
ffff88802fa8a5e0 (&ni->ni_lock#3){+.+.}-{3:3}, at: ni_write_inode+0x167/0x10c0 fs/ntfs3/frecord.c:3252

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ni->ni_lock#3){+.+.}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:945
       attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:866
       ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:526
       ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:589
       ni_create_attr_list+0x9d4/0x1510 fs/ntfs3/frecord.c:873
       ni_ins_attr_ext+0x334/0xc00 fs/ntfs3/frecord.c:968
       ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1135
       ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1519
       ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:433
       ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:944
       ntfs3_setattr+0x933/0xb00 fs/ntfs3/file.c:708
       notify_change+0xc8b/0xf40 fs/attr.c:483
       chown_common+0x500/0x850 fs/open.c:774
       do_fchownat+0x16d/0x240 fs/open.c:805
       __do_sys_chown fs/open.c:825 [inline]
       __se_sys_chown fs/open.c:823 [inline]
       __x64_sys_chown+0x82/0x90 fs/open.c:823
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&ni->file.run_lock#2){++++}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
       ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:510
       ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:589
       ntfs_create_inode+0x50e/0x36e0 fs/ntfs3/inode.c:1308
       ntfs_atomic_open+0x3db/0x530 fs/ntfs3/namei.c:434
       atomic_open fs/namei.c:3355 [inline]
       lookup_open fs/namei.c:3463 [inline]
       open_last_lookups fs/namei.c:3560 [inline]
       path_openat+0x103c/0x3170 fs/namei.c:3788
       do_filp_open+0x234/0x490 fs/namei.c:3818
       do_sys_openat2+0x13f/0x500 fs/open.c:1356
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_open fs/open.c:1380 [inline]
       __se_sys_open fs/open.c:1376 [inline]
       __x64_sys_open+0x225/0x270 fs/open.c:1376
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&wnd->rw_lock/1){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3108 [inline]
       check_prevs_add kernel/locking/lockdep.c:3227 [inline]
       validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
       __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
       ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741
       ni_write_inode+0x516/0x10c0 fs/ntfs3/frecord.c:3348
       write_inode fs/fs-writeback.c:1456 [inline]
       __writeback_single_inode+0x69b/0xfa0 fs/fs-writeback.c:1668
       writeback_single_inode+0x21b/0x790 fs/fs-writeback.c:1724
       sync_inode_metadata+0xcc/0x130 fs/fs-writeback.c:2780
       __generic_file_fsync+0x13f/0x190 fs/libfs.c:1138
       generic_file_fsync+0x73/0xf0 fs/libfs.c:1168
       generic_write_sync include/linux/fs.h:2469 [inline]
       ntfs_file_write_iter+0x5c6/0x6d0 fs/ntfs3/file.c:1061
       do_iter_write+0x7b1/0xcb0 fs/read_write.c:860
       iter_file_splice_write+0x843/0xfe0 fs/splice.c:795
       do_splice_from fs/splice.c:873 [inline]
       direct_splice_actor+0xe7/0x1c0 fs/splice.c:1039
       splice_direct_to_actor+0x4c4/0xbd0 fs/splice.c:994
       do_splice_direct+0x283/0x3d0 fs/splice.c:1082
       do_sendfile+0x620/0xff0 fs/read_write.c:1254
       __do_sys_sendfile64 fs/read_write.c:1322 [inline]
       __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1308
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock#3

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ni->ni_lock#3);
                               lock(&ni->file.run_lock#2);
                               lock(&ni->ni_lock#3);
  lock(&wnd->rw_lock/1);

 *** DEADLOCK ***

3 locks held by syz-executor.3/3000:
 #0: ffff88807cdc2460 (sb_writers#22){.+.+}-{0:0}, at: do_sendfile+0x5fb/0xff0 fs/read_write.c:1253
 #1: ffff88802fa8a880 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:775 [inline]
 #1: ffff88802fa8a880 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: __generic_file_fsync+0x9a/0x190 fs/libfs.c:1131
 #2: ffff88802fa8a5e0 (&ni->ni_lock#3){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1141 [inline]
 #2: ffff88802fa8a5e0 (&ni->ni_lock#3){+.+.}-{3:3}, at: ni_write_inode+0x167/0x10c0 fs/ntfs3/frecord.c:3252

stack backtrace:
CPU: 1 PID: 3000 Comm: syz-executor.3 Not tainted 6.4.0-rc3-syzkaller-00291-g4e893b5aa4ac #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3108 [inline]
 check_prevs_add kernel/locking/lockdep.c:3227 [inline]
 validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
 __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:741
 ni_write_inode+0x516/0x10c0 fs/ntfs3/frecord.c:3348
 write_inode fs/fs-writeback.c:1456 [inline]
 __writeback_single_inode+0x69b/0xfa0 fs/fs-writeback.c:1668
 writeback_single_inode+0x21b/0x790 fs/fs-writeback.c:1724
 sync_inode_metadata+0xcc/0x130 fs/fs-writeback.c:2780
 __generic_file_fsync+0x13f/0x190 fs/libfs.c:1138
 generic_file_fsync+0x73/0xf0 fs/libfs.c:1168
 generic_write_sync include/linux/fs.h:2469 [inline]
 ntfs_file_write_iter+0x5c6/0x6d0 fs/ntfs3/file.c:1061
 do_iter_write+0x7b1/0xcb0 fs/read_write.c:860
 iter_file_splice_write+0x843/0xfe0 fs/splice.c:795
 do_splice_from fs/splice.c:873 [inline]
 direct_splice_actor+0xe7/0x1c0 fs/splice.c:1039
 splice_direct_to_actor+0x4c4/0xbd0 fs/splice.c:994
 do_splice_direct+0x283/0x3d0 fs/splice.c:1082
 do_sendfile+0x620/0xff0 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7ff88488c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff88566c168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007ff8849abf80 RCX: 00007ff88488c169
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007ff8848e7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0001000000201005 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffe8709838f R14: 00007ff88566c300 R15: 0000000000022000
 </TASK>