syzbot

F2FS-fs (loop4): Mismatch valid blocks 5 vs. 10
======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-12765-g982818426a0f #0 Not tainted
------------------------------------------------------
syz-executor.4/29929 is trying to acquire lock:
ffff88807869c088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
ffff88807869c088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_handle_error+0xef/0x240 fs/f2fs/super.c:3920

but task is already holding lock:
ffff8880205e43b8 (&array[i].journal_rwsem){++++}-{3:3}, at: build_sit_entries+0xf0f/0x1c80 fs/f2fs/segment.c:4450

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&array[i].journal_rwsem){++++}-{3:3}:
       lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       scan_curseg_cache+0xa6/0x410 fs/f2fs/node.c:2408
       __f2fs_build_free_nids fs/f2fs/node.c:2520 [inline]
       f2fs_build_free_nids+0xf13/0x11a0 fs/f2fs/node.c:2535
       f2fs_fill_super+0x5413/0x7c90 fs/f2fs/super.c:4328
       mount_bdev+0x271/0x3a0 fs/super.c:1371
       legacy_get_tree+0xef/0x190 fs/fs_context.c:610
       vfs_get_tree+0x8c/0x270 fs/super.c:1501
       do_new_mount+0x28f/0xae0 fs/namespace.c:3042
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #3 (&nm_i->nat_tree_lock){++++}-{3:3}:
       lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       f2fs_down_read fs/f2fs/f2fs.h:2188 [inline]
       f2fs_get_node_info+0xf3/0x12d0 fs/f2fs/node.c:564
       f2fs_do_write_data_page+0x10c7/0x27c0 fs/f2fs/data.c:2727
       f2fs_write_single_data_page+0x1466/0x2080 fs/f2fs/data.c:2862
       f2fs_write_cache_pages fs/f2fs/data.c:3145 [inline]
       __f2fs_write_data_pages fs/f2fs/data.c:3296 [inline]
       f2fs_write_data_pages+0x1fac/0x35e0 fs/f2fs/data.c:3323
       do_writepages+0x3a6/0x670 mm/page-writeback.c:2551
       filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:390
       __filemap_fdatawrite_range mm/filemap.c:423 [inline]
       filemap_write_and_wait_range+0x1d4/0x2c0 mm/filemap.c:678
       f2fs_collapse_range+0x314/0x3b0 fs/f2fs/file.c:1443
       f2fs_fallocate+0x46f/0x6d0 fs/f2fs/file.c:1837
       vfs_fallocate+0x54b/0x6b0 fs/open.c:324
       ksys_fallocate fs/open.c:347 [inline]
       __do_sys_fallocate fs/open.c:355 [inline]
       __se_sys_fallocate fs/open.c:353 [inline]
       __x64_sys_fallocate+0xbd/0x100 fs/open.c:353
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (mapping.invalidate_lock#3){++++}-{3:3}:
       lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
       filemap_fault+0x644/0x1800 mm/filemap.c:3274
       f2fs_filemap_fault+0x81/0x3f0 fs/f2fs/file.c:44
       __do_fault+0x136/0x500 mm/memory.c:4141
       do_read_fault mm/memory.c:4492 [inline]
       do_fault mm/memory.c:4621 [inline]
       handle_pte_fault mm/memory.c:4909 [inline]
       __handle_mm_fault mm/memory.c:5051 [inline]
       handle_mm_fault+0x3357/0x51c0 mm/memory.c:5197
       do_user_addr_fault arch/x86/mm/fault.c:1407 [inline]
       handle_page_fault arch/x86/mm/fault.c:1498 [inline]
       exc_page_fault+0x685/0x8a0 arch/x86/mm/fault.c:1554
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
       fault_in_readable+0x1cc/0x350
       fault_in_iov_iter_readable+0xdf/0x280 lib/iov_iter.c:350
       f2fs_preallocate_blocks fs/f2fs/file.c:4441 [inline]
       f2fs_file_write_iter+0xaa3/0x2c60 fs/f2fs/file.c:4672
       call_write_iter include/linux/fs.h:1851 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x7b2/0xbb0 fs/read_write.c:584
       ksys_write+0x1a0/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
       __might_fault+0xba/0x120 mm/memory.c:5625
       _copy_to_user+0x2a/0x130 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline]
       __f2fs_ioctl+0xaee1/0xb4d0 fs/f2fs/file.c:4169
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&sbi->sb_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
       lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
       f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
       f2fs_handle_error+0xef/0x240 fs/f2fs/super.c:3920
       check_block_count+0x35b/0x490
       build_sit_entries+0x110f/0x1c80 fs/f2fs/segment.c:4470
       f2fs_build_segment_manager+0x201f/0x31d0 fs/f2fs/segment.c:5159
       f2fs_fill_super+0x53d5/0x7c90 fs/f2fs/super.c:4322
       mount_bdev+0x271/0x3a0 fs/super.c:1371
       legacy_get_tree+0xef/0x190 fs/fs_context.c:610
       vfs_get_tree+0x8c/0x270 fs/super.c:1501
       do_new_mount+0x28f/0xae0 fs/namespace.c:3042
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &sbi->sb_lock --> &nm_i->nat_tree_lock --> &array[i].journal_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&array[i].journal_rwsem);
                               lock(&nm_i->nat_tree_lock);
                               lock(&array[i].journal_rwsem);
  lock(&sbi->sb_lock);

 *** DEADLOCK ***

2 locks held by syz-executor.4/29929:
 #0: ffff88807e32a0e0 (&type->s_umount_key#48/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228
 #1: ffff8880205e43b8 (&array[i].journal_rwsem){++++}-{3:3}, at: build_sit_entries+0xf0f/0x1c80 fs/f2fs/segment.c:4450

stack backtrace:
CPU: 1 PID: 29929 Comm: syz-executor.4 Not tainted 6.2.0-syzkaller-12765-g982818426a0f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
 lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573
 f2fs_down_write fs/f2fs/f2fs.h:2213 [inline]
 f2fs_handle_error+0xef/0x240 fs/f2fs/super.c:3920
 check_block_count+0x35b/0x490
 build_sit_entries+0x110f/0x1c80 fs/f2fs/segment.c:4470
 f2fs_build_segment_manager+0x201f/0x31d0 fs/f2fs/segment.c:5159
 f2fs_fill_super+0x53d5/0x7c90 fs/f2fs/super.c:4322
 mount_bdev+0x271/0x3a0 fs/super.c:1371
 legacy_get_tree+0xef/0x190 fs/fs_context.c:610
 vfs_get_tree+0x8c/0x270 fs/super.c:1501
 do_new_mount+0x28f/0xae0 fs/namespace.c:3042
 do_mount fs/namespace.c:3385 [inline]
 __do_sys_mount fs/namespace.c:3594 [inline]
 __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f8c0c48d62a
Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8c0affdf88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000005501 RCX: 00007f8c0c48d62a
RDX: 0000000020000040 RSI: 0000000020000080 RDI: 00007f8c0affdfe0
RBP: 00007f8c0affe020 R08: 00007f8c0affe020 R09: 0000000002800011
R10: 0000000002800011 R11: 0000000000000202 R12: 0000000020000040
R13: 0000000020000080 R14: 00007f8c0affdfe0 R15: 0000000020005680
 </TASK>
F2FS-fs (loop4): Failed to initialize F2FS segment manager (-117)