syzbot

======================================================
WARNING: possible circular locking dependency detected
6.7.0-rc5-syzkaller-00230-g3b8a9b2e6809 #0 Not tainted
------------------------------------------------------
syz-executor156/5090 is trying to acquire lock:
ffff888019696090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27

but task is already holding lock:
ffff888029a94510 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x17a/0x380 mm/memory.c:2944

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_pagefaults){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1635 [inline]
       sb_start_pagefault include/linux/fs.h:1739 [inline]
       filemap_page_mkwrite+0x174/0x7a0 mm/filemap.c:3577
       do_page_mkwrite+0x17a/0x380 mm/memory.c:2944
       do_shared_fault mm/memory.c:4705 [inline]
       do_fault mm/memory.c:4767 [inline]
       do_pte_missing mm/memory.c:3731 [inline]
       handle_pte_fault mm/memory.c:5039 [inline]
       __handle_mm_fault+0x2a3b/0x3d70 mm/memory.c:5180
       handle_mm_fault+0x47a/0xa10 mm/memory.c:5345
       do_user_addr_fault+0x3d1/0x1000 arch/x86/mm/fault.c:1413
       handle_page_fault arch/x86/mm/fault.c:1505 [inline]
       exc_page_fault+0x5d/0xc0 arch/x86/mm/fault.c:1561
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault mm/memory.c:5956 [inline]
       __might_fault+0x11f/0x1a0 mm/memory.c:5949
       reiserfs_ioctl+0x1c4/0x2e0 fs/reiserfs/ioctl.c:96
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl fs/ioctl.c:857 [inline]
       __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x63/0x6b

-> #0 (&sbi->lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137
       lock_acquire kernel/locking/lockdep.c:5754 [inline]
       lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:747
       reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27
       reiserfs_dirty_inode+0xe6/0x270 fs/reiserfs/super.c:704
       __mark_inode_dirty+0x1e0/0xd60 fs/fs-writeback.c:2452
       generic_update_time+0xcf/0xf0 fs/inode.c:1943
       inode_update_time fs/inode.c:1956 [inline]
       __file_update_time fs/inode.c:2144 [inline]
       file_update_time+0x12c/0x160 fs/inode.c:2174
       filemap_page_mkwrite+0x295/0x7a0 mm/filemap.c:3578
       do_page_mkwrite+0x17a/0x380 mm/memory.c:2944
       do_shared_fault mm/memory.c:4705 [inline]
       do_fault mm/memory.c:4767 [inline]
       do_pte_missing mm/memory.c:3731 [inline]
       handle_pte_fault mm/memory.c:5039 [inline]
       __handle_mm_fault+0x2a3b/0x3d70 mm/memory.c:5180
       handle_mm_fault+0x47a/0xa10 mm/memory.c:5345
       do_user_addr_fault+0x3d1/0x1000 arch/x86/mm/fault.c:1413
       handle_page_fault arch/x86/mm/fault.c:1505 [inline]
       exc_page_fault+0x5d/0xc0 arch/x86/mm/fault.c:1561
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570

other info that might help us debug this:

Chain exists of:
  &sbi->lock --> &mm->mmap_lock --> sb_pagefaults

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(sb_pagefaults);
                               lock(&mm->mmap_lock);
                               lock(sb_pagefaults);
  lock(&sbi->lock);

 *** DEADLOCK ***

2 locks held by syz-executor156/5090:
 #0: ffff888018b7f6a0 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:165 [inline]
 #0: ffff888018b7f6a0 (&mm->mmap_lock){++++}-{3:3}, at: get_mmap_lock_carefully mm/memory.c:5372 [inline]
 #0: ffff888018b7f6a0 (&mm->mmap_lock){++++}-{3:3}, at: lock_mm_and_find_vma+0x35/0x580 mm/memory.c:5432
 #1: ffff888029a94510 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x17a/0x380 mm/memory.c:2944

stack backtrace:
CPU: 1 PID: 5090 Comm: syz-executor156 Not tainted 6.7.0-rc5-syzkaller-00230-g3b8a9b2e6809 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106
 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137
 lock_acquire kernel/locking/lockdep.c:5754 [inline]
 lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:747
 reiserfs_write_lock+0x79/0x100 fs/reiserfs/lock.c:27
 reiserfs_dirty_inode+0xe6/0x270 fs/reiserfs/super.c:704
 __mark_inode_dirty+0x1e0/0xd60 fs/fs-writeback.c:2452
 generic_update_time+0xcf/0xf0 fs/inode.c:1943
 inode_update_time fs/inode.c:1956 [inline]
 __file_update_time fs/inode.c:2144 [inline]
 file_update_time+0x12c/0x160 fs/inode.c:2174
 filemap_page_mkwrite+0x295/0x7a0 mm/filemap.c:3578
 do_page_mkwrite+0x17a/0x380 mm/memory.c:2944
 do_shared_fault mm/memory.c:4705 [inline]
 do_fault mm/memory.c:4767 [inline]
 do_pte_missing mm/memory.c:3731 [inline]
 handle_pte_fault mm/memory.c:5039 [inline]
 __handle_mm_fault+0x2a3b/0x3d70 mm/memory.c:5180
 handle_mm_fault+0x47a/0xa10 mm/memory.c:5345
 do_user_addr_fault+0x3d1/0x1000 arch/x86/mm/fault.c:1413
 handle_page_fault arch/x86/mm/fault.c:1505 [inline]
 exc_page_fault+0x5d/0xc0 arch/x86/mm/fault.c:1561
 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
RIP: 0033:0x7f1aad278e00
Code: 09 00 00 00 e8 f1 43 03 00 48 8b 35 1a d3 0a 00 ba ff 7f 00 02 31 c0 bf 4d 00 00 00 e8 d9 43 03 00 31 c9 ba 42 da 14 00 31 c0 <c7> 04 25 c0 00 00 20 2e 2f 62 75 be c0 00 00 20 bf 02 00 00 00 66
RSP: 002b:00007ffe591027b0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 000000000014da42 RSI: 0000000002007fff RDI: 0000000000000004
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000246 R12: 00007ffe591027dc
R13: 000000000000000e R14: 431bde82d7b634db R15: 00007ffe59102810
 </TASK>